Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1048-g9229b632c5-fm-20231019.001-g9229b632
MIME-Version: 1.0
Message-Id: <b86551ec-5f5d-4fee-9d79-01b04c30e447@app.fastmail.com>
In-Reply-To: <20231027171756.1241002-2-stephen.s.brennan@oracle.com>
References: <20231027171756.1241002-1-stephen.s.brennan@oracle.com>
 <20231027171756.1241002-2-stephen.s.brennan@oracle.com>
Date:   Fri, 27 Oct 2023 20:20:56 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Stephen Brennan" <stephen.s.brennan@oracle.com>
Cc:     Linux-Arch <linux-arch@vger.kernel.org>,
        linux-kernel@vger.kernel.org, linux-debuggers@vger.kernel.org,
        "Mike Christie" <michael.christie@oracle.com>,
        "Geert Uytterhoeven" <geert+renesas@glider.be>,
        "Christian Brauner" <brauner@kernel.org>,
        "Petr Mladek" <pmladek@suse.com>, "Marco Elver" <elver@google.com>,
        "Randy Dunlap" <rdunlap@infradead.org>,
        "Doug Anderson" <dianders@chromium.org>,
        "Maninder Singh" <maninder1.s@samsung.com>,
        "Luis Chamberlain" <mcgrof@kernel.org>,
        "Nick Desaulniers" <ndesaulniers@google.com>,
        "Zhen Lei" <thunder.leizhen@huawei.com>,
        "Kees Cook" <keescook@chromium.org>,
        "Zhaoyang Huang" <zhaoyang.huang@unisoc.com>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Sami Tolvanen" <samitolvanen@google.com>
Subject: Re: [PATCH v3 1/1] kernel/config: Introduce CONFIG_DEBUG_INFO_IKCONFIG
Content-Type: text/plain
Precedence: bulk

On Fri, Oct 27, 2023, at 19:17, Stephen Brennan wrote:
> The option CONFIG_IKCONFIG allows the gzip compressed kernel
> configuration to be included into vmlinux or a module. In these cases,
> debuggers can access the config data and use it to adjust their behavior
> according to the configuration. However, distributions rarely enable
> this, likely because it uses a fair bit of kernel memory which cannot be
> swapped out.
>
> This means that in practice, the kernel configuration is rarely
> available to debuggers.
>
> So, introduce an alternative, CONFIG_DEBUG_INFO_IKCONFIG. This strategy,
> which is only available if IKCONFIG is not already built-in, adds a
> section ".debug_linux_ikconfig", to the vmlinux ELF. It will be stripped
> out of the final images, but will remain in the debuginfo files. So
> debuggers which rely on vmlinux debuginfo can have access to the kernel
> configuration, without incurring a cost to the kernel at runtime.
>
> The configuration is enabled whenever DEBUG_INFO=y and IKCONFIG!=y. The
> added section is not large compared to debug info sizes. It won't affect
> the runtime kernel at all, and this default will ensure that
> distributions intending to create useful debuginfo will get this new
> addition for kernel debuggers.
>
> Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
> ---
>  include/asm-generic/vmlinux.lds.h |  3 ++-
>  kernel/Makefile                   |  2 ++
>  kernel/configs-debug.S            | 18 ++++++++++++++++++
>  lib/Kconfig.debug                 | 15 +++++++++++++++
>  4 files changed, 37 insertions(+), 1 deletion(-)
>  create mode 100644 kernel/configs-debug.S

For asm-generic:

Acked-by: Arnd Bergmann <arnd@arndb.de>