Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Frank Li <Frank.Li@nxp.com>
To:     imx@lists.linux.dev, Peter Chen <peter.chen@kernel.org>,
        Pawel Laszczak <pawell@cadence.com>,
        Roger Quadros <rogerq@kernel.org>,
        Aswath Govindraju <a-govindraju@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org (open list:CADENCE USB3 DRD IP DRIVER),
        linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/1] usb: cdns3: skip set TRB_IOC when usb_request: no_interrupt is true
Date:   Fri, 27 Oct 2023 14:39:19 -0400
Message-Id: <20231027183919.664271-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TQuUYNF+QwDTojnCqVsBeZmDUrJS7t8Cx7Qbz2E3fLBf0enZWR2liSh4oJ7X?=
 =?us-ascii?Q?qptgfz00uZ2s04oKJ9mpEuSGmWBTbwvXAlsO8R9vIjxsYnHk9thxNNbB714O?=
 =?us-ascii?Q?nBD8JfWOLk8MHpOQzGP4/ErVaG/nItRdrpXTe1OM1AuQLRU2iAetsz1mR7ei?=
 =?us-ascii?Q?qAkNkoBHNDScZvtovhvOXnM6VleaACB6lF1lxhGP2kQyj+WeberiirQKQi+9?=
 =?us-ascii?Q?5Y9XLiT3kFtE8qCg+gYA7+N4aUwsjK3aQc1ZEZtMWb25ywNeqSHfk2P9ZNaK?=
 =?us-ascii?Q?09+m8hTHX//wF3WYiAFVhkuDhrX58u81bKmGhPcz3vk8lvf9ih5fqcakVFbj?=
 =?us-ascii?Q?+j9jbBFoMGMo9IQZP7BY28Q7wVC7Fja14+zX03wm94v9yMuMXADmL9+tKCTJ?=
 =?us-ascii?Q?tVzC8y2TRfYynr2DXPF2Cu7HNALywtqyP4oBRDJc1L0ptr1XEDzwHl5up9WC?=
 =?us-ascii?Q?llIFx6FUXrJCtsavXtucJE1l89sU+A6YYKI/KR2rfgLSVl4hj8nPinqC8qYn?=
 =?us-ascii?Q?Xd+afwqUOL6t6CYxzc/VztLQeaQe1TRmY2zuruq3tL5CNTG/4E2DaIPwFguH?=
 =?us-ascii?Q?AxmMI91P2RL9Le7tomxBA9KLldQg4kDfxcC014CiQxzFX4C9ZMEu4WBceFRC?=
 =?us-ascii?Q?XiM7kYC4f76lH16HAYc2v7WCvYK1XLnqBFEaRATIb2GsB8Cf1vlQrUiG+SYL?=
 =?us-ascii?Q?aSNlkwyVj0TvHHBaaRIt0oC6ikrxHgQIFzO+RAOxQlf+b4vABoM4a4PtfMD5?=
 =?us-ascii?Q?8Qjk8tEGdYpQGJbQrvka3fWcgs4gVblY3cL6PH3pKD6FKgWXfL1HL1GcoDNN?=
 =?us-ascii?Q?2w34UW5Zgvi7bgXgiZglc1BHXFriLIFLABwmxwMrfe7zxynLgjJzwPWRjPW3?=
 =?us-ascii?Q?CrSxdZ6EILiLFFRv9Rv8HnydeCF4csqkPeOBM7XwPrT5mkoTzrnXFH3WJjNC?=
 =?us-ascii?Q?vH6U1Neoo8k+zXzIJoRXigbg9vaaxf42YnahoJMIdQ+mXLEF7bsPC7mVcO5z?=
 =?us-ascii?Q?TaKLvEs1M0dqgJFNVNpR38tWsSkM61MrE4wvz1WnF+Nw+X58+anPRb0X4bPJ?=
 =?us-ascii?Q?W3i27c7pBAOmnqR9TVyrucyB7YEj+14VVEHaiD39PQ52+xMJoarg/v5NgfN/?=
 =?us-ascii?Q?4tbg11P7YMxn9XoZ4pWyd3QhKW4MiBXctHbEE5CnJhTc0j0UEn+VKb6/DdLw?=
 =?us-ascii?Q?CqkvqP07xN+GAlieU5qi2tuogC5CVQhScGCkH9b5akDh/lnebvims9C3EsLp?=
 =?us-ascii?Q?l2Jcv0wbWm/dZWFr6B+N8CZ2unP78lBsC9fRtghn2AmKBOq1562cl6gd6Ac+?=
 =?us-ascii?Q?mmi26ti+qt8ACWTJoERmCsH1Y8qW/FW9R3LPntTLKC79/EQvb0iNM13HTstN?=
 =?us-ascii?Q?X39KuMbcGVl3CgmojwdoeCOD9bHfs8ex3CUn3lKWgFPztAY46uvF4dSbT5Xt?=
 =?us-ascii?Q?SlbxG/kMT0BqIlAhDO4ZOVDdAVtJRGLHK/+qoIQSSiIJj+hwwMJkWsvC/wBe?=
 =?us-ascii?Q?dn21nVrF1G7T9N/B+17BUqd7DaVWzZTmDXpatrkykhR5DT8K7uP3cGO/zu76?=
 =?us-ascii?Q?lpGwJgQVLqz+1l7wp+nE1P4339b4yKbeBfWjtR1a?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68056964-25c0-4e95-1166-08dbd71c0f10
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 18:39:31.8586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Czg2pLSrutwGmDMzA5u7SiCTWDfPwrfUwGivTUPVsdfEFVYeqSLBmppACtDJlwnL7OkIBcQ9RxSMLGmgkt1pWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9196
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 27 Oct 2023 11:39:53 -0700 (PDT)

No completion irq is needed if no_interrupt is true. Needn't set TRB_IOC
at this case.

Check usb_request: no_interrupt and set/skip TRB_IOC in
cdns3_ep_run_transfer().

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/usb/cdns3/cdns3-gadget.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
index 69a44bd7e5d02..cd08897f8da8b 100644
--- a/drivers/usb/cdns3/cdns3-gadget.c
+++ b/drivers/usb/cdns3/cdns3-gadget.c
@@ -1124,6 +1124,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
 	u16 total_tdl = 0;
 	struct scatterlist *s = NULL;
 	bool sg_supported = !!(request->num_mapped_sgs);
+	u32 ioc = request->no_interrupt ? 0 : TRB_IOC;
 
 	if (priv_ep->type == USB_ENDPOINT_XFER_ISOC)
 		num_trb = priv_ep->interval;
@@ -1233,11 +1234,11 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
 			control |= pcs;
 
 		if (priv_ep->type == USB_ENDPOINT_XFER_ISOC  && !priv_ep->dir) {
-			control |= TRB_IOC | TRB_ISP;
+			control |= ioc | TRB_ISP;
 		} else {
 			/* for last element in TD or in SG list */
 			if (sg_iter == (num_trb - 1) && sg_iter != 0)
-				control |= pcs | TRB_IOC | TRB_ISP;
+				control |= pcs | ioc | TRB_ISP;
 		}
 
 		if (sg_iter)
@@ -1268,7 +1269,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
 	priv_req->num_of_trb = num_trb;
 
 	if (sg_iter == 1)
-		trb->control |= cpu_to_le32(TRB_IOC | TRB_ISP);
+		trb->control |= cpu_to_le32(ioc | TRB_ISP);
 
 	if (priv_dev->dev_ver < DEV_VER_V2 &&
 	    (priv_ep->flags & EP_TDLCHK_EN)) {
-- 
2.34.1