Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1364903rdh; Fri, 27 Oct 2023 11:57:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSNWCPyXB9hQDScfYB9jN2SOFRUAQhg4C+2fWKXNLk46B5Ueb2m2b9rBqw2FTi6GkcqxNV X-Received: by 2002:a5b:88a:0:b0:d9b:ea48:e5c8 with SMTP id e10-20020a5b088a000000b00d9bea48e5c8mr3231188ybq.59.1698433024372; Fri, 27 Oct 2023 11:57:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698433024; cv=none; d=google.com; s=arc-20160816; b=uesxujgTPPybemAaMUevT1k1UfAtHuiOl6iG1YN5uLxmYUurpUzBHQ0sIqTP8ux00+ QgUHFtP97P92ZN9bjeTBhC0Yd0opAhBDjLZm/gzR9kwmpSFfQxUNTdYZCDe12BU7hbR8 qr+9z388ex7fTwCAeM4HNbdttyhs92f9NKdpPXWnUYYaH20hL5XYrU2TTR1fC17GROPf O3dmYOAUq6nWYBrSoI0bRYNJKfjJaQIRHkpUlDSrWySSMblT8NUaUmcQ9v7V9Lnjv4Mo z1f+vCAfktwH3VvP24jILS3gNiK8c7hKbxujYCFJzqL5ROAQ6jmh+VhVoR8yYC/7ZpxW eWmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=8Ng2tJqwczIjFESHm7ZVk4sDc0+QSuVVNEX3VTMD8Ig=; fh=fRIAE3MY4t9gjMMJuxKqIKvQa0AJaqHvDJAAMlzLH1U=; b=R2+Vv7BF9abQ5RrZBZPIJjGywCeWNpEwUPL76UGJCwrvZQOApI0u/r4ngwgUWyr8OK ysjdkEsKRiQaW+fJqzwriU3I1wvJVrNWjgfP1szPYOULchD7jCaxSrNcPhrn9RiL23Ex AvayEgTtPtekvEctD09njP6gVxu+P+bCi3lI6fjd+7LS7mAfGKeLTwjAnS1NgRlm++gV uOTNHvNRQVD+ZTXKtn9RBCxolqqyUl21D8pCgoZxalh6UF3dTgfla462WWSXO5eFuVBx MsNhqJWQ+Xo/OSleJnTd3F7zVMpISeSNHyPT5A7ctoID6KZmKVezDSgezNU1hv/ybz0r HNQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=XhRxQ4TC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id 9-20020a251909000000b00da0ade3cbb0si3090173ybz.547.2023.10.27.11.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 11:57:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=XhRxQ4TC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id E1EE1809C90B; Fri, 27 Oct 2023 11:57:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232411AbjJ0S4x (ORCPT + 99 others); Fri, 27 Oct 2023 14:56:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231461AbjJ0S4w (ORCPT ); Fri, 27 Oct 2023 14:56:52 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0AE5E1 for ; Fri, 27 Oct 2023 11:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8Ng2tJqwczIjFESHm7ZVk4sDc0+QSuVVNEX3VTMD8Ig=; b=XhRxQ4TCMzIPi5sbMUJ7mDQoBq z/et/pXHSr7Gx+34bRYCEFvH4albrd8bp49wtTNygLvtlKBnHvsId8NYjEJg5jNaTxdYU0R/BCxw0 gGncfKGG+VBJu4MNRCsd/2+2aZpkCQNj0fZqXNNMwnh84w5Z5elFIryuMPVhb+TErTq5PHADAA8PA Mx8az1ilsuisjL+XZbS0DMvX2qdTlyCJDPhP4OK4LIRVAKftRcC6ylq8Jf0mAb+Y0rJx2Qo38T7e/ vGY1U6SqDSFiq3idYt1eno0ybplG4BtmJFfrTq/tpMRK8yvJWOv7FN8tm8R9HfZ06Ls97mJpfCi06 fZ+l5OSQ==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qwS0f-0051TA-Mk; Fri, 27 Oct 2023 18:56:41 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5D682300392; Fri, 27 Oct 2023 20:56:41 +0200 (CEST) Date: Fri, 27 Oct 2023 20:56:41 +0200 From: Peter Zijlstra To: Borislav Petkov Cc: X86 ML , Kishon VijayAbraham , LKML Subject: Re: [PATCH 2/2] x86/barrier: Do not serialize MSR accesses on AMD Message-ID: <20231027185641.GE26550@noisy.programming.kicks-ass.net> References: <20230622095212.20940-1-bp@alien8.de> <20230703125419.GJ4253@hirez.programming.kicks-ass.net> <20230704074631.GAZKPOV/9BfqP0aU8v@fat_crate.local> <20230704090132.GP4253@hirez.programming.kicks-ass.net> <20230704092222.GBZKPkzgdM8rbPe7zA@fat_crate.local> <20231027153327.GKZTvYR3qslaTUjtCT@fat_crate.local> <20231027153458.GMZTvYou1tlK6HD8/Y@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231027153458.GMZTvYou1tlK6HD8/Y@fat_crate.local> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 27 Oct 2023 11:57:02 -0700 (PDT) On Fri, Oct 27, 2023 at 05:34:58PM +0200, Borislav Petkov wrote: > +static inline void weak_wrmsr_fence(void) > +{ > + alternative("mfence; lfence", "", ALT_VENDOR(X86_VENDOR_AMD)); > +} Well, you see, AFAICT the non-serializing MSRs thing is an Intel thing, so everything !Intel wants this gone, no? Definitely the Hygon thing wants this right along with AMD, because that's basically AMD, no?