Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Fri, 27 Oct 2023 13:04:30 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Terry Bowman <terry.bowman@amd.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: RE: [PATCH v12 02/20] cxl/core/regs: Rename @dev to @host in struct
 cxl_register_map
Message-ID: <653c17ceaf30_244c8f2943a@dwillia2-xfh.jf.intel.com.notmuch>
References: <20231018171713.1883517-1-rrichter@amd.com>
 <20231018171713.1883517-3-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231018171713.1883517-3-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v8yZRmhsWUBXDxzSQ6OtjNzZh6t7utW6blDG3KFiphwJdHn9DD9oxNdDuUkV?=
 =?us-ascii?Q?QMI7QEijEFdpMoWmcPo2aIuu+iIXUhzWpG/0Ac/g9HUUBpDWotLyKyG22qsZ?=
 =?us-ascii?Q?jKTdQvk3rzdEI0QfdpNbhl6pV1bdvDFgoJb24db7ubwt/P1hnL3fbKxIhDse?=
 =?us-ascii?Q?24aUNwU1bpetB7i1f01MYUdx97ti/AmfRZJNf8u/WES6xDHInqBWHXNS5IZm?=
 =?us-ascii?Q?ilKJHI0pXVsNAa9MF86GH2tQf214u6ZadyFQd6NrGdcof2CTshwG++EquMei?=
 =?us-ascii?Q?c5UanmbJg7pUc2Y0MO93ldGOixmr4MjXRvJWcB55sX1w09lJ28B3RsIhmc1P?=
 =?us-ascii?Q?I5nn/rM2InVEi4oQOHob4slOA857ZP7k81/+F0gCAnKogTgBjmB0AfGPmzYd?=
 =?us-ascii?Q?u7q3JTt4w1V7/m1A1sIYp1mlkz3AQXvoUW2FyT+v7zZqXsZ4NoFITu0VLjpL?=
 =?us-ascii?Q?yysbghfp0X3eiOJXf//8FhakBXWt6EafBImcz/NuhCxXrMnKoFfosgy4kDIP?=
 =?us-ascii?Q?8YO0sZPJjNVCbLlQ1UyOUh9uwuGXdXkWELOPYyOomrgNrBk4/zIHvyDciYz7?=
 =?us-ascii?Q?Ee2Vmar92IwFbH69kAoO9NdXYf0s4YqDMXirqVo/Z/Oq/m+d0AJn8W2SmQ0l?=
 =?us-ascii?Q?vFaw3BuOAfKE6y50aIy6V92txUpDRP5Kg9KWHU2iYQPpECnpN61yiF4k8xc0?=
 =?us-ascii?Q?C7F/bNFFKfPP3K47OYHOFcPB0La1pvuGIAQ20HhvK11A+aMCTgkc04yNfLgq?=
 =?us-ascii?Q?vcg/4k34yT4dCmH3HiyznQCeqwBuCvhrR3pNeCMrnDpcTTMCpmQ/tVoih48R?=
 =?us-ascii?Q?o2MUgSrqMi4t9tqSmIhWfx1VAHUeQpCZUBkgkSr6jSp0MI4VeT/6MaigYnZH?=
 =?us-ascii?Q?y2UYWIk2bsdRODN8sf2Tuv2lhMBaPtp2R4QC4s7fCWjtu0MaqrGZ2owJEoWT?=
 =?us-ascii?Q?AaWJ6VF7ZC71/xaFIlbOp5VQUzmtfj8koIjzzu7ruI7ToVDx6c4wNFj83jZj?=
 =?us-ascii?Q?BA+mU9bblTTg+DwmeH/JKmlE0FpKRdx7SCeXyBs9Yyny0w5hUXt6UeasGrwm?=
 =?us-ascii?Q?SXF9teGF1n+Dt7P1zN+EDVHspmNVCCvubtES4LY3Fb/oofk6oae5RfJat98x?=
 =?us-ascii?Q?VbwHu7lT6EjvzkKdBJ/dTL4CRroM5fuWXyCPvZ3dWgl/xDg8z9LInn1tS5fl?=
 =?us-ascii?Q?dMuu7iFJUPwv660FV+K7r14LZNqnOd+wgsNaVD0tz9fUxPokKNUsLzjGJCO8?=
 =?us-ascii?Q?KqRRMMhWvSIOhTTH34A1ZbYNNexilVE61Qe4EX3I4GlsC9HcJTdwyc1X6yjT?=
 =?us-ascii?Q?/QFKpNx+Q1I5ufRgnMnxgIstbhdaPnMGg513NR8sa0g+pmhOnWFgoLu9RbCx?=
 =?us-ascii?Q?k7dA38CURLrsmyuhGBKBGtxDEaR+S6sGxtwIadzr48A8pc/WYYKJSAbdTm5n?=
 =?us-ascii?Q?2z0wNJOsxIFale5aJpqWRx9XZujLdJH8EU2P2XV+DiXCNeLkBp0O/V8XQ1l0?=
 =?us-ascii?Q?YTIvM33ApBV1eeu7PU9FBydHWf50+gN6ujpTDbHrppYdNB3XoCqdAofWwX8/?=
 =?us-ascii?Q?UJIjKrFni7fdVuiMXP99zpKGmhsO/pCTLV31qmz0gV6O73pCnK9cmF1dzHKa?=
 =?us-ascii?Q?IA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f50f8b1e-67bc-4ec2-b8d5-08dbd727ef8c
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 20:04:32.7159
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Iy/RxFq07y201BspumeoQ2CDFiUX/HzbmvJdMcP8UmuOY4rpLdIqAhaoJM7jZNmBYqtAvXiPknjcQtdyLlT3ywmHEC68RiGkMPNuSk5eMRc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4860
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 27 Oct 2023 13:04:42 -0700 (PDT)

Robert Richter wrote:
> The primary role of @dev is to host the mappings for devm operations.
> @dev is too ambiguous as a name. I.e. when does @dev refer to the
> 'struct device *' instance that the registers belong, and when does
> @dev refer to the 'struct device *' instance hosting the mapping for
> devm operations?
> 
> Clarify the role of @dev in cxl_register_map by renaming it to @host.
> Also, rename local variables to 'host' where map->host is used.
> 
> Add Fixes: tag as the fix in the next patch depends on this change.

I tend to not add Fixes tags where they are not needed. When the next
patch fails to backport automatically we will get involved to send the
full backport set. In fact I prefer that as a checkpoint to review the
backport.

Otherwise, looks good to me.