Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Fri, 27 Oct 2023 14:54:10 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Terry Bowman <terry.bowman@amd.com>,
        Robert Richter <rrichter@amd.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: RE: [PATCH v12 08/20] cxl/pci: Remove Component Register base
 address from struct cxl_dev_state
Message-ID: <653c3182d5351_244c8f2943c@dwillia2-xfh.jf.intel.com.notmuch>
References: <20231018171713.1883517-1-rrichter@amd.com>
 <20231018171713.1883517-9-rrichter@amd.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231018171713.1883517-9-rrichter@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QaW3oBIE/qH8rbs7fDdzwpQT2Ll6aEDEgFZesrB1VYamgRtgaeDRBAdI6esB?=
 =?us-ascii?Q?CwJe+QNXdZIV7t7tofW6Vcc4X9pqDv4chNeu5tOCoXQMfXMAoDAZxTGbotLs?=
 =?us-ascii?Q?JwrgE5Y4t3mJa9H8+hBsbYt3lFqgXWam0k3dbNV49iRS2HQSEa02DI9UN33N?=
 =?us-ascii?Q?E56P+HDno7rSHAnPrUxiAf66QSB5M5zBIZWgM0/BpohR1Z79+aSK8s1sSBBs?=
 =?us-ascii?Q?1Iu8h4G6zDM5TBwG+ZDLjPoU4e+Kf4xYzXwisRTuM4MRMcqULOQoIzbHpWei?=
 =?us-ascii?Q?eh5ZFmfJALfgKqdxqzF0/D8IqQmvgQR7Q2MrpL4hYmoNDWT1r76bWYiBVuBo?=
 =?us-ascii?Q?cUInyLisSL6FbvIwkuOBoDmUfgtWbdiXwUwIdDqVehD+Voino7wA1H7w1lOo?=
 =?us-ascii?Q?vNeyeHvL/+W1kJSyf2t8u1kzgdX1iFjcUiZBBffb+wjvxnPR922KEKUZuG4/?=
 =?us-ascii?Q?8FvaQ0EKZr8X2yrKmVjdbirWTD0xh4QgbN0FLeX/CeD1IgAranaLZVavYc0X?=
 =?us-ascii?Q?tja1HrivqdLFWrraHcYHD7f2TC3YP98ENWCr+li4I0bGpcsNoEWVe7Az4mbp?=
 =?us-ascii?Q?j8nUKhiBL2FyH1txnjqWA0ybNO1UmlCeW5v9O+Dr+cKM58kdtNDq18NvA/BK?=
 =?us-ascii?Q?aI/ID8PQ7PfyvJI5ywHt74xggKj7vvabeqCuG8HHNpyn3l0U7Jy5HDJmP4jW?=
 =?us-ascii?Q?BS5qA9j4v7c37RogBmwF0LDvtCAVIlFrTdI3fTxKM3DoOYSiIU+kud1U6cyB?=
 =?us-ascii?Q?b2nhxJBb7DIfZk7iPROyajxeJ4A/GQLeX2jEKfDQG1VraxbVGSAazjRvmN7p?=
 =?us-ascii?Q?/maqT96urrkVh8/8BfD7aJhi7To8IyqimC+/so+J8/CJ0UJEtVHNzKHWH1ex?=
 =?us-ascii?Q?ke6oM16/jCo9xzqpKPcF1zKCzagBZlb4+pb05SPvyBM0KU6GCRbEl25wR6h8?=
 =?us-ascii?Q?7BRz6NGauZZYZEHqm+649swE0h5di/xfxJBE2T2K6czLzqaCQJ8dxdzrqE3g?=
 =?us-ascii?Q?w3Zvu8IJQLd/Rsc3lZ6CjoQ/XQ5XaafBMD+Ig0+hiaCe/PJkWjljjbCyoLbx?=
 =?us-ascii?Q?gCrZq939DnAv4JjawVqQYRpo8eUfKsCrfWAHQXYGbCrbz3lLVU/CJmGJtfog?=
 =?us-ascii?Q?sUB75ModsjjH69WWx8TrJOsGEiBoRrPvGKk3r4xVID4nAqdKjUAxuJEcA+rl?=
 =?us-ascii?Q?uid//E48wW5a18AwBrAYHLlq/vIKkIWJmTwqTFmuRMX7wweSixwGqefmSY2m?=
 =?us-ascii?Q?RBQhEIP0COlEK1pluCqCgo7syjHw+QIHaUjZO4GgskrjDuJBtU7Yt/nQbnjk?=
 =?us-ascii?Q?oqDbyzxwxx8xXplVJEG3g0zZ866O1LuYKBimqcgKnqKX+kvkIxWr4XxtAJDe?=
 =?us-ascii?Q?Agh/h/7sEOpyi31tTkbpAM6nm0/YJ7JzsOBRWJOOHdFbumRYKSaiktU2Jruj?=
 =?us-ascii?Q?ABHWxxLzklzNenOhSbs0Q3+/uaurqzw/bhouQ8vmoh1LL9uRMwHg8xaoe0UR?=
 =?us-ascii?Q?g45OUKZWPDYSoMt5kSToJkCZKejvsFGRRZ3FraALi/ONFAruOTWsl7SrGjmO?=
 =?us-ascii?Q?s5D+OJfRN9ubiM73CCLXyIzycq2S5yaIEZCfy8qif9r1Y3QCizSDnKSgg8gJ?=
 =?us-ascii?Q?dA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 01ade797-f479-4abf-5d9b-08dbd737421f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2023 21:54:13.8785
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ugHOPJg/kXM9Wg1OOk3o7LBbYjyLweQ6rSVGMAWWniC6OLD5Do56hGgMb/3is9dl7bV7qDB73nujtU8Pm4c7aphq6HvauR9+ib/Q5ixIbTE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4653
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 27 Oct 2023 14:54:33 -0700 (PDT)

Robert Richter wrote:
> The Component Register base address @component_reg_phys is no longer
> used after the rework of the Component Register setup which now uses
> struct member @reg_map instead. Remove the base address.
> 
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
[..]
> diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> index 464fc39ed277..aa44d111fd28 100644
> --- a/tools/testing/cxl/test/mem.c
> +++ b/tools/testing/cxl/test/mem.c
> @@ -1423,7 +1423,6 @@ static int cxl_mock_mem_probe(struct platform_device *pdev)
>  	cxlds->serial = pdev->id;
>  	if (is_rcd(pdev)) {
>  		cxlds->rcd = true;
> -		cxlds->component_reg_phys = CXL_RESOURCE_NONE;
>  	}

I cleaned up those stray brackets after this second statement removed.