Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1466867rdh; Fri, 27 Oct 2023 15:41:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKaNfPSXXFgEtY4P5LyH72GmM5JQgtCpNNqoBq1mBVw8kyIvwo5gDY/QQXu6mJHdSL5JPP X-Received: by 2002:a05:6870:b24d:b0:1ea:19d5:1e50 with SMTP id b13-20020a056870b24d00b001ea19d51e50mr4722462oam.51.1698446507625; Fri, 27 Oct 2023 15:41:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698446507; cv=none; d=google.com; s=arc-20160816; b=w03iXhWlQLSCcRcEq4C0nozsXrcjQMSZ8Vi2Im2+PaGg7p+N0JpgAuapk9vwszgpJt KJ3++lKlkWo1WsQMKLfginQie5Cga4k91+T2T2KVjNwZydR1Wt0cYuQVDbfICV1dJKrG xEML3VUWjMM+XLltLVJaBEEC0BC2c41Eh3V6OsyS/SOfMotR55/ZancjvAklleXtRq0Y +pL0OOnnUK2yg7Dd6Fi/zttp9HplHvhBP1uTWMFdvTZNcB13g69Ilg8QlqhYptxiRpe+ sQpUeQAdqwKJqeMIGKS8xn/ZYLe+yMNJ76l5bZh1HlaApg3Wna2FZBWW8fZVlD/SwXlc 4FxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=C1cGmCKheXaosKM64c07mUiJ6qxuym0wDB0EyULOl+Y=; fh=iXxGHME1h47mEoZlyfjrd87BUwD0Y1q6Z3Kwix1qfMo=; b=pn3mHPEMwxjoqKtKN0s84awr4sexfJOJWvD9iT8Bu29bN07dinEBe2NXScErs0RaGS LBVPB/l+crfKvvjD3xQTvfaZ8AB4O3hSw5eim6C3N470tKDRUeT5Gx9mAmNHZkLEQMKX 6nfCfEgjrgZmGIiDkNLy5HcQfHeWvigWiKec7QmARLZWdBkyTpmphzS2gahvYqGBaXiB JEy58cfSxnwtX2nHvpPmaLCBEeR2Pwae6foXLTXaIQZE+OMg5plADFsQEZw5AWRyT6rx xDY6GznjqM9vkBnUhJeVnC5wTRB5YzMmn2vwIqw2/zguH0xpNuEQ4Bt5s/Sb9GlpIxm2 ck9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IzrjaEBE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id e133-20020a81698b000000b005a7b4815bf7si3951376ywc.37.2023.10.27.15.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 15:41:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IzrjaEBE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 5300680A18E7; Fri, 27 Oct 2023 15:40:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235062AbjJ0Wkp (ORCPT + 99 others); Fri, 27 Oct 2023 18:40:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbjJ0Wko (ORCPT ); Fri, 27 Oct 2023 18:40:44 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D9C2D4A; Fri, 27 Oct 2023 15:40:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08947C433C8; Fri, 27 Oct 2023 22:40:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698446441; bh=2rCIRtKFM+3RMPf0ZVAQKOeUDSTXWIOHQEyehpzPDsk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IzrjaEBEkG0Xr84XrZyxlM92yU5kvrfPjNlirqcNGfPwVB8TrAG9V8DgOvpXBR57R UDRhz4p0tOe9MTFTUoRPkTnzuOnNWCDJtWj2+6RKOz1LLf9Pt0DDDv/q839q+9rBnd eSTMvp7fDmb0SVCmVQwSfMU9w/PHq7sN0pt65bBHiK798Wf8ybEHMuUdwucNsxScV3 kjBX7BgZCqR6q88chkGsLqhFV73/SMLfy/i4HgufpkQISoCPJUPgKIBUVm7uqgkle4 zGMg7cpLZwmR1hNJNpMa8pGDVMdYanqAS/YLtfBoOlkU1LZhjLgoNx/ulLsaOekk5G XQv6mPx1pfWUg== Date: Fri, 27 Oct 2023 15:40:40 -0700 From: Jakub Kicinski To: Haiyang Zhang Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, decui@microsoft.com, stephen@networkplumber.org, kys@microsoft.com, paulros@microsoft.com, olaf@aepfle.de, vkuznets@redhat.com, davem@davemloft.net, wei.liu@kernel.org, edumazet@google.com, pabeni@redhat.com, leon@kernel.org, longli@microsoft.com, ssengar@linux.microsoft.com, linux-rdma@vger.kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, bpf@vger.kernel.org, ast@kernel.org, sharmaajay@microsoft.com, hawk@kernel.org, tglx@linutronix.de, shradhagupta@linux.microsoft.com, linux-kernel@vger.kernel.org, Konstantin Taranov Subject: Re: [PATCH net-next] Use xdp_set_features_flag instead of direct assignment Message-ID: <20231027154040.58e5b09d@kernel.org> In-Reply-To: <1698430011-21562-1-git-send-email-haiyangz@microsoft.com> References: <1698430011-21562-1-git-send-email-haiyangz@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 27 Oct 2023 15:40:59 -0700 (PDT) On Fri, 27 Oct 2023 11:06:51 -0700 Haiyang Zhang wrote: > From: Konstantin Taranov > > This patch uses a helper function for assignment of xdp_features. > This change simplifies backports. Generally making backports is not a strong enough reason to change upstream code, but using the helper seems like a good idea. I touched up the white space and title when applying, thanks! -- pw-bot: applied