Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Fri, 27 Oct 2023 17:32:17 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        "Alison Schofield" <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Terry Bowman" <terry.bowman@amd.com>
Subject: Re: [PATCH v12 01/20] cxl/port: Fix release of RCD endpoints
Message-ID: <653c5691a2372_780ef2949b@dwillia2-xfh.jf.intel.com.notmuch>
References: <20231018171713.1883517-1-rrichter@amd.com>
 <20231018171713.1883517-2-rrichter@amd.com>
 <653b3299c1a33_244c8f29449@dwillia2-xfh.jf.intel.com.notmuch>
 <ZTw_xd2_uaApAzoL@rric.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZTw_xd2_uaApAzoL@rric.localdomain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2XQrKOUHmfC23/3HUwt4MIPCYJBHKT/HRCcPCeXwXBr89nDP7ebrN/6/7QLS?=
 =?us-ascii?Q?K01ZwGl1pJbryu+pqeM+2ZbWMQbK9PSzt8z7i0WH51qMuzgeWorpljmxac41?=
 =?us-ascii?Q?qbh1tga5vvE0UNE8BNB/eZqyYHVT/WmcLiObwUSHRt9y5l/kSWGqfqi8IAML?=
 =?us-ascii?Q?3VdGn3M7kvmZ/rO7C+Q31ybm16+ZiUCvHNEJQ0S4A7huuTogCF/nssQEoYZ+?=
 =?us-ascii?Q?sRWgPVyCY5qShXs/Q5eoH0diRS48Vw/h4G2jLVSeu21aMXcBLBXJN1aw1DJo?=
 =?us-ascii?Q?SXKIZqlJUcUyRzcCSVvEL6qvBRWHEkhGOALXo2KLyldO7Hvnby5CLuB6TrMj?=
 =?us-ascii?Q?C7Y7rXB91gAuUA0gEnM2L+vAf3GlZEjdZUAquJDXaepaCNB0KAYwPL0Alykh?=
 =?us-ascii?Q?9JYLQZwbIgBG+zcagePBPOPFRH1EPDftAqcV7r1LdQKKRox7kdqLCy1kcnEi?=
 =?us-ascii?Q?GUN9dNtr8gQDULJd7jsmdc3yJkrpN4LVDO3CDe7txrx7STbHGSCrEc6qICG7?=
 =?us-ascii?Q?5QDrf0zv6LV4C4/EHR/iGBnWQjfoSryMe42XUu9ZbSaNJoc/FW4OhBq1Awqw?=
 =?us-ascii?Q?tEZexVsnX5ESqhelYis7mRuI1SYYlQ1dMz2Tb9m25xwjN5mCefHea8fa1ev6?=
 =?us-ascii?Q?kjWh3/LUzmmmK4RLBAUzd/RgJyDSiLqlfdqFI5WK92/yEP8JEUYhCE4FUzSE?=
 =?us-ascii?Q?vBZpiWvPB1M4PINlCX7IRs3Ku6UFwgJmdYt49uwNyw816jwRSfWR4KT/KxKQ?=
 =?us-ascii?Q?ERf2KnqUYmjF/PybKI4jOQYlabEhGYx9yai14WKzSSemWDSNQbZ8Nb/X1n/o?=
 =?us-ascii?Q?6CPRFkPX70zZRnVsPTD6anXcaF3wCzzp3ozQdlMh3pHTJ5KOB5YgMsd+64gO?=
 =?us-ascii?Q?rZudjo4w5vfhaqWbPrq8eFnQM8bb7K8Ggmhfhmvk+V2FrOjcOGDQdk1Jwp6R?=
 =?us-ascii?Q?0UhlSmpniNAy8OhhDulXKIKpRIa5HbRyMCORJuRg7vASpiyJfLnfDaWBooqR?=
 =?us-ascii?Q?APoTLEh5dYCPmCXrC9o7JxlRkkuO0RhYLSk9ZTJCQT60a5qymaTU1YIDnGh2?=
 =?us-ascii?Q?zlWbm7/1Q/cPJtmgktKM22qvhttP3JA6DiHjHqDC5W60LPy74X4mv1h2dbMY?=
 =?us-ascii?Q?3Pjdsimn3WuOyoPIrRn3nJX1OkXw0q+A9VfyLa2kEP4Kixllnbb0qH9Axoq8?=
 =?us-ascii?Q?nmInNp5MOll06g/PGbn6ZuskcjO0MgYoo8vcZvndohJLgJrU3t7/x0Irssf3?=
 =?us-ascii?Q?Qqp3br7Cd4twmQDabjFg5a24a8JfAGvygDV0EB4wxcaiFql/fVSq3Rtasz1C?=
 =?us-ascii?Q?VJR7cOiKw11ipet0/bllpT23C5eAuM0DDVU3qdGOSNpmMpNII69gKDHxfWEJ?=
 =?us-ascii?Q?XuOvTflYgjA9VfywSUMnkK8RVNOBlf/S9OcOCthfn2Zva9chREwpq/Edumi5?=
 =?us-ascii?Q?/KoC6UxRuWXf+zMF+1hrJL+8fpv+W3osrDcqW/gW+1kPr62SpKW4H4tzwmlo?=
 =?us-ascii?Q?m6//tskzfCItQIR2Qov29obJMsdm0nt62w68Gxafhisx+W24UV8Ahn8K3A3l?=
 =?us-ascii?Q?nO7yUZjkGr9FpxnP/tepEIaI0rJv18qyya0EgFTIdHbUKcL74MGz2+rIr0yg?=
 =?us-ascii?Q?DA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 047db141-d9a3-4527-6380-08dbd74d58ad
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2023 00:32:20.7319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8WXyYpuYUeUfC/8165uWTyrCfxyH9VxqY+tPiTeUZXoaPDx/kC1XvjU2YFe27j85+HHO9TYsPj91wtVuHkyFuCxbzOPho0ag7JyzmcLvQ6k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8591
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 27 Oct 2023 17:32:55 -0700 (PDT)

Robert Richter wrote:
> Dan,
[..]
> 
> delete_endpoint() is called here, but the uport etc. is not unbound.
> Which means this is not true:
> 
> 	if (parent->driver && !endpoint->dead) {
> 		...
> 
> I don't remember this with my patch. The parent is there different, so
> that could be the reason.
> 
> I could not yet look into more detail but wanted to let you know. Will
> continue.

Apologies, I didn't have that regression going, I think I see the issue.
Thanks for the heads up.