Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1567836rdh; Fri, 27 Oct 2023 21:02:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYY7QZUH6KvRPzZMTSXrOCdsGOZiVCKZ+9JpSyMk9osIdpNJdCzJxHQ2+T3ldNm92UfE7k X-Received: by 2002:a05:6a20:4425:b0:179:f79e:8615 with SMTP id ce37-20020a056a20442500b00179f79e8615mr6508837pzb.52.1698465730889; Fri, 27 Oct 2023 21:02:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698465730; cv=none; d=google.com; s=arc-20160816; b=tQkN7o4LO8KQtqnEL7ytfFfh/qmFboI59jNLozqS8eFKKzJuueKQhmV/m+AYtgDFJp zE637Au6Jwn0WaIZ1n56/zhYpmNZTcCqdzl++pUaz2JD/7iFN4iEY2iRK5QaMaqmJkMz C32Kv58Ny+xZG1Edoj3lVfMr/ajpglAs4T5oiM/Js0j/dqdZ85OKlMIpoKlNFLDtsqtl i+8F7PxYIIW275BZHLVVFX02Fll7zhz30Yxi0POz6SLjVUR9jRi3aCagPmpOi3xTNesU 2aSI5l7kCai+LY2RsjuT15EOjqKwliUrHi6xiaHQMoq+GHC6Y/rJ7wROIF5PvqqewBE2 UYzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:mime-version:date:dkim-signature :message-id; bh=UlpoQS6xjBBJSN7AYIHJNknf8fUOyG0wQHib+hsFjCI=; fh=OR1+SAx8XWfD/WnjA/gU3P37vjVljlXkUjJwUqiDiDk=; b=a37yoyF9mwPFYnAexWeDCKzUZVLZ2l+4cw5G45X9lBJhtyiMjU4FB6OYMDU02CIBfZ RsgtS2/yOPqW0//crT9DW3iCnXoH2WxzthjPocY2tY5Lk9FF8NgXQY3tB6eg94VZ/t4f nZ0BZBg+V8wbi4Se4bTZsjglvkmIsmbT2Tl5+0df+2iP1BtmT48Uvz+QX81iGoTRFcSH ILKfSy1IjiCy1UmsB8/epeNcdtMLZlrQORaRHY70Kx0iTvG2dKUXoMuDw8T70oyvkLHH 58Fdg8i0yCOiScz56QKNGnjgQsoKgvcv+6cUAFwgoifWwVzTyCXwqwPJbARywZtBV8Z5 W+uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=ZoL76mWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id u16-20020a056a00125000b006bd9ff6dab2si1930045pfi.377.2023.10.27.21.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 21:02:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=ZoL76mWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 6D732807CECE; Fri, 27 Oct 2023 21:00:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229496AbjJ1EAi (ORCPT + 99 others); Sat, 28 Oct 2023 00:00:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjJ1EAh (ORCPT ); Sat, 28 Oct 2023 00:00:37 -0400 X-Greylist: delayed 459 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 27 Oct 2023 21:00:33 PDT Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52D9710A for ; Fri, 27 Oct 2023 21:00:33 -0700 (PDT) Message-ID: <5bbc6456-160d-4566-87ca-13984d795c6a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698465172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UlpoQS6xjBBJSN7AYIHJNknf8fUOyG0wQHib+hsFjCI=; b=ZoL76mWlw4HhbNiKEnFYfeDNB4r6i01HxBLgxXkqiyG3R2+s3u+ysVkUFc+FDKPcN4kzd/ hf4qrh9Fvtzwwgu5AMVXTtmz0kmXS7CvMAd04eV+L4JE9j0SwfN6BFVJ+MpjU3BjYkJWjT 9dlZgcIMBEO72atR0oaMaeG/4djrGrI= Date: Sat, 28 Oct 2023 11:52:40 +0800 MIME-Version: 1.0 Subject: Re: [PATCH RFC 2/2] RDMA/rxe: set RXE_PAGE_SIZE_CAP to PAGE_SIZE To: Li Zhijian , zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, linux-rdma@vger.kernel.org Cc: linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com, matsuda-daisuke@fujitsu.com, bvanassche@acm.org References: <20231027054154.2935054-1-lizhijian@fujitsu.com> <20231027054154.2935054-2-lizhijian@fujitsu.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <20231027054154.2935054-2-lizhijian@fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 27 Oct 2023 21:00:51 -0700 (PDT) 在 2023/10/27 13:41, Li Zhijian 写道: > RXE_PAGE_SIZE_CAP means the MR page size supported by RXE. However > in current RXE implementation, only PAGE_SIZE MR works well. > So change it to PAGE_SIZE only. > > ULPs such as SRP calculating the page size according to this attribute get > worked again with this change. > > Signed-off-by: Li Zhijian Acked-by: Zhu Yanjun Thanks a lot. Zhu Yanjun > --- > drivers/infiniband/sw/rxe/rxe_param.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_param.h b/drivers/infiniband/sw/rxe/rxe_param.h > index d2f57ead78ad..b1cf1e1c0ce1 100644 > --- a/drivers/infiniband/sw/rxe/rxe_param.h > +++ b/drivers/infiniband/sw/rxe/rxe_param.h > @@ -38,7 +38,7 @@ static inline enum ib_mtu eth_mtu_int_to_enum(int mtu) > /* default/initial rxe device parameter settings */ > enum rxe_device_param { > RXE_MAX_MR_SIZE = -1ull, > - RXE_PAGE_SIZE_CAP = 0xfffff000, > + RXE_PAGE_SIZE_CAP = PAGE_SIZE, > RXE_MAX_QP_WR = DEFAULT_MAX_VALUE, > RXE_DEVICE_CAP_FLAGS = IB_DEVICE_BAD_PKEY_CNTR > | IB_DEVICE_BAD_QKEY_CNTR