Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Sat, 28 Oct 2023 13:44:00 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Keisuke Nishimura <keisuke.nishimura@inria.fr>
CC:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        <linux-kernel@vger.kernel.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Mel Gorman <mgorman@suse.de>,
        Valentin Schneider <vschneid@redhat.com>,
        Julia Lawall <julia.lawall@inria.fr>,
        Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
        Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH] sched/fair: Fix the decision for load balance
Message-ID: <ZTyfoIBpm3lxd8Dy@chenyu5-mobl2.ccr.corp.intel.com>
References: <20231027171742.1426070-1-keisuke.nishimura@inria.fr>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231027171742.1426070-1-keisuke.nishimura@inria.fr>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QphEze354RTm5ZugO/DOnH7PpkpVbl+FjP7+c7DJ+SBAed4cIrlFRvpw4YML?=
 =?us-ascii?Q?IXgd2VVhh7ZM8VSLXpefB/YzF31OBm9ft+4aQyqt1WQiWVUgenI5IQuaotvk?=
 =?us-ascii?Q?iUz5Fuqr5ooWdBthUi0IqNdDol50hApzEOjFMoWfKr6gOYdEwNLDhFE0YtFs?=
 =?us-ascii?Q?H9Eq9zibYbvZ1qC8btaxHhs4eDj4sJKAxmfOtILVGTLq3F3vF09PMZ4OyfFI?=
 =?us-ascii?Q?GifxyEvzfDME43qRH6L86apiTnVt22y9iMwqV/YelLeeaj+usNfiw3sfiTMx?=
 =?us-ascii?Q?cG24f6ESn12cXCXJm3y0CW7R+Q8ax7gLCrO9SHvH95FolL0rWT2+kH+45i3F?=
 =?us-ascii?Q?RU/o9ZZaXIHmgZGIlTB7N9+QDDpyS0Hu8sqAUum58eIFdEozZKdIfSmt7ZJz?=
 =?us-ascii?Q?6nSa9rzuEU2lIwy8k2ErfY04KktwNWk94eo9wxH0Ey2Jr0N/h6gRvI7b0iTx?=
 =?us-ascii?Q?D/v+77abFcnASJXAlfAKo87kUk1aA1JWBnEpvoHdSvr/rTcSGOt5ygpBVzFW?=
 =?us-ascii?Q?1yg5ctj4pndtapr8zw37/U0cRL0iwYM22cCIpm/Ti/MnW/dvrWiubaxBQ6fF?=
 =?us-ascii?Q?iK/8zVnWxpWgiGMrEwK8VwH0tQrG1HX/hg5zZ/m/ucCeMmvFWxBxwV5exSKv?=
 =?us-ascii?Q?d8CbHgwqAUwMrN2G80hELWAdy6PrxJpoQkmwnHA53GzjM6wpcTbEMhKFpiPh?=
 =?us-ascii?Q?0kUktvzcNT/AfwCIUOsIS3cY2xyyBFQ0JQiSAYVk01HNgjqRkhSa3FG0+YaW?=
 =?us-ascii?Q?Kco2uNqDqieVDMtiKJ8gj5PbDFXeI4wgkojdC69vH/LsSuZC04ozW18D39/H?=
 =?us-ascii?Q?yJaUTbChgCNO6ShauVjOq2AI/B42i92ZuiD1+k/pdZ2aUk2A4D4vbYyq9Z8Q?=
 =?us-ascii?Q?FMHipPkhF2DT+LAerG7ARGNt9Y2HhuCM5d6Pxdn+zHgac2bvQ86kyn9vtg1/?=
 =?us-ascii?Q?ZVb5DqBWNHjBJ6dz0UmlOyvbpnc9GJfwL9oLcfG9eucX7oAbtK+FbHS6g3gx?=
 =?us-ascii?Q?w9WkHrGKDDHMcuAwbHFm0/dXFlsP/G3SEzdWLIQVJGdvMwmlRBT2VKPIQNOX?=
 =?us-ascii?Q?UsAmaZWlRdxGi/v4//Rn2167xkot/U/VtRizcl4h9dwtzpze1v4GPXEy103y?=
 =?us-ascii?Q?o+zISVVBtaF/OJiTBA8Es1fw1QkS76AC5ZLiJCekdfyWdGAxypBkKe4gdvW/?=
 =?us-ascii?Q?oYZj0Wr6E1uagrNpKFGzn8+pygpzoXSdjsOA1bBnP+M/00i0zoN3e2vRfE0s?=
 =?us-ascii?Q?K6axHj9B/Ang+Wxduo01iSqRe0rYn+YiJ7TpJpgcQu0kZszR9up577fOaDfe?=
 =?us-ascii?Q?SYLiWGs/bUZJoKUEEU51P90930fxMGPV2xULS8mJmxWD3thjAF/64W48RGF0?=
 =?us-ascii?Q?arjwlMXe0t7abuhHBs9S9fsYr3ewA5LfrjK0kYNiLRdJAxjylZpojsWG0o7x?=
 =?us-ascii?Q?ehGc6qS1UDcd7YR8uPpuwgi7BMV8hQV7lK8+NTN0lGKLNdK7Zg0eJpSdaj0r?=
 =?us-ascii?Q?msKv62laNUEBtXNjzg/1QrMfyJfByPEr7ATO6Q2NXZObxKMFuGgWfKmftg90?=
 =?us-ascii?Q?E6vS77egkqofY4ouE/pLDeRMgUuiJTTqjYlXTZ0O?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a5cc292-08a6-4252-78b1-08dbd778ea76
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2023 05:44:14.2922
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HoGuhjMTXQFRF1PNCgAiGo3tt20GoOx9vFWYfoYVPR98CIJVta9N+bOzrECwS10nSA4BHqKKl9uYLmKYJ+4+Ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4936
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 27 Oct 2023 22:52:14 -0700 (PDT)

On 2023-10-27 at 19:17:43 +0200, Keisuke Nishimura wrote:
> should_we_balance is called for the decision to do load-balancing.
> When sched ticks invoke this function, only one CPU should return
> true. However, in the current code, two CPUs can return true. The
> following situation, where b means busy and i means idle, is an
> example because CPU 0 and CPU 2 return true.
> 
>         [0, 1] [2, 3]
>          b  b   i  b
> 
> This fix checks if there exists an idle CPU with busy sibling(s)
> after looking for a CPU on an idle core. If some idle CPUs with busy
> siblings are found, just the first one should do load-balancing.
> 
> Fixes: b1bfeab9b002 ("sched/fair: Consider the idle state of the whole core for load balance")
> Signed-off-by: Keisuke Nishimura <keisuke.nishimura@inria.fr>
> ---
>  kernel/sched/fair.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 2048138ce54b..eff0316d6c7d 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -11083,8 +11083,9 @@ static int should_we_balance(struct lb_env *env)
>  		return cpu == env->dst_cpu;
>  	}
>  
> -	if (idle_smt == env->dst_cpu)
> -		return true;
> +	/* Is there an idle CPU with busy siblings? */
> +	if (idle_smt != -1)
> +		return idle_smt == env->dst_cpu;
>  
>  	/* Are we the first CPU of this group ? */
>  	return group_balance_cpu(sg) == env->dst_cpu;

Looks reasonable to me, if there is other idle SMT(from half-busy core)
in the system, we should leverage that SMT to do the periodic lb.
Per my understanding,

Reviewed-by: Chen Yu <yu.c.chen@intel.com>

thanks,
Chenyu