Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <2a5ccee0ce33b2918e8b32b25ff1cd7221d01892.camel@gmail.com>
Subject: Re: [PATCH v2 4/5] iio: pressure: bmp280: Allow multiple chips id
 per family of devices
From:   Angel Iglesias <ang.iglesiasg@gmail.com>
To:     Jonathan Cameron <jic23@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-iio@vger.kernel.org, Biju Das <biju.das.jz@bp.renesas.com>,
        linux-kernel@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
        Phil Elwell <phil@raspberrypi.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>
Date:   Sat, 28 Oct 2023 13:23:46 +0200
In-Reply-To: <20231027144625.36cc694c@jic23-huawei>
References: <cover.1697994521.git.ang.iglesiasg@gmail.com>
         <eade22d11e9de4405ea19fdaa5a8249143ae94df.1697994521.git.ang.iglesiasg@gmail.com>
         <ZTZYNjq/1X95ijXh@smile.fi.intel.com>
         <20231027144234.0ad6c7b6@jic23-huawei>
         <20231027144625.36cc694c@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.1 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-10-27 at 14:46 +0100, Jonathan Cameron wrote:
> On Fri, 27 Oct 2023 14:42:34 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>=20
> > On Mon, 23 Oct 2023 14:25:42 +0300
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >=20
> > > On Sun, Oct 22, 2023 at 07:22:20PM +0200, Angel Iglesias wrote:=C2=A0=
=20
> > > > Improve device detection in certain chip families known to have var=
ious
> > > > chip ids.
> > > > When no known ids match, gives a warning but follows along what dev=
ice
> > > > said on the firmware and tries to configure it.=C2=A0=C2=A0=C2=A0=
=20
> > >=20
> > > I would rephrase it a bit:
> > >=20
> > > "Improve device detection in certain chip families known to have
> > > various chip IDs. When no ID matches, give a warning but follow
> > > along what device said on the firmware side and try to configure
> > > it."
> > >=20
> > > ...
> > > =C2=A0=20
> > > > +	for (i =3D 0; i < data->chip_info->num_chip_id; i++) {
> > > > +		if (chip_id =3D=3D data->chip_info->chip_id[i]) {
> > > > +			dev_info(dev, "0x%x is a known chip id for
> > > > %s\n", chip_id, name);
> > > > +			break;
> > > > +		}=C2=A0=C2=A0=C2=A0=20
> > > =C2=A0=20
> > > > +		dev_warn(dev, "chip id 0x%x does not match known id
> > > > 0x%x\n",
> > > > +			 chip_id, data->chip_info->chip_id[i]);=C2=A0=C2=A0=C2=A0=20
> > >=20
> > > If the matching ID is not the first one, user will have an unneeded
> > > warning here.=C2=A0=20
> >=20
> > Could be a dev_dbg() but I'd just drop it entirely.
> >=20
> Given that was all that came up, I've hopefully saved us all time by
> dropping the bring and changing the patch description as Andy suggested.
>=20
> With that done, applied.
>=20
> Jonathan
>=20

Sorry for the extra work Jonathan. Next time I'll be quicker checking the i=
nbox.

Thanks for your time guys.

Angel

> >=20
> > > =C2=A0=20
> > > > =C2=A0	}=C2=A0=C2=A0=C2=A0=20
> > > =C2=A0=20
> >=20
>=20