Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp1898455rdh; Sat, 28 Oct 2023 11:36:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpcPav+4zIFfAtBXM8iDPVDZ1oZT2iv1P/IWJe1Qc0Tq9pTWpoStmYjjXSyizkbQwQdRkk X-Received: by 2002:a17:902:6803:b0:1ca:57ff:9bfa with SMTP id h3-20020a170902680300b001ca57ff9bfamr5497530plk.24.1698518206463; Sat, 28 Oct 2023 11:36:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698518206; cv=none; d=google.com; s=arc-20160816; b=KUCmaJK0gD+DfYtit1lK2tNpX7Tps07nuM7lL1fgD+rmapD/Nvt0NALbUcxo+9IaxP Brc8SfLvTDsPsdhZIoEUVNqXEWMcs6nSsmOde3TPnzNwPyptbPvgPRtQHX5EXFJNC9vP eYnm2ZNCeCOnaLpp/skMDBr/f/d3EObHYc3i2fKy+6s6wGq7vzGNOz26SSvgjpukX4+X 07XTj5FdDmehqgIWbbsPFy++/jVYpk5FI/1U1OK0VCC+tPIqt9XDPDmqlVRYpML+JyNK H+WwViIoxTrpxjj5CKRfDZa38D3ElfZwZmx5ADLSnWXjQjMxdOz7DZljJfSOuKyyl+hz Y+vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=y+JcIxwCXoDSqf+artDzmxw4NchEsdASLJbThyKqdKo=; fh=iUJZCnwe3Iw9c1mHQOEn2oAPdOBS61RdKFqmSdn5Riw=; b=YgjjHassNUsiL63ibekvrNrwoCcDCOZUwJZvPeVEITqmXkwuOglTWOWOr1W+iwrw6f VV484LF5O7GuzM9ApIuOc14HqEOGtegJY3UBbkzCPIanLmYT6iTSF//EhxfEucCKBVl4 b1sk1OEIrk921m4fi9TbfPpzIkTnUjE6f+Ft3B5iA5DYOP6JYA7fIMEobyAE0WoJnMBF wED1hVXsOW5Ch42KhchRkNSCn/GxofoAKAAKY1PcmfcNy8TcG9DPWVACE2vaMAoJOqTP jQ1hyM7XqTX5eII7rh84Gkem6+BmbhVLWeEZNi1Qgur87X4a4nmptOS6Xd15lbBvsq60 EWAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=XPD1tQNe; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id i4-20020a17090332c400b001c9db56c09asi2836049plr.144.2023.10.28.11.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Oct 2023 11:36:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=XPD1tQNe; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 069E48046465; Sat, 28 Oct 2023 11:36:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229476AbjJ1Sg1 (ORCPT + 99 others); Sat, 28 Oct 2023 14:36:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjJ1Sg0 (ORCPT ); Sat, 28 Oct 2023 14:36:26 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54D68ED; Sat, 28 Oct 2023 11:36:24 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1698518182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y+JcIxwCXoDSqf+artDzmxw4NchEsdASLJbThyKqdKo=; b=XPD1tQNetxvEMQ5Fs4mzhtA/G5HWxqiD9ADxCIt7lYfraNqzOMel6WUxppBbqdi0bgI8aZ 3rPQzNZs9PUl2jp/jDJY2L4QntS1kpl91bgcoQ8MwxMNYCKU40QO7P9NsDtqVkoHPAClvL l9Ypj6JGrlL6oh82hFpbPRFKtkzuzehhR65XTPO0nAGcN9vge7E/sYR1ZlCZlBdTUGXvum fYXhCUPu6U1EscBv3oubTAhyVMdv3h8CHa+y5E4EtnPUo0zDFZy+A0MI5NJV9UW1cJ1lan V7JKOjHUv+9AL7BsjcQiBzM9/OdO3TClZ5ZNgh66xWjZ4stz3rc6q78CJ+tyyQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1698518182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y+JcIxwCXoDSqf+artDzmxw4NchEsdASLJbThyKqdKo=; b=M3mwqGYRAOI6KGdDqVCILcqh8Ql5h8OW+P1CEwmVfh4n9f9Nn8Lo5wD7FszZtGyZKCGF0j WXB1fuwq/1Jxa9Bw== To: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Anup Patel Cc: Palmer Dabbelt , Paul Walmsley , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley , Marc Zyngier , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v11 09/14] irqchip/riscv-imsic: Add support for PCI MSI irqdomain In-Reply-To: <87jzrbf5cw.fsf@all.your.base.are.belong.to.us> References: <20231023172800.315343-1-apatel@ventanamicro.com> <20231023172800.315343-10-apatel@ventanamicro.com> <8734y0rwtw.fsf@all.your.base.are.belong.to.us> <87jzrbf5cw.fsf@all.your.base.are.belong.to.us> Date: Sat, 28 Oct 2023 20:36:22 +0200 Message-ID: <87y1fmzja1.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 28 Oct 2023 11:36:44 -0700 (PDT) On Wed, Oct 25 2023 at 10:55, Bj=C3=B6rn T=C3=B6pel wrote: >> Now for IMSIC-PCI domain, the PCI framework expects the >> pci_msi_mask/unmask_irq() functions to be called but if >> we directly point pci_msi_mask/unmask_irq() in the IMSIC-PCI >> irqchip then IMSIC-BASE (parent domain) irq_mask/umask >> won't be called hence the IRQ won't be masked/unmask. >> Due to this, we call both pci_msi_mask/unmask_irq() and >> irq_chip_mask/unmask_parent() for IMSIC-PCI domain. > > Ok. I wont dig more into it for now! If the interrupt is disabled at > PCI, it seems a bit overkill to *also* mask it at the IMSIC level... Only _if_ the device provides MSI masking, but that extra mask/unmask is not the end of the world. Thanks, tglx