Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Sat, 28 Oct 2023 21:36:05 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Andi Shyti <andi.shyti@kernel.org>
Cc:     Samuel Holland <samuel.holland@sifive.com>,
        Peter Korsgaard <peter@korsgaard.com>,
        Andrew Lunn <andrew@lunn.ch>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: ocores: Move system PM hooks to the NOIRQ phase
Message-ID: <ZT1ipfs3XzrKChmi@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Andi Shyti <andi.shyti@kernel.org>,
        Samuel Holland <samuel.holland@sifive.com>,
        Peter Korsgaard <peter@korsgaard.com>, Andrew Lunn <andrew@lunn.ch>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230717203857.2626773-1-samuel.holland@sifive.com>
 <20231024202030.o3pyswa4css5lnwr@zenone.zhora.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="GSjqUPDK1r46QXAL"
Content-Disposition: inline
In-Reply-To: <20231024202030.o3pyswa4css5lnwr@zenone.zhora.eu>
Precedence: bulk


--GSjqUPDK1r46QXAL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > When an I2C device contains a wake IRQ subordinate to a regmap-irq chip,
> > the regmap-irq code must be able to perform I2C transactions during
> > suspend_device_irqs() and resume_device_irqs(). Therefore, the bus must
> > be suspended/resumed during the NOIRQ phase.
> >=20
> > Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
>=20
> I think this patch has failed to receive some comments, I'll go
> ahead and give it my blessing:
>=20
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

It needs to be rebased on top of 0ad93449b043 ("i2c: ocores: Remove
#ifdef guards for PM related functions"), though. This series did clean
this up for the whole subsystem. It also introduced using pm_sleep_ptr
which probably was missing here?


--GSjqUPDK1r46QXAL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmU9Yp0ACgkQFA3kzBSg
KbZHuxAAkAxotUygWyZRw5UqlHp3CMUnpxJMGt+ceCx22eOs8cp7P7oMB8crKacP
Ut0dgZiWzfb57/IPuRJ8NkzoP6OYsg9cfc1mnYu4YdEtdMTBVlavk4LAcS99ft+M
xo8hN9vNvK9sCOBijX6yR2z8bSJgXsmK8Y7QFHijhtlZLk0GnnIeJwDHF9Ihz0YS
5O900EiIefsRvYw3WghKIRkFcFeOkwnQRtg3RnYSosXtcuJ+8N4uKI4zS7ga4uLE
Wvif/SaciSsCVNO/r4NZ/K41bBuOCceEldxAv26/gjlzMvHL68G83tWlcN7Qf0MI
o1RXbcEKmOvR2mSksK4cvwjw0KZ3tSWX3mSDX5aOUBhRnd+7P+qHfg/NSzzuUBxR
rG9TElEQtNs5lO+xkCcAW2QTcRw2j/21ktfm97zdArDjt9qxN2Q5azFjPe3ExpEs
dK9MaOd+BxGgPCgCuMLUkcVm+GhzBmOIZKSJACeTos5fzwNPizPBb7iolxX6fvHx
8R7ZrlMiC0qx6S5arbY7Vov4HpQKUyU14FT9+eqGjTyWAcff4YzbPUzUjfy2N1D+
GKrgbauw4RmCwToVHs0Yfbf58hrqpzluohSIbDWT4YqRFGTxjfmUOH3DmwOuMf7x
wcJxDwHiXMdhfXhDZRvS4VIoFaGJQ8dqKcZegGJfd6QItt48FnU=
=91ge
-----END PGP SIGNATURE-----

--GSjqUPDK1r46QXAL--