Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2103800rdh; Sun, 29 Oct 2023 00:29:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhYjeC4OCk/487wlJwq15gw62lMgLefmIJ6y0KdWCT5sBo06eO6D8gRMC0wDnmi4YdjDjD X-Received: by 2002:a17:902:cec2:b0:1ca:9507:52 with SMTP id d2-20020a170902cec200b001ca95070052mr8141476plg.67.1698564597787; Sun, 29 Oct 2023 00:29:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698564597; cv=none; d=google.com; s=arc-20160816; b=vbFVRVKxMrJIS3qEHbPI6lrINQTXBf4h20wcF37tAl0dYkU6PO1RL+jbclrMjeSaZr rIoA+SBXiyC/wY4jPTNkyXHK6pYxhcKY4lZobMjFEeDixT+1z+F8Nm7JMlsJ9h7GWoJG p/ur4uODtunTfPyb4rFa0GpYzXSLS2+PEHtuvUSiuP9if3VL5VSpP19hr2dZwQ93PKXH cp+pSbtbuWLbHZNoTPbGQgLa9de5J2JXsUl8vHY7ADRv8gHCy8wXhbhbHjz4jwkc2dUK Ky5fs0m+K1aUj2BuNmjj7cGdGsdQJ9B9IpOVXjNhRAICYaJfWKM9boqxsXgF+9nWz3DF Bmkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=YKlPQOZMqX1kXG1v1K9DZaGEbhFjfcwnCk7POMQ9PC8=; fh=/WBLrhOyaI1j2wRR4yKB/tP86sf+Lw1YGlZowymkTUY=; b=yXRAtjfLUQq0XyLA6a2XPZOfgfDGljnP2rkMmWwebREqL6FC0+rkPu/gi61Hnoa5Gx t5lKVZD19hv0vK83uC9eMpuLU72YmcjDAeHs4FtsYFIceP87ujadPAzyXlDOrNeZtIX2 kVHfrhDzSBrEblEM89cVQ20pFYWiRUngE1Si11ddDiFehk6oGiygl7F4bYXq30MlUFmQ q2v3fBM/oEtPi+wjd5Ec29ggqB0yAP+6qfxEWS23RF2evkh8hzESxGef7JVgXfPvbx2X M0FQo5Co2g/9sBsP0ule110/EapRviFL5QwanpufOJWptRwWxterhzNoSn9aV6wJLmCX o56w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=CV0QAuEf; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=QIuZCeD1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id y12-20020a1709029b8c00b001bb9533b968si3427246plp.408.2023.10.29.00.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 00:29:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=CV0QAuEf; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=QIuZCeD1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 83D2380597B1; Sun, 29 Oct 2023 00:29:55 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229805AbjJ2H3t (ORCPT + 99 others); Sun, 29 Oct 2023 03:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjJ2H3s (ORCPT ); Sun, 29 Oct 2023 03:29:48 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3113C9; Sun, 29 Oct 2023 00:29:45 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A48AE21DF6; Sun, 29 Oct 2023 07:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698564583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YKlPQOZMqX1kXG1v1K9DZaGEbhFjfcwnCk7POMQ9PC8=; b=CV0QAuEf1j2xiugfpMnI4aDWwJzBj8FY0Og0pG3ijpJecIOU5LyRwoXcQK4qN8SsF30uUu kbdV12kSHBne8RUn3SbMCgHvBQlanU5ENfBQ6ouumFrYxegPB1E5kLRVf6/2bJRoM5avfG YNKfID3VgT4RmY5yuUdt5w35U+bf3Bo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698564583; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YKlPQOZMqX1kXG1v1K9DZaGEbhFjfcwnCk7POMQ9PC8=; b=QIuZCeD1McEssTywnSEnnr6ZFiWsBwM8T/ZXjJ/x9tIV+o1m6SGqCMuFXM08OMSHOhsPG6 bFbb0XjOSsv1VIAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4D9161391D; Sun, 29 Oct 2023 07:29:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BnA1EecJPmVdYgAAMHmgww (envelope-from ); Sun, 29 Oct 2023 07:29:43 +0000 Date: Sun, 29 Oct 2023 08:29:42 +0100 Message-ID: <87il6px4wp.wl-tiwai@suse.de> From: Takashi Iwai To: Arnd Bergmann Cc: James Schulman , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , Stefan Binding , Arnd Bergmann , Mark Brown , Cristian Ciocaltea , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda: cs35l41: mark cs35l41_verify_id() static In-Reply-To: <20231027152515.482411-1-arnd@kernel.org> References: <20231027152515.482411-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -6.10 X-Spamd-Result: default: False [-6.10 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWELVE(0.00)[14]; MID_CONTAINS_FROM(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-3.00)[99.99%] X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 29 Oct 2023 00:29:55 -0700 (PDT) On Fri, 27 Oct 2023 17:25:09 +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > The newly introduced function is global but only called in this one > file and has no extern prototype, so it should probably be static: > > sound/pci/hda/cs35l41_hda.c:733:5: error: no previous prototype for 'cs35l41_verify_id' [-Werror=missing-prototypes] > 733 | int cs35l41_verify_id(struct cs35l41_hda *cs35l41, unsigned int *regid, unsigned int *reg_revid) > > Fixes: 881b7bce0c25 ("ALSA: hda: cs35l41: Run boot process during resume callbacks") > Signed-off-by: Arnd Bergmann Thanks, applied now. Takashi