Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2143949rdh; Sun, 29 Oct 2023 02:47:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE+EOIiFXWOgVpcbDJ4gY5fQ+4YH92ATgvaek8MEMZBIKRVWsG0UOSgSWu0IxjWhgkmr8zt X-Received: by 2002:a05:6871:d107:b0:1ef:b8bf:a5bd with SMTP id pi7-20020a056871d10700b001efb8bfa5bdmr2650497oac.50.1698572872172; Sun, 29 Oct 2023 02:47:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698572872; cv=none; d=google.com; s=arc-20160816; b=W60DWKsiKMAhwbNOF6LwJgLmbXWSEP9XjfFuOP/gtx/w6+m5FB/thKTUMVrNpI93Ya x/BmoAmmyiX5rs3gwZCa869HPcP0A8p6qyNGC7yJqOe03w+qo8Vnd51eQthHl5TWb7Wu otRvAADerAHih+S+USQLMu2p5pz90kIpAt7ceK9UmAoYI29njZWL6Q4Z+PdTmH/mG2PA ga9XinTZmpRG/+Iv8Lj4rXdgDW6agkSnGTLuZUKWbAGDSW2aGWrCJbmF7rVaGgNNHLKo zi3PTmiEADzZa4gRYT7+LdwdnK/SclJQ7QdWs1mxvvWf213yyXqzMTStAOoi3RVJaXLg a6nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=uUyT86WfHwO6Bzws2hvqzEWPaZnjxnnpw+4gzvkRHyc=; fh=vbBbKuHmRMa6w3q+ucdGgHnzQxHkSfL9/L+Dmcny48M=; b=jcSDeaaXWpWmHA9MsejhP6dvbj/kcU8Nq6rfGRQLjkau4CTpvkNL2lldTWcHfJXApV UBYKKd1qM/PTed312ezAKcLxvh34W3eFv3yMz95S4dZY9nAkc5ccK8QDhDEeirEHhetb XhvcmCSMy4gQs6nhXUB9gzrAdVFaqxrxZaxbyg9KSPMJgp9k0ZEcuVutpfDylgFe6Sxn 8Z1FVGiIWMvQdeTe2guhwvKo+7gLgb9YFfw7NofY9ZOaum36pcE79eUg4g2e9G3ejNtR gBHC+QL1tIWmidpeJHRM0AEFz3/uYKZAW92LQpBLQJZnCskWAFhR6VoV/Xtz/Arel4dt lLkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id bw8-20020a056a02048800b00578b63123desi933253pgb.789.2023.10.29.02.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 02:47:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C9ED7807CEDD; Sun, 29 Oct 2023 02:47:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229482AbjJ2Jrn (ORCPT + 99 others); Sun, 29 Oct 2023 05:47:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229805AbjJ2Jrm (ORCPT ); Sun, 29 Oct 2023 05:47:42 -0400 Received: from 19.mo582.mail-out.ovh.net (19.mo582.mail-out.ovh.net [188.165.56.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D50CD3 for ; Sun, 29 Oct 2023 02:47:39 -0700 (PDT) Received: from director6.ghost.mail-out.ovh.net (unknown [10.109.143.216]) by mo582.mail-out.ovh.net (Postfix) with ESMTP id 9ED2F25613 for ; Sun, 29 Oct 2023 09:38:31 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-x2g4z (unknown [10.111.208.154]) by director6.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 9167A1FD2F; Sun, 29 Oct 2023 09:38:28 +0000 (UTC) Received: from foxhound.fi ([37.59.142.107]) by ghost-submission-6684bf9d7b-x2g4z with ESMTPSA id 9QKQHBQoPmXpkwQAjDjF9w (envelope-from ); Sun, 29 Oct 2023 09:38:28 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-107S001d53088e7-9f9b-4152-9236-a5a90e87501e, 2D5A9C8C3C9544CFCEEB4DEE313913C815DB1A20) smtp.auth=jose.pekkarinen@foxhound.fi X-OVh-ClientIp: 87.94.110.144 From: =?UTF-8?q?Jos=C3=A9=20Pekkarinen?= To: harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, skhan@linuxfoundation.org Cc: =?UTF-8?q?Jos=C3=A9=20Pekkarinen?= , airlied@gmail.com, daniel@ffwll.ch, qingqing.zhuo@amd.com, Jun.Lei@amd.com, alex.hung@amd.com, Zhongwei.Zhang@amd.com, sunran001@208suo.com, Yao.Wang1@amd.com, aurabindo.pillai@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [PATCH] drm/amd/display: remove duplicated argument Date: Sun, 29 Oct 2023 11:39:26 +0200 Message-Id: <20231029093926.137766-1-jose.pekkarinen@foxhound.fi> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 2888777688825374374 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedrleekgddtiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeflohhsrocurfgvkhhkrghrihhnvghnuceojhhoshgvrdhpvghkkhgrrhhinhgvnhesfhhogihhohhunhgurdhfiheqnecuggftrfgrthhtvghrnhepfedtleeuteeitedvtedtteeuieevudejfeffvdetfeekleehhfelleefteetjeejnecukfhppeduvdejrddtrddtrddupdekjedrleegrdduuddtrddugeegpdefjedrheelrddugedvrddutdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepuddvjedrtddrtddruddpmhgrihhlfhhrohhmpeeojhhoshgvrdhpvghkkhgrrhhinhgvnhesfhhogihhohhunhgurdhfiheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehkedvpdhmohguvgepshhmthhpohhuth X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sun, 29 Oct 2023 02:47:50 -0700 (PDT) Spotted by coccicheck, there is a redundant check for v->SourcePixelFormat[k] != dm_444_16. This patch will remove it. The corresponding output follows. drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c:5130:86-122: duplicated argument to && or || Signed-off-by: José Pekkarinen --- drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c index ad741a723c0e..3686f1e7de3a 100644 --- a/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c @@ -5128,7 +5128,7 @@ void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l ViewportExceedsSurface = true; if (v->SourcePixelFormat[k] != dm_444_64 && v->SourcePixelFormat[k] != dm_444_32 && v->SourcePixelFormat[k] != dm_444_16 - && v->SourcePixelFormat[k] != dm_444_16 && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] != dm_rgbe) { + && v->SourcePixelFormat[k] != dm_444_8 && v->SourcePixelFormat[k] != dm_rgbe) { if (v->ViewportWidthChroma[k] > v->SurfaceWidthC[k] || v->ViewportHeightChroma[k] > v->SurfaceHeightC[k]) { ViewportExceedsSurface = true; } -- 2.39.2