Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2315645rdh; Sun, 29 Oct 2023 10:07:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFE49VadWs+Hjfzpz55Oh6gRvyv3iQk3CQakxrSTk7dmz3OCGKYwLtnlbj41aVXnh4y+0Ze X-Received: by 2002:a05:6e02:b4d:b0:351:ab2:2621 with SMTP id f13-20020a056e020b4d00b003510ab22621mr13305594ilu.15.1698599242821; Sun, 29 Oct 2023 10:07:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698599242; cv=none; d=google.com; s=arc-20160816; b=RvfBP2XB6136pqFvE98iwh2nQNGjx/fZYHjXymLaiZWEX+3Utq4ic90gsHH1vd8rbp 6VaG7opzXxNQa2OtEhSLF4KNiDmRcIpA4V/XVvGJJiRFFvKZOh68BymSsS3IvDLVPoGS FYroSaTCh4t6b0oW0dlFP5gd7yh+LVoQDepePOi0Qlumar8V+UtM0+fQJ/frUavcgeBl YdZaDtyW0usJ7cRbSYNNv5HH9OoH0OmE+xbolg0K6bvdOl0CG7QeogAH/f/liO34Ybqx INHXBuksaA46u4MBm4ANIOmXft4hykjYpb/d95EbW5UFfuvp11FI6d7yuuQmBcm2COGB wJ3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :dkim-signature:message-id; bh=PSJtfAzcywTSN0h2+pbhBByrfU8Kesmbq2MGXuuxqmA=; fh=rSR5bg2ltY4VQIG1ASfrpS76ksKewfDg2ekOXtNBiFQ=; b=IAxpIFq/R5pLE4NYCJ0qw0zjCoeleOuM5BuPt3vbuYkDM8nRFmJUgkmo9tAuHUA6Sy HywlgbJQcxaojpq/GSiZPhXUo7ZoGUSRsgpIe9Q4VeQB/TldoPF3kgeadNVmTmDfqHMV UY3cOAG1deQ1+eiR1etr5lCJF+Pa/vKGlkj3jUET2FSRgU0V+5T6I0B41/RjYh9e092Z jySiHbcrgCyEcf95G6Y6JWVfTWZSjza4175hZjg/uxmV7io8gJ22CUP6U/b1vp/uohO0 NEHtH1b0SpH+D/L36Q8zXYnLisX/D48AHTWytv16UfajKBjdeuziPFcgJ2Ml6PU9RPzu A7Cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=QqvrHR6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id f22-20020a635556000000b0057d7cff25besi3783408pgm.829.2023.10.29.10.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 10:07:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=QqvrHR6E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D68618068595; Sun, 29 Oct 2023 10:07:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230207AbjJ2RHJ (ORCPT + 99 others); Sun, 29 Oct 2023 13:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230032AbjJ2RHJ (ORCPT ); Sun, 29 Oct 2023 13:07:09 -0400 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [IPv6:2001:41d0:203:375::b4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C1D2BF; Sun, 29 Oct 2023 10:07:02 -0700 (PDT) Message-ID: <60109bfb-1850-4b5b-87fd-c47a1e41bc2b@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698599220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PSJtfAzcywTSN0h2+pbhBByrfU8Kesmbq2MGXuuxqmA=; b=QqvrHR6EfAO/l9ZobJKx78tUZG0j7a7hKp+5+RNA08JP8g4KGQDF1MaIf8MELXrrjBQK00 PGkc0Uqw4f1t+v3eafFpPIuKOoNbuiecRfjrHt9PZCxX7MDEQsWbmucFMh5fiGSoFuZIbc 1slJiryqwRKrPyNbZKd+7olkwCkyu8E= Date: Sun, 29 Oct 2023 10:06:46 -0700 MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v3 1/2] selftests/bpf: Convert CHECK macros to ASSERT_* macros in bpf_iter Content-Language: en-GB To: Yuran Pereira , bpf@vger.kernel.org Cc: sinquersw@gmail.com, ast@kernel.org, brauner@kernel.org, daniel@iogearbox.net, haoluo@google.com, iii@linux.ibm.com, john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org, kuifeng@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, mykolal@fb.com, sdf@google.com, shuah@kernel.org, song@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org References: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 29 Oct 2023 10:07:20 -0700 (PDT) On 10/27/23 10:24 PM, Yuran Pereira wrote: > As it was pointed out by Yonghong Song [1], in the bpf selftests the use > of the ASSERT_* series of macros is preferred over the CHECK macro. > This patch replaces all CHECK calls in bpf_iter with the appropriate > ASSERT_* macros. > > [1] https://lore.kernel.org/lkml/0a142924-633c-44e6-9a92-2dc019656bf2@linux.dev > > Suggested-by: Yonghong Song > Signed-off-by: Yuran Pereira Acked-by: Yonghong Song