Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
Subject: Re: [PATCH] dmaengine: apple-admac: Keep upper bits of REG_BUS_WIDTH
From:   =?utf-8?Q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>
In-Reply-To: <20231029170053.82146-1-povik+lin@cutebit.org>
Date:   Sun, 29 Oct 2023 18:10:41 +0100
Cc:     Alyssa Rosenzweig <alyssa@rosenzweig.io>, asahi@lists.linux.dev,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        dmaengine@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <00401D09-6037-44AE-91CC-34379ED9589E@cutebit.org>
References: <20231029170053.82146-1-povik+lin@cutebit.org>
To:     Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
        Vinod Koul <vkoul@kernel.org>
Precedence: bulk


> On 29. 10. 2023, at 18:00, Martin Povi=C5=A1er <povik+lin@cutebit.org> =
wrote:
>=20
> From: Hector Martin <marcan@marcan.st>
>=20
> For RX channels, REG_BUS_WIDTH seems to default to a value of 0xf00, =
and
> macOS preserves the upper bits when setting the configuration in the
> lower ones. If we reset the upper bits to 0, this causes framing =
errors
> on suspend/resume (the data stream "tears" and channels get swapped
> around). Keeping the upper bits untouched, like the macOS driver does,
> fixes this issue.
>=20
> Signed-off-by: Hector Martin <marcan@marcan.st>
> Reviewed-by: Martin Povi=C5=A1er <povik@cutebit.org>
> Signed-off-by: Martin Povi=C5=A1er <povik@cutebit.org>
> ---

Please take up v2 instead. I slipped in the wrong email address in here,
which I don=E2=80=99t want to subscribe for kernel spam with.

=
https://lore.kernel.org/dmaengine/20231029170704.82238-1-povik+lin@cutebit=
.org/T/#u

Thanks!

Kind regards,
Martin