Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2430119rdh; Sun, 29 Oct 2023 16:19:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFgJE/DtFiBJvPkT/E0Zk3gvmTb1llpYyVIDs+HsJ3KiBir1F5FCgv/E4xQ65KFTsOj5B0Y X-Received: by 2002:a05:6a00:391a:b0:68f:d44c:22f8 with SMTP id fh26-20020a056a00391a00b0068fd44c22f8mr10808137pfb.1.1698621576447; Sun, 29 Oct 2023 16:19:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698621576; cv=none; d=google.com; s=arc-20160816; b=qO/hNVdQfJtWNjY0WtVkP7mD7uVFArovx6uh8LzOJLUMYdxzI6FItH/elRDfh2SIEB 6ucQxcts0gFgq9Qk4P5NNdlvxte5lAv7A2v3aWS4/CcukK3loXbekn7kFc5StnzBK0A1 0dnic1Egkky9ZZwrkhfTEHQTEW/1dWVN6EOHbEL1BcFfl8/QlX0h+CgxWZ6A5WnXzR/T iOK+D/e/IZl6m9g2kYzLPd2zarkMZfShuV3q447MZGWDUkMTBLdTR10/SNT9xPj4bpU4 RLpGJDEcZxO44ZaTzcRLhNOPfMdcUuj6OF8D7MVNKn+bI/B80lt7uxrYCpo+5OcP9aVA fIXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JKT0gqNJNDX32IdbIlxKeYbuVHIUHQaBY1W3bm1coaM=; fh=5cel2jD5h+yPMXVwxbomyVhwojHUqATy6nFjd4aOh4o=; b=WEFSfLo9yQ3ONdUyev+EeRuByItuparIromboYD/oJE+V4Kh3xjPmiKOPjFUuAKb/4 ZOkGibsul7uL8k0LxUbzQxtSSYl/XIOyaAtyhZfHlxTIERGLMaegQA5gp23aH5qq4M3U hsnjyWrgougSZYEgM/qCM+YBzxsCzUTvwq0dydjQ2KJsSca5kXdWDR9hZ6OZFZepRlJG OxGR1HFNaq4GNe1zUzwKLMkfp9F8vPKt2ZiAYxw8n9QgizeLwhJRCXMSe3vnHLmyCB/G X28Myj5eyATa9i5iWfvLrjubiaJFZIuLPHjCSc6ACrVnqHbyVY+pCnCaqWc67YFxhjlQ VX3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=WOwYdYKj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id f23-20020a63f117000000b005b87df75d54si4230463pgi.83.2023.10.29.16.19.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 16:19:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=WOwYdYKj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8A5398043905; Sun, 29 Oct 2023 16:19:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232187AbjJ2XT3 (ORCPT + 99 others); Sun, 29 Oct 2023 19:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232225AbjJ2XTQ (ORCPT ); Sun, 29 Oct 2023 19:19:16 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B8527295 for ; Sun, 29 Oct 2023 16:04:21 -0700 (PDT) Received: from workpc.. (109-252-153-31.dynamic.spd-mgts.ru [109.252.153.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id D51C766073AE; Sun, 29 Oct 2023 23:02:56 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698620578; bh=wqGvYp+XsBubezC7g24J4y9IRLkJRkmLc/LBzEkyYBg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WOwYdYKjt/I83fqDDsTMg5Buu1wHFIkeuyU9wAcSaZy3NfTy6QueCldxukReDXMo3 KBPvD83s9Glkx/p+53DWqpsQHJm+S0ci8yNyxTwamtrjRvAFIQz0FU6NOPJe6sJzsb cSuipy3uuEDuZgiK4toXK1IG6qQBdkNeIGgNjnj57QkEtNdzrsm93/1UBbgpAVAdjX Lot0g4ZFK+tKMsJLbrn+6DzBWbCp0cW9/2Jt5leAiGDM91fUu6C5b4afwkU8AQBY0a YECMj0VIWnka9VVDcHBwwap2dQUuNs2oJc+meDtl3mrAoSYWUeQUhvf8k1DRoHIEI1 jZWv4n6jSLZrw== From: Dmitry Osipenko To: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , =?UTF-8?q?Christian=20K=C3=B6nig?= , Qiang Yu , Steven Price , Boris Brezillon , Emma Anholt , Melissa Wen Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, virtualization@lists.linux-foundation.org Subject: [PATCH v18 21/26] drm/shmem-helper: Optimize unlocked get_pages_sgt() Date: Mon, 30 Oct 2023 02:02:00 +0300 Message-ID: <20231029230205.93277-22-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231029230205.93277-1-dmitry.osipenko@collabora.com> References: <20231029230205.93277-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 29 Oct 2023 16:19:35 -0700 (PDT) SGT isn't refcounted. Once SGT pointer has been obtained, it remains the same for both locked and unlocked get_pages_sgt(). Return cached SGT directly without taking a potentially expensive lock. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_gem_shmem_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 560ce565f376..6dd087f19ea3 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -955,6 +955,9 @@ struct sg_table *drm_gem_shmem_get_pages_sgt(struct drm_gem_shmem_object *shmem) drm_WARN_ON(obj->dev, drm_gem_shmem_is_evictable(shmem)); drm_WARN_ON(obj->dev, drm_gem_shmem_is_purgeable(shmem)); + if (shmem->sgt) + return shmem->sgt; + ret = dma_resv_lock_interruptible(shmem->base.resv, NULL); if (ret) return ERR_PTR(ret); -- 2.41.0