Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2430893rdh; Sun, 29 Oct 2023 16:22:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkO3bPPAzt2zEDzUxw5Kq3ppcIO55f/cN+PuDs0FLMo+hp2hChGZ3m8iDmWAVzZSLmaZTH X-Received: by 2002:a17:90a:d814:b0:280:3d2c:2a85 with SMTP id a20-20020a17090ad81400b002803d2c2a85mr2493468pjv.4.1698621740891; Sun, 29 Oct 2023 16:22:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698621740; cv=none; d=google.com; s=arc-20160816; b=SA4jDU5dL4JqH7VcDjxswYBqxc88W2Samm4V7vcXl2ErnrugMkTCncD75yXbgC30tj po8zq4CUfaTwwOu8aIbHhmZohR45K14hB7BygcV2toiuZE1TAI6szfqGhohk0U5iFZ+U VbpuKTBxiU7v5AfOyZ6aBv7nm5YmV2FbrWGGLRPZV+tWJy8dQjXWJbdu/WP6+mXkaklS R6kDb5jh/uOFlcHudy/qGyHcpqZmg/1AHiTyjAj/UMx6/u+O2l3gJ/+pzkZCYoPGFVWp d8hIBBx8Honhoq0nQeDdNPQBjnUKHnhkA97s+YzvMdyZhrSek/GnA2AysHAQNJ1xUbrE sk5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VT3Ad4lScHgALY3lYyr+KQk9MBuJnneunm0wQQrliGI=; fh=ardmABoZqyzAm25ow9fvqe18o8v8L1P0+Wo2I9sPHpg=; b=FkKd5yJYl+B4gvmLhFLoaVQ4sJej7+QnkFaB4cXca4nvip/jhsDGNx3PT1QQxW3cSj Klc2ell3G/2ysek2IP3Qd/ChaCuatiMxYN//qyqI3SE/cNXtDdaRbz4z0DAWl7Lh8Cnc yt+y/3BoWRwTeuMDlO92dBrfaRjypsEp+7jrmRk8RyNZE6uzyKXpilFfc3tVmT49ttC9 YZ3kDyqx/bYfdWeUeRiD8ZJ70zshgewUvkkZL+0R3Xh2jeEwzjk2HoLVKsCkH8Lyeemb jMGtCRJtLouQJZ5S1zMtyJT90FcNM5gg6Dnvn/MbjbpSRFodeSS1mVQyTW677Qd01uas 2dRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=s3Bd+dzA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id o13-20020a17090ac70d00b0027d3c6f8ab2si1897685pjt.66.2023.10.29.16.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 16:22:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=s3Bd+dzA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D931480B5A17; Sun, 29 Oct 2023 16:22:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231697AbjJ2XWR (ORCPT + 99 others); Sun, 29 Oct 2023 19:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232186AbjJ2XWA (ORCPT ); Sun, 29 Oct 2023 19:22:00 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4717E4E3E9; Sun, 29 Oct 2023 16:14:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VT3Ad4lScHgALY3lYyr+KQk9MBuJnneunm0wQQrliGI=; b=s3Bd+dzA8IVaL7EAr7sc9o7QFs RqxVYSQ+/gE1vs83o8o05Nml83SpfDzOtgZwmw3laXu4TZAQOHivFfFgiowRBqjspvKLEudIEYb9i bnznG0G9e0ZqqWXA5OKNdT31xCgyrgPn/vVwWmiWpKoynl0nRIHymyOuTgjTTEgSwdVlR4133p8j9 GV0Gtf2XLrx/3RAzU1e6NNQEhOYi+0cO999GMT0P8v1HoSCFe1b1ddiflYIb5fGoS62Kulwjlm5ex cRIS3gQfrNH2j8IzX/5qauNRHa/g+//WQ+zdwkekYx6e6hkwGqOallL7PfrmxdS8aBZ7dirFGyR41 D5zM70qQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qxEzW-000dtM-3j; Sun, 29 Oct 2023 23:14:46 +0000 Date: Sun, 29 Oct 2023 23:14:46 +0000 From: Matthew Wilcox To: Daniel Gomez Cc: "minchan@kernel.org" , "senozhatsky@chromium.org" , "axboe@kernel.dk" , "djwong@kernel.org" , "hughd@google.com" , "akpm@linux-foundation.org" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "gost.dev@samsung.com" , Pankaj Raghav Subject: Re: [RFC PATCH 06/11] shmem: trace shmem_add_to_page_cache folio order Message-ID: References: <20230919135536.2165715-1-da.gomez@samsung.com> <20231028211518.3424020-1-da.gomez@samsung.com> <20231028211518.3424020-7-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231028211518.3424020-7-da.gomez@samsung.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 29 Oct 2023 16:22:20 -0700 (PDT) On Sat, Oct 28, 2023 at 09:15:44PM +0000, Daniel Gomez wrote: > To be able to trace and account for order of the folio. > > Based on include/trace/filemap.h. Why is this better than using trace_mm_filemap_add_to_page_cache()? It's basically the same thing.