Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2435496rdh; Sun, 29 Oct 2023 16:37:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNLwl8ctKgciqXIU+x5zSSBBaSPIt5PTwDjwSgv8JzGqHlr2Hywid1grh5fsScqOlj/Bj9 X-Received: by 2002:a05:6a20:4310:b0:15e:f2a1:dae with SMTP id h16-20020a056a20431000b0015ef2a10daemr12102464pzk.27.1698622632855; Sun, 29 Oct 2023 16:37:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698622632; cv=none; d=google.com; s=arc-20160816; b=e0NTMl4ZDjPpVc/6uK9RCRzgmBoi+0cqJjqvGYRaVbflbEZTnJ5SOmdrjm8LhB+wPx svjQKHpIsVgOFV53W2cZA/cd/NxEr0/EqbZZpmarfH7dsFf7BH8o59zegLzznZuIeI0Z QPTtHWXSzPL49SndmuZ0emO/NEwqjAS/rB+3POrgruLPhiI0OAye3NEXRn8Qqnga3HVO ou5npHBpipv+AnAi+DJFoOiz0gQjndUfi3JPcOFrvQgUsFlNXY+mBlL+Q0Hd3ong2Mcp oXNnSpdwEPlK6jwoQsf7LIk7H9d4RdF2+Sc6rkBNVwgDd+F76ReoVte9CcN5BK7pIsVG AkVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7SSzayWNlysU5sdKne4uhYDTN4Ccz0eByy85nOX96CE=; fh=5cel2jD5h+yPMXVwxbomyVhwojHUqATy6nFjd4aOh4o=; b=FR/RHE284Bh+2xAvyPg703UwJHnhuRP13UbG7k6X/XBUYfg7atRyCP4mVwoTKMdySI kLLu4ZzBlFp70NCAg+zgpxgnoEOrEHUCZY2X7JUENgWurJa2qCtKINcSqBDFURr7JgQD JRATd4Jj9xP/Mx75ak3/D9aW1FoD1OP4nOAYT05/I4jhmMSZwJKX6UvxfJPyposA3YGf rO9D9Wl/XOWukj7js6R6dURQZ04HoMYETwbiG2+DNoBClBpxUj2KRnjS1U9OugwRsYT3 y+NCg4X1pGlZ6uQ7F7AdKjlpgyQS8DNKlc3bBwJwgfBnxRT9U9ccHMhqi3tQJ7fL/uEb f2YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=PeN7dCvY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id i3-20020a639d03000000b005b9022ddeb9si4072636pgd.501.2023.10.29.16.37.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 16:37:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=PeN7dCvY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id CE30C807E92A; Sun, 29 Oct 2023 16:36:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231736AbjJ2XgV (ORCPT + 99 others); Sun, 29 Oct 2023 19:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232603AbjJ2XJH (ORCPT ); Sun, 29 Oct 2023 19:09:07 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 167ED559B for ; Sun, 29 Oct 2023 16:04:09 -0700 (PDT) Received: from workpc.. (109-252-153-31.dynamic.spd-mgts.ru [109.252.153.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id 994336607398; Sun, 29 Oct 2023 23:02:43 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698620564; bh=6JSrV8dvFR5m76/teSuwB8SoeYdLm77F2T3NdDv9SQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PeN7dCvY7+whfuYqVPe+2Zkcivdg478TFFVcsWFNKyHjzKg+m7MoVZVSSKB1sNSFx F802eM4s0jQy3ZWMxkxCn3bN1LjkBrADWVn+D9sRF/e+jPFNvgKv/5sbpbTnxjg3Ar B/j2uTxhKr2Ki/kNM8LfvZMJ7vcyDhCWcDSAOqL73C0Lf93+eOG6gemcE/fWjkYE/R IrCOKoIanJJICwzN6we1X9m5qYIaoq39xRVeIHYHL/UUVLSTNcACsMEaPdziEdVeyr a2WuTlEKFZrkv6FFB50n1pZmrL1D/RXpEzwyQ1Nltw8IwG/4On6N0OaXdvJv07yitG iZFzaLI7XL2IA== From: Dmitry Osipenko To: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , =?UTF-8?q?Christian=20K=C3=B6nig?= , Qiang Yu , Steven Price , Boris Brezillon , Emma Anholt , Melissa Wen Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, virtualization@lists.linux-foundation.org Subject: [PATCH v18 12/26] drm/shmem-helper: Make drm_gem_shmem_get_pages() public Date: Mon, 30 Oct 2023 02:01:51 +0300 Message-ID: <20231029230205.93277-13-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231029230205.93277-1-dmitry.osipenko@collabora.com> References: <20231029230205.93277-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 29 Oct 2023 16:36:46 -0700 (PDT) We're going to move away from having implicit get_pages() done by get_pages_sgt() to ease simplify refcnt handling. Drivers will manage get/put_pages() by themselves. Expose the drm_gem_shmem_get_pages() in a public drm-shmem API. Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_gem_shmem_helper.c | 10 +++++++++- include/drm/drm_gem_shmem_helper.h | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 24ff2b99e75b..ca6f422c0dfc 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -227,7 +227,14 @@ void drm_gem_shmem_put_pages_locked(struct drm_gem_shmem_object *shmem) } EXPORT_SYMBOL_GPL(drm_gem_shmem_put_pages_locked); -static int drm_gem_shmem_get_pages(struct drm_gem_shmem_object *shmem) +/* + * drm_gem_shmem_get_pages - Increase use count on the backing pages for a shmem GEM object + * @shmem: shmem GEM object + * + * This function Increases the use count and allocates the backing pages if + * use-count equals to zero. + */ +int drm_gem_shmem_get_pages(struct drm_gem_shmem_object *shmem) { int ret; @@ -240,6 +247,7 @@ static int drm_gem_shmem_get_pages(struct drm_gem_shmem_object *shmem) return ret; } +EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages); static int drm_gem_shmem_pin_locked(struct drm_gem_shmem_object *shmem) { diff --git a/include/drm/drm_gem_shmem_helper.h b/include/drm/drm_gem_shmem_helper.h index e7b3f4c02bf5..45cd293e10a4 100644 --- a/include/drm/drm_gem_shmem_helper.h +++ b/include/drm/drm_gem_shmem_helper.h @@ -110,6 +110,7 @@ struct drm_gem_shmem_object { struct drm_gem_shmem_object *drm_gem_shmem_create(struct drm_device *dev, size_t size); void drm_gem_shmem_free(struct drm_gem_shmem_object *shmem); +int drm_gem_shmem_get_pages(struct drm_gem_shmem_object *shmem); void drm_gem_shmem_put_pages_locked(struct drm_gem_shmem_object *shmem); int drm_gem_shmem_pin(struct drm_gem_shmem_object *shmem); void drm_gem_shmem_unpin(struct drm_gem_shmem_object *shmem); -- 2.41.0