Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <TYCP286MB21465F970BF56AAE5D0CEB72C6A1A@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM>
Date:   Mon, 30 Oct 2023 11:11:42 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] tools/power turbostat: Fix Bzy_MHz calculation equation
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        liupeng17@lenovo.com
References: <TYCP286MB214616F6AE3E088C5D781A2EC6C8A@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM>
Content-Language: en-US
From:   Peng Liu <pngliu@hotmail.com>
To:     lenb@kernel.org
In-Reply-To: <TYCP286MB214616F6AE3E088C5D781A2EC6C8A@TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TYCP286MB2146:EE_|TYCP286MB3800:EE_
X-MS-Office365-Filtering-Correlation-Id: 922841f8-456b-45d0-bc6f-08dbd8f6084a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xXSziK8B5ZbPfkBoVwwf5lqzbFLL7LYv6L/NuSCfw4eLzJGo+ffK8Y3GAdzdIe4g8CaUV9TcLzFBlXhSga1jq3YnHZnBprAoAbVC6R505z++HRRrIlCGEM99kTm0L3S5X1qf8LY9DJ81T3aOquiyYfbzBIK5uXwIqVzlYJJyJyPJmUSkiezqnC0oXDB1+C8whwJ6jPrbzy5S8Q9K0pH/ukm6ReOj9Q9oVG7s/25pXNcYOoPQFtq/rOeH1/y3bWMqcRNt+gmwTNF90SColCp6x4OfMs8h8GCnsLOlGrKct3Y26n0W/TqNJ6wLg5HFpNbGCkj0QWeNFz/ACm28poZl0CRtjCECfStmBq+93GKVKx74NKEUd3k1V5PlU5NS8YYDNOktVQaon6hgI2W3xi+62osfiZaXpMFB0VM3upS3RtQIm9jAWhUFTlCT0A2AY5jghlnUIlzSURdrzUODVnsN7ZwRXC1zRaa4QSPRN8UMW0HrWly8kGYNH7s0C4KTzUZkNdTFYTT2Sie8uHVwYBzTuzGc/hMwhjl58AzAECqJZ6xWXVd3Ojx6+f/xh9SXSdpV
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0FWVTE3b3RGSlpFbWEyUW1EOVR1WFlxZGpFOE1zWUoxU04yaDVDWVorVW4x?=
 =?utf-8?B?U2Z6Q2lFL21LN3hFYWhsc252NG1tUEFNNkdhZ1l4VTRTT3pxMHZBNC9ETFJF?=
 =?utf-8?B?NGt0R1JqcjBheHhjWVNsZVcrMXl2TTB4Mnk4K3dMeVN6bW9scERvVExrNC9O?=
 =?utf-8?B?aDA5ckpJNVZCTkxWV2VPSkE2d1N6NXdrVHVKcGNZdVBDS3FJRmYwYWtwTmxR?=
 =?utf-8?B?bnJNZ1p2WWhiNGpaTytJaFdHRHd3U214SU9LV3R6MGhwOXhVR0RQNlBXN3p5?=
 =?utf-8?B?b1lsQldXQ25YY0laME5xaFJaZXNJanB2TWN2ZTRSRldmeHViQXZHUU9Qbkd6?=
 =?utf-8?B?WXlCL1JOYXR1YlVSbWE0Zkp6U2VySVFvYWU2M3RCQitIU0dxbDc1cDRwZFhX?=
 =?utf-8?B?eXd4MmVtbmRWWXJWenpESjdYdGFkTjI1ZFpGR1Bnd2wxZ3g2WnVHaTJ0S014?=
 =?utf-8?B?bWJwWHJrY2EvRm91cStBMDhpblEvY2hobTg4RVgxN045SElRVlFqR05kand4?=
 =?utf-8?B?QjFRT1d5dGllVVh5d09abTdXbEZJblk1YmQ3UjlGbWpRM0wzeFg0dDBkekly?=
 =?utf-8?B?UExVNG5FWllVTE1JN1VHWWZaazBkbEtKa1NoOGN3ZEFpWnZRK2NEVmpUVWw3?=
 =?utf-8?B?NG9YemVLM3YwY3FkUUhEMkw1ejhKaEQ3dDduenRsVzhHV0hXK1NmV0FkQ0Fa?=
 =?utf-8?B?VzAvcHQxQ2hmdjVCcmhxZGpTQThtbEhGZFBNaW9mejZQTzRvbjc1MStvQ0o2?=
 =?utf-8?B?andjWFBjNDMxWnVsUnNCNHlJUWpWSW9zUUZ4aXQ4ZGxpRjhOMGh6TVM4andr?=
 =?utf-8?B?djVaNHpuNlNFMU9VakNNZW9OUnk5Wjg2NysxQ1NBQ21CeTFrd1FSQm9pTVN1?=
 =?utf-8?B?anJSK3RSTWtwa2xuam1LMHBMTUpZaG5CWjB5THBsUzZySFBxZnBOUDUwWVNq?=
 =?utf-8?B?R3Z2blRtdVdDcjJNUUQ2UFNINDMwYXJnUVJJVnRNVUF1OTFkVXlJM1hvZ1Zh?=
 =?utf-8?B?Q1F5MEZTVmxzSG1LWnlTVEFldzV6bjkyanZMQ3doZitxVlQ3aTJIbXFoQllp?=
 =?utf-8?B?SkRKc2x4Sm4rV0s1MFc3UWlTdVpsdXYwZ3hRYnNub3hHcHBLamxZNWhIWXpl?=
 =?utf-8?B?V0twUVV3TjZuYjBPWFJqL1pBTWRXU2pOTXpBU0ZTUDl2L0FaSEpkRnZaKzRs?=
 =?utf-8?B?TDBYTUVmS21wNFJzSDJSTDJVb3RnWVhRcHdibHR5VUtBN1pMY1BPdEh2bjhm?=
 =?utf-8?B?TkdGcDNwclhJNUZmMkwyZWk0WVd1bVQ4U3hLK0dEcktVQjlJWmVrMjVPZ3JP?=
 =?utf-8?B?dVFnamRLaE15YUZWOEgzUkFyWXNWMXBlNE9EcDRkMVAvRnBLQkN4NnZhd3Fs?=
 =?utf-8?B?VHNNSXB5WUtIeFRsV0dNbXhPR0R5TkpQa0pJYm02eW1wNzhOeFpTdHV2aVJo?=
 =?utf-8?B?bjhBa1ByRUFDcFFoSW1lNERvKzBSTjBPc0VLbENxVzY2NEVGcDZrQTVkVDlm?=
 =?utf-8?B?VXRoQjJNSFV3R0RsbWNSQldWVmE2VHFEck1pQnlLc0ZwVm9jWDRNVmd5cXhS?=
 =?utf-8?B?K1Q5RldrYnd0eTBqck9VTmZtSldmSnAxWFlCWUV4RUd6NHlKMDVMRG5xMHBh?=
 =?utf-8?B?cTQ3Nkt5Rm1PM1JpNUpGU2xuYW45QkE9PQ==?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 922841f8-456b-45d0-bc6f-08dbd8f6084a
X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 03:12:22.0656
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB3800
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FORGED_HOTMAIL_RCVD2,FORGED_MUA_MOZILLA,
	FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 29 Oct 2023 20:12:49 -0700 (PDT)

Ping

On 2023/10/7 13:46, Peng Liu wrote:
> From: Peng Liu <liupeng17@lenovo.com>
>
> To calculate Bzy_MHz, TSC_delta should multiply APERF_delta instead
> of dividing it.
>
> Signed-off-by: Peng Liu <liupeng17@lenovo.com>
> ---
>   tools/power/x86/turbostat/turbostat.8 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/x86/turbostat/turbostat.8 b/tools/power/x86/turbostat/turbostat.8
> index 8f08c3fd498d..1ba6340d3b3d 100644
> --- a/tools/power/x86/turbostat/turbostat.8
> +++ b/tools/power/x86/turbostat/turbostat.8
> @@ -370,7 +370,7 @@ below the processor's base frequency.
>   
>   Busy% = MPERF_delta/TSC_delta
>   
> -Bzy_MHz = TSC_delta/APERF_delta/MPERF_delta/measurement_interval
> +Bzy_MHz = TSC_delta*APERF_delta/MPERF_delta/measurement_interval
>   
>   Note that these calculations depend on TSC_delta, so they
>   are not reliable during intervals when TSC_MHz is not running at the base frequency.