Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     ivecera <ivecera@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "Drewek, Wojciech" <wojciech.drewek@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "Keller, Jacob E" <jacob.e.keller@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next] i40e: Delete unused and
 useless i40e_pf fields
Thread-Topic: [Intel-wired-lan] [PATCH iwl-next] i40e: Delete unused and
 useless i40e_pf fields
Thread-Index: AQHaB1P8axEddTwy3UCkIkMohiluE7Bh7vbw
Date:   Mon, 30 Oct 2023 07:04:25 +0000
Message-ID: <BL0PR11MB312257E7B85EC1E71ED49E98BDA1A@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20231025145937.1873040-1-ivecera@redhat.com>
In-Reply-To: <20231025145937.1873040-1-ivecera@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Yr5l9yNZrMb2lnZIbWUSBsWSk7TmmKb+wAL3Rd4p6BWcF20d09IB4DEum06+?=
 =?us-ascii?Q?QCLaNER2Z3jW/wF67KFId3LGiNdm83kEnUnquUBvhF4TovE+fbtuC0NYns06?=
 =?us-ascii?Q?fsW/n2m+GIoz9lcyJLLceKdV/J37lHC99MBU5YKQAYkcfm7H/qXXaXD2wAhl?=
 =?us-ascii?Q?UnSMiYCGPe+fuLTh4te+58EOQms6ezg8RSNt/bRiTixlQ36/4Ie9l9mv62Tm?=
 =?us-ascii?Q?mnvBhfoDAU8dAMI6mT9ajSvs8kaJF5CIzyveLT4fIJs6jN+VUmwjsX9DOE1M?=
 =?us-ascii?Q?5o7qMhSTICIzRw/+8PURgXIyHlMndnowaxhOKpg4vxgiCHudvmfq+vm39HX3?=
 =?us-ascii?Q?Y97JyFZjvSFIOoxoq6Tcv0O1idN1YcMRrABUAn/mQhF5b4hW3Ckt6Y21E65A?=
 =?us-ascii?Q?EY+RSxf3vMKMAa2n+Guuz+hFPl05UmnP+eQ2J49WmwBtsuIOzZw5AizycVuc?=
 =?us-ascii?Q?wEl/AiVlM4SBYgKiAdMMPrs2GJf17i6CssC9tgbIXKzkaC0zB/5p7gSwMHc5?=
 =?us-ascii?Q?LICTSjTAacqjqTKSOOwwQ8PCXvimnR4FRWyI6xwuJsdmbf92Ow3jU+60kZqR?=
 =?us-ascii?Q?LHR68+DzZwNreSASoZNcHJMrozMHZuohHCkyz18sTgA74VsQRLT4ewgWAF2u?=
 =?us-ascii?Q?ShM8uSvNaDUmb7K1IPyQd6Xv0G17U+3KZpg1WUE9b2HrAvNj0s9vLdHcpZMG?=
 =?us-ascii?Q?d0e6yLcyspfrQdu8C9fGsuZnlnCw6b949hClYugZ5JyU3oAFo8q05GZPnAjY?=
 =?us-ascii?Q?RCKhQ6Bu7WuXYuFGXVf47dNo73Si0zXGvnXEcRC/8gsiVeD7geuJygiGZP9l?=
 =?us-ascii?Q?ZiXXPjG3HYcMp+ZOim7GCqfLlRzEKLjHZxh/kGTHTthlGv1KSKDYLIf5IveV?=
 =?us-ascii?Q?aAY4OTQFM8N6tMapxZU7ftKVKFc8qtskQIDIngv+KkNVT0fp0NM1fYcfD2Pv?=
 =?us-ascii?Q?FOqbXYQM++OM1TiL+CSH/i0LVZgk83HmfQ+BWLeOzXIinJc5A3aA2CqmaAWb?=
 =?us-ascii?Q?pcVcsEVx3XqEdQaNpLcyV483sRgAbJAZ15bOBaC+nC9rnOKvlFzUxWXTm21y?=
 =?us-ascii?Q?3sPlkqOnfJTCExk44yHZNlP/EsgL6QORSfgMvRoL83Hv4rDB9ASbqcdCQras?=
 =?us-ascii?Q?4FRuOe4fFLdZbrVygmAY5848XG1qin3NcIfwXYrkDlmA6Z7jtIetfwuNPJo4?=
 =?us-ascii?Q?DVGxBr8LM6aJCe+18bFu6bcF9HTVMok3uevUnAwDJX3jy3Y3YJ19yndhT+Ds?=
 =?us-ascii?Q?WCjhU6p58HrG8IKyVg7rfJGk1QwxT2qfiFf8pieG5+boKyGhpETqKPQoOxiU?=
 =?us-ascii?Q?KWPMlhrDHiAneEnLJL0tKKXAJVcxmG3KKNUKh3mG2G/OfuWEBNFPEunOUXZg?=
 =?us-ascii?Q?WOlhYpfhh4jOo/jJy9UEZGwk9NM++eXghGNBPEtt/6I7JhSuNLQmoQX53aRp?=
 =?us-ascii?Q?fi5z9m5Jym04dR7Cj29SqsTlSRyWifiL7A7+fQ9MSgHM+VMezxlaKTungwZl?=
 =?us-ascii?Q?amZDaFambCm3WSDoB/ZygB1LTDk7H3kaKbog23ENNxlkbN+B16d5wbeQljv0?=
 =?us-ascii?Q?wSUfaHdnC1LmcdjtEc6wi3h9zPfhRGNoX313lzqROC3/G9f+cexvHN1Pjjxl?=
 =?us-ascii?Q?qw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1713c1f-ea57-47dd-781f-08dbd91673e2
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2023 07:04:25.9678
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VQEtdcipPrINIPGcwXWZHeOPcA3lzdiuYIr5OURNoik4TtEbL0jDHT8gpDf4TIgekaUtJMEGTyObOmWPIomEjaqaVw4JJTGBcrnVQpVJw/zeJLthX7/q/JTxm4Ow6vr/
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB8236
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 30 Oct 2023 00:04:50 -0700 (PDT)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of I=
van Vecera
> Sent: Wednesday, October 25, 2023 8:30 PM
> To: netdev@vger.kernel.org
> Cc: Drewek, Wojciech <wojciech.drewek@intel.com>; intel-wired-lan@lists.o=
suosl.org; Brandeburg, Jesse <jesse.brandeburg@intel.com>; linux-kernel@vge=
r.kernel.org; Eric Dumazet <edumazet@google.com>; Nguyen, Anthony L <anthon=
y.l.nguyen@intel.com>; Keller, Jacob E <jacob.e.keller@intel.com>; Jakub Ki=
cinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller =
<davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-next] i40e: Delete unused and usele=
ss i40e_pf fields
>
> Removed fields:
> .fc_autoneg_status
>     Since commit c56999f94876 ("i40e/i40evf: Add set_fc and init of
>     FC settings") write-only and otherwise unused
> .eeprom_version
>     Write-only and otherwise unused
> .atr_sample_rate
>     Has only one possible value (I40E_DEFAULT_ATR_SAMPLE_RATE). Remove
>     it and replace its occurrences by I40E_DEFAULT_ATR_SAMPLE_RATE
> .adminq_work_limit
>     Has only one possible value (I40E_AQ_WORK_LIMIT). Remove it and
>     replace its occurrences by I40E_AQ_WORK_LIMIT
> .tx_sluggish_count
>     Unused, never written
> .pf_seid
>     Used to store VSI downlink seid and it is referenced only once
>     in the same codepath. There is no need to save it into i40e_pf.
>     Remove it and use downlink_seid directly in the mentioned log
>     message.
> .instance
>     Write only. Remove it as well as ugly static local variable
>     'pfs_found' in i40e_probe.
> .int_policy
> .switch_kobj
> .ptp_pps_work
> .ptp_extts1_work
> .ptp_pps_start
> .pps_delay
> .ptp_pin
> .override_q_count
>     All these unused at all
>
> Prior the patch:
> pahole -Ci40e_pf drivers/net/ethernet/intel/i40e/i40e.ko | tail -5
>        /* size: 5368, cachelines: 84, members: 127 */
>        /* sum members: 5297, holes: 20, sum holes: 71 */
>        /* paddings: 6, sum paddings: 19 */
>        /* last cacheline: 56 bytes */
> };
>
> After the patch:
> pahole -Ci40e_pf drivers/net/ethernet/intel/i40e/i40e.ko | tail -5
>        /* size: 4976, cachelines: 78, members: 112 */
>         /* sum members: 4905, holes: 17, sum holes: 71 */
>         /* paddings: 6, sum paddings: 19 */
>         /* last cacheline: 48 bytes */
> };
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e.h         | 16 ----------------
>  drivers/net/ethernet/intel/i40e/i40e_debugfs.c |  3 ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c    | 18 ++++--------------
>  3 files changed, 4 insertions(+), 33 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)