Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
To:     Guenter Roeck <linux@roeck-us.net>
CC:     Jean Delvare <jdelvare@suse.com>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [PATCH v5 2/2] hwmon: ltc2991: add driver support
Thread-Topic: [PATCH v5 2/2] hwmon: ltc2991: add driver support
Thread-Index: AQHaB/gc9TyQBjH91U+XiC0CuBoxd7BfZOIAgAKYcqA=
Date:   Mon, 30 Oct 2023 07:59:12 +0000
Message-ID: <CY4PR03MB3399049CB79E0F468A945C659BA1A@CY4PR03MB3399.namprd03.prod.outlook.com>
References: <20231026103413.27800-1-antoniu.miclaus@analog.com>
 <20231026103413.27800-2-antoniu.miclaus@analog.com>
 <075f6150-74f2-478e-9290-aa7186140cee@roeck-us.net>
In-Reply-To: <075f6150-74f2-478e-9290-aa7186140cee@roeck-us.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wR5sygZLoWjs/C5FFj6J3PudO4R7gBoL0mGeyGunEhb8VIRSc9JusI0CC+fU?=
 =?us-ascii?Q?mOHcVGQtjjgDJmdyy4j4Cbs/kLulGxmYUDGTIJpU4cukshEXyFdgq+OGnJ59?=
 =?us-ascii?Q?8yVfgTi+OFw034MXrfPsIbCbnXsYg99sLrlFLJWr8ku9hkvprr8h2gwMJaWI?=
 =?us-ascii?Q?uDsUw6sNf0ZuqU68G05lz1++hSWB7cYrHPoFNRXcCu8DBU0WDjefdP8Jnvw5?=
 =?us-ascii?Q?CilKTxzxn0RTcCJvTE8xMFY9m6+U/NOXo/syG4dVnis3Qpx+LYQ3V96ANqjt?=
 =?us-ascii?Q?syet9LHjADBKydO8KUA0YCbNS3v8b3le+wKFPM7REKALSnkC4+QR+aGWcLWn?=
 =?us-ascii?Q?akqNitR/cQbKK7A9x4lhWCCGlSqUBOfaOqKaqpmF9LljLG1QuKjUz4aJAdl+?=
 =?us-ascii?Q?u8SZJhFZs0a7fYO6RtQq6EtgRig9A4+xVTJrU/YRZngHgj2AHjk04vtsBsFe?=
 =?us-ascii?Q?hEo9bkiIDXmoGmqckyt7qYxeHNcCXMU8S1O/x0T5UosE+1j0w4xODjnIi9ya?=
 =?us-ascii?Q?rMw+zh8xMnvqO/7Z8IfG02lapZ3OhPNRedmrf+b9ogQB+X0YEVkwX3V+0Nmg?=
 =?us-ascii?Q?4UgCz2/ZyY9YpUkZ4H6Jf5GBv/6618EfKtqf2mlbz3ywk+dCX8yuQRnEmtGf?=
 =?us-ascii?Q?4ydomd0sXUGvxtPrpwgeuyZQg2qSi0sIGxp78SPSdSO65mYvqOCzcmhj389C?=
 =?us-ascii?Q?zZthccAKqiKVMLu1suMeZBbeL5Xze7n/pPucPdPsKqpBWa8nNVT112iXWW6K?=
 =?us-ascii?Q?b1+2tFwgoPeV6e+dxdzopRmqFVPRErjhQ/oo25s44yFMrq4lz03aNJ9WsZVH?=
 =?us-ascii?Q?z0FkCpXWzfubvXoMnVTeVLIimmxqcmQ51ERL+BtZX3FAP04f87sJbrGPIda6?=
 =?us-ascii?Q?r9N29DfCY0ZKwDNtvSuUH9bUSUfKq529bNh++to2K7IPPdHt1Ietkj39JAw6?=
 =?us-ascii?Q?lPL6eyvZzhUFWO9Qk69vtXdykI6uIiCwur8Kpj39PKBPYEGiaYPyBJkfaxNi?=
 =?us-ascii?Q?HtsEHlBoSQ6jLjNIxeuwfP/rqUKW+WHPSFGR9otJoA9zQr+UaItSu1kovNMF?=
 =?us-ascii?Q?vYs7MaEdUR4E/bC3QAkCITtkpk0URsit2JkfYrCGitmCyedMKZ/vEVgP1yNl?=
 =?us-ascii?Q?u6eolrg/CaGWAENgukQGtnk/hDgTkAtCyH05DMiULiV5gyHo6AvSjS9AKJRP?=
 =?us-ascii?Q?qyYXkdRv/xqeJNGA3qyK3csJx+P9XdTZnVVLGsD9kdhqJL1haG3KzRroh0zW?=
 =?us-ascii?Q?0IDoUZ0eY7/fs+LPl5KGjxVLRAkzyh+RLXzcBMUh4neOummnGLSE2IJNxr5L?=
 =?us-ascii?Q?fCvzLFdKo1QFjcSgH4qDdJvxsgB22cuaa9CmuVqsp+xXUDFxnHdLqYSj/UNP?=
 =?us-ascii?Q?Zm07GpLFdXmuxi2iaRjnUPfqtDtlWnPx04pmqpMRJFFahJ5R91myGga0Gntl?=
 =?us-ascii?Q?/312zkz2q7e+G6sK4dO3PZ7OJVzk8Sat85S3qo/jLnBxPa7gyMvTqMy6rw91?=
 =?us-ascii?Q?dL34R2Bp6lIC68x2qSb+CDwtt8FUvLCaEjJGIFcZZwAyzGtG5vOpFnLq7cRd?=
 =?us-ascii?Q?nsZW8vjkAYrMFWsw4kfnqAegHr8Lt1z0Y+xyLQHvsgNslgKVxJRXXhBi8/E8?=
 =?us-ascii?Q?Dw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR03MB3399.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a06aaf32-472a-4997-1aa0-08dbd91e1acb
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2023 07:59:12.4818
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dxdoX94VDQzsooXNBcWXvZpmTaXvVISX6GR2TIkBu0WULok0D1GuLZA16a4751kbH0jFr1dzdz+uKmb72Wap7YCcNCVPRa6nxIL7F+RvEBY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6068
X-Proofpoint-GUID: SpVjsjbwRc5IYtHlawiMBSq3EZozlxxV
X-Proofpoint-ORIG-GUID: SpVjsjbwRc5IYtHlawiMBSq3EZozlxxV
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-30_06,2023-10-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 spamscore=0 malwarescore=0 adultscore=0 impostorscore=0 bulkscore=0
 priorityscore=1501 phishscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2310240000 definitions=main-2310300059
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 30 Oct 2023 00:59:54 -0700 (PDT)


> On Thu, Oct 26, 2023 at 01:33:13PM +0300, Antoniu Miclaus wrote:
> > Add support for LTC2991 Octal I2C Voltage, Current, and Temperature
> > Monitor.
> >
> > The LTC2991 is used to monitor system temperatures, voltages and
> > currents. Through the I2C serial interface, the eight monitors can
> > individually measure supply voltages and can be paired for
> > differential measurements of current sense resistors or temperature
> > sensing transistors. Additional measurements include internal
> > temperature and internal VCC.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>=20
> Applied. I do have one comment (see below) about code which
> I would normally reject, but I am getting tired.
>=20
> [ ... ]
>=20
> > +
> > +struct ltc2991_state {
> > +	struct device		*dev;
>=20
> It is completely pointless to have a reference to dev in struct
> ltc2991_state because it is only used in the init function and
> dereferenced six times there. It would have been much easier to
> pass it as argument to that function. That would also have avoided
> the wrong assumption or expectation that it is needed/used elsewhere.
>=20
> Guenter
Sorry for the misunderstanding. I took as reference some old driver
implementations from the mainline kernel.

Is it fine if I do a follow-up patch on this subject in the near future?

Regards,
Antoniu