Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <53e9d294-46dc-90ae-c0ef-af09c658a80e@huawei.com>
Date:   Mon, 30 Oct 2023 17:32:09 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] block: Fix minor range check in device_add_disk()
To:     Yu Kuai <yukuai1@huaweicloud.com>,
        zhongjinghua <zhongjinghua@huaweicloud.com>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        <axboe@kernel.dk>
CC:     <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <yi.zhang@huawei.com>, "yukuai (C)" <yukuai3@huawei.com>
References: <20231025084621.2338604-1-zhongjinghua@huaweicloud.com>
 <119b7314-10a9-4d62-b40f-19462dc68009@I-love.SAKURA.ne.jp>
 <26bafe93-345d-2696-8ee7-7d1baa0e7eb7@huaweicloud.com>
 <df52b8a2-dff1-3973-b2bf-ca915c3f44d3@huaweicloud.com>
From:   zhongjinghua <zhongjinghua@huawei.com>
In-Reply-To: <df52b8a2-dff1-3973-b2bf-ca915c3f44d3@huaweicloud.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2023/10/30 17:26, Yu Kuai 写道:
> Hi,
>
> 在 2023/10/26 16:52, zhongjinghua 写道:
>>
>> 在 2023/10/25 18:06, Tetsuo Handa 写道:
>>> On 2023/10/25 17:46, Zhong Jinghua wrote:
>>>> Checks added in patch:
>>>> commit e338924bd05d ("block: check minor range in device_add_disk()")
>>>> ignore the problem of first_minore < 0 and disk->minors < 0.
>>> What is the problem of first_minor < 0 or disk->minors < 0 ?
>>> Are negative values legal/illegal ?
>>
>> These two values are used as the secondary device number and the 
>> maximum number of partitions, which is illegal if negative. Then 
>> first_minore and disk->minors are signed numbers, and the sum may be 
>> less than MINORMASK to bypass the check.
>
> Let me complement it, first_minor and minors can be set by driver, and
> driver allow set them throuhh ioctl/sysfs from user parameters, for
> example:
>
> If user pass in -1, and each disk support 8 partitions, driver will
> usually set:
>
> disk->first_minor = -1 * 8 = -8;
> disk->minors = 8;
>
> Then first_minor + minors = 0, then the following condition can't detect
> this case:
>
> if (disk->first_minor + disk->minors > MINORMASK + 1)
>
> By the way, we never limit how first_minor and minors is set by driver,
> and it's illegal if driver set first_minor = -4, and minors = 8.
>
> Thanks,
> Kuai
>
>>
>> .
>>
>
Kuai, Thank for your explanation.

Jinghua