Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <6e7df8dc-e31b-472c-86fb-0aef8f6e712b@linux.dev>
Date:   Mon, 30 Oct 2023 17:43:42 +0800
MIME-Version: 1.0
Subject: Re: [PATCH RFC 1/2] RDMA/rxe: don't allow registering !PAGE_SIZE mr
To:     "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>,
        "zyjzyj2000@gmail.com" <zyjzyj2000@gmail.com>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>, "leon@kernel.org" <leon@kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rpearsonhpe@gmail.com" <rpearsonhpe@gmail.com>,
        "Daisuke Matsuda (Fujitsu)" <matsuda-daisuke@fujitsu.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>
References: <20231027054154.2935054-1-lizhijian@fujitsu.com>
 <53c18b2a-c3b2-4936-b654-12cb5f914622@linux.dev>
 <784a65e3-5438-4700-b3e4-1d72d144ec2a@fujitsu.com>
From:   Zhu Yanjun <yanjun.zhu@linux.dev>
In-Reply-To: <784a65e3-5438-4700-b3e4-1d72d144ec2a@fujitsu.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2023/10/30 16:13, Zhijian Li (Fujitsu) 写道:
> 
> 
> On 27/10/2023 16:17, Zhu Yanjun wrote:
>> 在 2023/10/27 13:41, Li Zhijian 写道:
>>> mr->page_list only encodes *page without page offset, when
>>> page_size != PAGE_SIZE, we cannot restore the address with a wrong
>>> page_offset.
>>>
>>> Note that this patch will break some ULPs that try to register 4K
>>> MR when PAGE_SIZE is not 4K.
>>> SRP and nvme over RXE is known to be impacted.
>>
>> When ULP uses folio or compound page, ULP can not work well with RXE after this commit is applied.
>>
>> Perhaps removing page_size set in RXE is a good solution because page_size is set twice, firstly page_size is set in infiniband/core, secondly it is set in RXE.
> 
> Does The RXE one mean rxe_mr_init(), I think rxe_reg_user_mr() requires this.

Please read the discussions carefully. This problem has been discussed.

Best Regards,
Zhu Yanjun

> 
>    48 static void rxe_mr_init(int access, struct rxe_mr *mr)
>    49 {
>    50         u32 key = mr->elem.index << 8 | rxe_get_next_key(-1);
>    51
>    52         /* set ibmr->l/rkey and also copy into private l/rkey
>    53          * for user MRs these will always be the same
>    54          * for cases where caller 'owns' the key portion
>    55          * they may be different until REG_MR WQE is executed.
>    56          */
>    57         mr->lkey = mr->ibmr.lkey = key;
>    58         mr->rkey = mr->ibmr.rkey = key;
>    59
>    60         mr->access = access;
>    61         mr->ibmr.page_size = PAGE_SIZE;
>    62         mr->page_mask = PAGE_MASK;
>    63         mr->page_shift = PAGE_SHIFT;
>    64         mr->state = RXE_MR_STATE_INVALID;
>    65 }
> 
> 
> Thanks
> Zhijian
> 
>>
>> When folio or compound page is used in ULP, it is very possible that page_size in infiniband/core is different from the page_size in RXE
>>
>> Not sure what problem this difference will cause.
>>
>> Zhu Yanjun
>>
>>>
>>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>>> ---
>>>    drivers/infiniband/sw/rxe/rxe_mr.c | 6 ++++++
>>>    1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
>>> index f54042e9aeb2..61a136ea1d91 100644
>>> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
>>> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
>>> @@ -234,6 +234,12 @@ int rxe_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sgl,
>>>        struct rxe_mr *mr = to_rmr(ibmr);
>>>        unsigned int page_size = mr_page_size(mr);
>>> +    if (page_size != PAGE_SIZE) {
>>> +        rxe_info_mr(mr, "Unsupported MR with page_size %u, expect %lu\n",
>>> +               page_size, PAGE_SIZE);
>>> +        return -EOPNOTSUPP;
>>> +    }
>>> +
>>>        mr->nbuf = 0;
>>>        mr->page_shift = ilog2(page_size);
>>>        mr->page_mask = ~((u64)page_size - 1);