Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2679619rdh; Mon, 30 Oct 2023 04:51:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgdip9UJFDJ4Ac6Z7eSvETFcfNRge6BWJuh2L/dNU8hBy03+9ZP9QRUDbAvF8aevCxziDq X-Received: by 2002:a05:6a21:71c7:b0:152:6b63:f1e5 with SMTP id ay7-20020a056a2171c700b001526b63f1e5mr8831382pzc.38.1698666681031; Mon, 30 Oct 2023 04:51:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698666681; cv=none; d=google.com; s=arc-20160816; b=ox6t2PQHC9kFJAeTHfJFWpXrGYn5HAKTYz4FUsYQwnjgy8n1jkfUMZTkUzbo/bR0Lc slOAWfpxt3Wkwu9UGcFv82BKdLUm+RJY4Wn01VUQLa98tPbKJrhhVhk5swMvhNePY+S6 jlx68aXKkRx5VCZr4xtNj6U3XBvd4UBsuaN2ueGn+fYmcZCQXkan/c9mIbhuH/S8Lx6z mfz81tmAhKQ1qqQJDhu5d21HIOHKr2TrnWY9M4izJBh1v3BXPKOZRjCFZe2pGgz1ryRk tOBVU3oCO46hrNv0EkwbyusR6HogJRjH6F/hygs4fp6jftdY+Qn6qMiMcdaK3Lb4dyc2 R+hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=peI4fd+q9m2CP1lZDwUqLADwD4roKTnMozmg3iKN+Pc=; fh=Qqo7VE38soV9VGnev0uToMwG2MrHJytTFIl1nY939Bk=; b=kzYpKZk2K6/A944Gap5O41QNDnQ8vdTFP+s0J4uhQ70GECxLpRooHCNnxTewhonjDc UV4gzLRq3/QkR9sPP1CXarsr0XrSAV0qwToLTXf6o2bdCyhrdH5nrmPrx9uTkPzEwMaF j5FrmqmoCkM0PocqNKqvkQ+K1f21mC3LpLttrDagzWwGelN+j/mzN4uR/LhCc1m+HINK UUHEZoZZhr/B0P+Ogq1HxylbjihG+FxC5pVxQhehhkxxmgzbBchywff043t73iPrZCH8 XjmMZqKzb8M5SP0ApzUFcOgwz4hnKrl3ZtE0rVsBFEXYrUXjrq0Z42YL3TC3MgrKxzfW JfSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZPoFfIjL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id z16-20020a634c10000000b00588fa0def2asi4718971pga.778.2023.10.30.04.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 04:51:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZPoFfIjL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id A72B38063CD0; Mon, 30 Oct 2023 04:51:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233039AbjJ3LvD (ORCPT + 99 others); Mon, 30 Oct 2023 07:51:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232976AbjJ3LvB (ORCPT ); Mon, 30 Oct 2023 07:51:01 -0400 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DB0C9D for ; Mon, 30 Oct 2023 04:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698666659; x=1730202659; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4GRBubH/Otb5eL3Hy70mHZ0QZ2wvkq5ML1h3y6fE1CA=; b=ZPoFfIjLOSTCcI6h4z3O/dTzf9S7FxgoQSDo+zooNkSuC9WY41lpwoSa Ym2juzCnvQk1UAvFHd3dGtS1ckgLBxNuLVNko7ODqgLW9NCT2MHIZBMC7 iyvkGgG3qjwKbNzPkGWXK3bflExJ0OAxsYiM47VqeVWiwh5yHN0ouH/NY b2UEr7B4zoIcOCCFlpi8Qj6tF+Mqv4CmlJa+MrlqkA3uEgw+cbfI8nmM7 ro2oQThKseP8tY8tHJwDMyA15nJuXn11iVDAwirIgsRhEEzknbtTMq3gS LOHdMTo3XN3F14AK8ahMkPjrHJ8oDYpLztZNZTBuF223EGDe0lPGCDlzr A==; X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="6688918" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="6688918" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 04:50:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10878"; a="826031142" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="826031142" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 30 Oct 2023 04:50:56 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B431A2BF; Mon, 30 Oct 2023 13:50:55 +0200 (EET) From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Dominik Brodowski , Andy Shevchenko , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= Subject: [PATCH v1 1/1] pcmcia: Convert to use less arguments in pci_bus_for_each_resource() Date: Mon, 30 Oct 2023 13:50:53 +0200 Message-Id: <20231030115053.2752588-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 30 Oct 2023 04:51:18 -0700 (PDT) The pci_bus_for_each_resource() can hide the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Reviewed-by: Krzysztof WilczyƄski Acked-by: Dominik Brodowski Signed-off-by: Andy Shevchenko --- Split out of a series: 20230330162434.35055-1-andriy.shevchenko@linux.intel.com. Fixed the second hunk in nonstatic_autoadd_resources() to avoid potential breakage. drivers/pcmcia/rsrc_nonstatic.c | 6 +++--- drivers/pcmcia/yenta_socket.c | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pcmcia/rsrc_nonstatic.c b/drivers/pcmcia/rsrc_nonstatic.c index bf9d070a4496..39da2ad9d0b2 100644 --- a/drivers/pcmcia/rsrc_nonstatic.c +++ b/drivers/pcmcia/rsrc_nonstatic.c @@ -934,7 +934,7 @@ static int adjust_io(struct pcmcia_socket *s, unsigned int action, unsigned long static int nonstatic_autoadd_resources(struct pcmcia_socket *s) { struct resource *res; - int i, done = 0; + int done = 0; if (!s->cb_dev || !s->cb_dev->bus) return -ENODEV; @@ -961,10 +961,10 @@ static int nonstatic_autoadd_resources(struct pcmcia_socket *s) if (s->cb_dev->bus->number == 0) return -EINVAL; - for (i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { + for (unsigned int i = 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) { res = s->cb_dev->bus->resource[i]; #else - pci_bus_for_each_resource(s->cb_dev->bus, res, i) { + pci_bus_for_each_resource(s->cb_dev->bus, res) { #endif if (!res) continue; diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c index 1365eaa20ff4..fd18ab571ce8 100644 --- a/drivers/pcmcia/yenta_socket.c +++ b/drivers/pcmcia/yenta_socket.c @@ -673,9 +673,8 @@ static int yenta_search_res(struct yenta_socket *socket, struct resource *res, u32 min) { struct resource *root; - int i; - pci_bus_for_each_resource(socket->dev->bus, root, i) { + pci_bus_for_each_resource(socket->dev->bus, root) { if (!root) continue; -- 2.40.0.1.gaa8946217a0b