Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2689274rdh; Mon, 30 Oct 2023 05:07:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcFMNqV+X4Rvg4IXUNQYARo6HtX78LuXzJlRNGAfpgejhW62AfCDqYjqnVnCEbpfVmwXrO X-Received: by 2002:a17:902:ec86:b0:1bc:edd:e891 with SMTP id x6-20020a170902ec8600b001bc0edde891mr15814219plg.1.1698667646825; Mon, 30 Oct 2023 05:07:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698667646; cv=none; d=google.com; s=arc-20160816; b=hAIAzXUDF60dlpF5CW1YCTx2UQVr7aTKiZeH6nYfxff+992MQa3+xZR0Wz1A9FFsiR HiOiCct4vcZ06b/eopXWEtiwp19m9QuRFR99kkQ70UeeIPl+lq93w6Q3lzSA7sLNswry 3h/n/frA8r7GXb6uFMjcqyrmX/ePYrqS/eVNM+nU6L8KIxBm6NNEiyxjPpsXu6RWrAPZ dLhKxJxBsNMU2BTY2MXrFPVsuQ82bjiHBLEHi7SNpqWnXvs+CNMTKby1q7wrFm3rsY54 KZ0/kyWHgaiudjsu+P0q59wktUg+OJM9LqVBxzTLUFClx3wYRH4W4sRRdEfol9Uw15pW Jt9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mAof5WwCREHhgYvZP5oL9OZtxCJg/p8F1Qyqhopa2tA=; fh=gqKJXTWa64Ytf8woqkGRwwWw+4MIcgNdfgfZ6GqOSeo=; b=gpkKJ/EdWRSgRqMPw9XNmikci4XhK5t3cJPHWbvm3EzYWZu7Jlas+D6BGnkghSwMrq dl1Cw70MgNsiqPzaBopJITWiUbZDq/Ib1qDg5i3qhg82wSDcdQNi8uu0eeyIi0Pvot8N dQFuAJVPsDCyDKExOB5mpsn9HJZoNyAQuhGnyAqO6C4oDGhV1KqL3qfBIJZp78zxkAIu 2y91pi3f3jLQoZsI+TPcI75l9Ng7tBnlKM1tw8kJjw9ZwGkK0VUGj3Q61o5V5ro9TeA6 62JcNt2FGzJStw58G2FcUAZ013OTLAjYiXC7QCoO1X1x90JakaTs8/4QBbATRQVwtHdz f1tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=tk6cYUSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id i3-20020a170902c94300b001cc32bdb35csi177087pla.1.2023.10.30.05.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 05:07:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=tk6cYUSb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 8038F80A97E2; Mon, 30 Oct 2023 05:07:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233045AbjJ3MHS (ORCPT + 99 others); Mon, 30 Oct 2023 08:07:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjJ3MHR (ORCPT ); Mon, 30 Oct 2023 08:07:17 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 694A1C9 for ; Mon, 30 Oct 2023 05:07:14 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-9d2e6c8b542so192696066b.0 for ; Mon, 30 Oct 2023 05:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1698667633; x=1699272433; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mAof5WwCREHhgYvZP5oL9OZtxCJg/p8F1Qyqhopa2tA=; b=tk6cYUSbwPm94Sddc5HmcF/6xvZycbisb6NRMHiZRwgedeVomxu3fOpnu6SFB6HRBg MFm8fYFiVFe601gpfhjoylVsQ2emYZ6f3CfjrHGe4iHfAZTlo9gvs7rHC9IZF0i0zqaj jRiW7zPCD0XZUK95q67FEETmOUgJMG27sQ8Ttr2UUvpKNxCReYXBHTWNrxCdUkq2djIu Z9fzGEHsY2rx3rcEXZbPJAAxPYt78Deq2OtFLyKVKKy1Zgbz+VaFT62P9lKdqYH2t7WG O4V8mJIsJzONMWKcHpdZh+55xgav5BYEUCBdB6i8fg1Fw6HAmiEB0XXnRvQtfs+mWHFn C/tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698667633; x=1699272433; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mAof5WwCREHhgYvZP5oL9OZtxCJg/p8F1Qyqhopa2tA=; b=xStc6JpMy0BMJYjhxjHcGGt+BuT5KuX8QEd28h/cd+zjW0fkVNkcBEnuFFnMOA0uOl hsu0Aef00y8rg8voenXvf3XSF6M+GaPTQdt1zXc7OdsUGVB+0EAdei1768M/pEY2zDv1 L1VTLm32GaOvbHLMdKppNUhOHMixxs/O/aHYzGbBcYcTp8W2jICiX7CCCe9nxzxuEusz oWQCZTe5iabYNPYRtvpDYXtFM+vsqKK4DfynrWVBC6RnAKxjF0VTxWfXV304db18+Gx5 5uPYuVl3Or3q0dIDvcCRvFPfrH/rP1C/jhfTI0u+JIHhvntOX44/H9V9e6L9Suj0mEZF AIDg== X-Gm-Message-State: AOJu0YyVh5ikMmkkDXkT+woE1Ye3V2kZ+BlMv6p59L1HKykRHFZoc12W b8WmbM5ZfYfonvxhn0hTxYd2Jw== X-Received: by 2002:a17:907:7f1e:b0:9c3:e66e:2006 with SMTP id qf30-20020a1709077f1e00b009c3e66e2006mr9039051ejc.9.1698667632723; Mon, 30 Oct 2023 05:07:12 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id d26-20020a17090648da00b00988dbbd1f7esm5870031ejt.213.2023.10.30.05.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 05:07:12 -0700 (PDT) Date: Mon, 30 Oct 2023 13:07:11 +0100 From: Jiri Pirko To: Jijie Shao Cc: hawk@kernel.org, ilias.apalodimas@linaro.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jdamato@fastly.com, shenjian15@huawei.com, wangjie125@huawei.com, liuyonglong@huawei.com, linyunsheng@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: page_pool: add missing free_percpu when page_pool_init fail Message-ID: References: <20231030091256.2915394-1-shaojijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231030091256.2915394-1-shaojijie@huawei.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 30 Oct 2023 05:07:24 -0700 (PDT) Mon, Oct 30, 2023 at 10:12:56AM CET, shaojijie@huawei.com wrote: >From: Jian Shen > >When ptr_ring_init() returns failure in page_pool_init(), free_percpu() >is not called to free pool->recycle_stats, which may cause memory >leak. Would be nice to see the use of imperative mood in the patch description too, not only patch subject. Nevertheless, fix looks fine: Reviewed-by: Jiri Pirko