Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
IronPort-Data: A9a23:zyoycaKRhXcLaZuoFE+RVpUlxSXFcZb7ZxGr2PjKsXjdYENSgzZWx
 jRNCGyGbPqDMDbwKowjO4yw/B8OupDTyYI1QAYd+CA2RRqmiyZq6fd1j6vUF3nPRiEWZBs/t
 63yUvGZcYZsCCea/0/xWlTYhSEU/bmSQbbhA/LzNCl0RAt1IA8skhsLd9QR2uaEuvDnRVvW0
 T/Oi5eHYgT8g2Usajt8B5+r8XuDgtyj4Fv0gXRmDRx7lAe2v2UYCpsZOZawIxPQKmWDNrfnL
 wpr5OjRElLxp3/BOPv8+lrIWhFirorpAOS7oiE+t55OLfR1jndaPq4TbJLwYKrM4tmDt4gZJ
 N5l7fRcReq1V0HBsLx1bvVWL81xFfZYqZrID3a9jcKWxWjqUWPh76xrXU5jaOX0+s4vaY1P3
 fUVMnUGaQqOwrvshrm6UeJrwM8kKaEHPqtG5SomlmGfV659B8qZK0nJzYcwMDMYj8VPFuvab
 tExYjt0ZxOGaBpKUrsSIMtmxb/42CGmG9FegGCJt5Bp7C/J9Q8r15fnLMPZWNmJQ8oAyy50o
 UqfrzimXXn2Lue3zTuD72LpheLVmy7/cJwdGaf+9fNwhlCXgGsJB3U+Xlyhq/SlokqhXZRZJ
 lB80jEjt6c/3EyiSt3sWVuzp3vslhcfQ994F+w89RHIxK3J5QqQGmkDSHhGctNOnMs3QyE6k
 1OOlPv3CjF19r6YU3SQ8vGTtzzaETAVLGsGZDcsVhIY6sLjrpp1iQjACMtgeJNZlfX8FCu1w
 iiNtjR7gbwPy8UKzK68u1vAhlpAu6QlUCZu+FTyUUyr7D93YYSAS66w5HSC6KdPedPxoka6g
 FAInM2X7eYrBJ6LlTCQTOhlIF1Pz6vaWNE7qQM/d6TN5whB6Fb+J9sOsWEWyFNBb5xdI26Bj
 Fr741s52XNFAJe9RYlTC25bI+0uyKX6GJzeSvnYBjalSsEqLVLvEM1GS0qdwWfpmU4g+ZzT2
 Kt3k+7xUx726ow+klJaotvxN5dwn0jSIkuJHPjGI+yPi+b2WZJsYe5t3KGyRu449riYhw7e7
 sxSMcCHoz0GDryuPHGLq9VCdQhTRZTeOXwQg5EGHgJkClQ+cFzN99eKqV/cU9U/xv8MxrugE
 o+VAxEGmDITekEr2S3TOiw8N9sDrL50rGkwOmQ3LE201n04CbtDH49BH6bbiYIPrbQ5pdYtF
 qFtU5zZUpxypsHvpm11gW/V99c5KnxGRGumYkKYXdTIV8c6GFaVooC+L2MCNkAmV0KKiCf3m
 JX4viuzfHbJb10K4Br+AB53826MgA==
IronPort-HdrOrdr: A9a23:sOASPaO7b/1mGcBcTrWjsMiBIKoaSvp037BF7StMoHBuH/Bw6f
 rFoB1z73adtN97Yh4dcL67VJW9fQ==
Date:   Mon, 30 Oct 2023 14:57:00 +0200
From:   Ariel Miculas <amiculas@cisco.com>
To:     Phillip Lougher <phillip@squashfs.org.uk>
Cc:     linux-doc@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>, serge@hallyn.com,
        Jonathan Corbet <corbet@lwn.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: filesystems: document the squashfs specific
 mount options
Message-ID: <qgwx4cjswrhzxqijsosix437xyw3ifglv6uz2d3nq7whkjqueo@c5pzoqtoqtgb>
References: <20231029161924.50648-1-amiculas@cisco.com>
 <bd039dc7-cfe5-c210-b65e-0cba3186ee0b@squashfs.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bd039dc7-cfe5-c210-b65e-0cba3186ee0b@squashfs.org.uk>
Precedence: bulk

On 23/10/29 08:33PM, Phillip Lougher wrote:
> On 29/10/2023 16:19, Ariel Miculas wrote:
> > When SQUASHFS_CHOICE_DECOMP_BY_MOUNT is set, the "threads" mount option
> > can be used to specify the decompression mode: single-threaded,
> > multi-threaded, percpu or the number of threads used for decompression.
> > When SQUASHFS_CHOICE_DECOMP_BY_MOUNT is not set and
> > SQUASHFS_DECOMP_MULTI is set, the "threads" option can also be used to
> > specify the number of threads used for decompression. This mount option
> > is only mentioned in fs/squashfs/Kconfig, which makes it difficult to
> > find.
> > 
> > Another mount option available is "errors", which can be configured to
> > panic the kernel when squashfs errors are encountered.
> > 
> > Add both these options to the squashfs documentation, making them more
> > noticeable.
> > 
> > Signed-off-by: Ariel Miculas <amiculas@cisco.com>
> 
> Looks good to me.
> 
> Reviewed-by: Phillip Lougher <phillip@squashfs.org.uk>

Unfortunately, it seems this is not quite correct either:
There is the config option SQUASHFS_MOUNT_DECOMP_THREADS:
```
	bool "Add the mount parameter 'threads=' for squashfs"
	depends on SQUASHFS
	depends on SQUASHFS_DECOMP_MULTI
	default n
	help
	  Use threads= to set the decompression parallel mode and the number of threads.
	  If SQUASHFS_CHOICE_DECOMP_BY_MOUNT=y
	      threads=<single|multi|percpu|1|2|3|...>
	  else
	      threads=<2|3|...>
	  The upper limit is num_online_cpus() * 2.
```
that depends on SQUASHFS_DECOMP_MULTI.
So I think I should take my v1 patch and specify that the "threads="
mount option depends on SQUASHFS_MOUNT_DECOMP_THREADS. There's no need
to specify SQUASHFS_DECOMP_MULTI, because SQUASHFS_MOUNT_DECOMP_THREADS
already depends on it.
What do you think?

Regards,
Ariel