Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2756766rdh; Mon, 30 Oct 2023 06:59:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4rrRc61CfnO1ZkqwCnWpfFZq8RBdjN+aYc3e73nL7bLlekwGda00ciXHorHk+H2H8TLWy X-Received: by 2002:a05:6358:88a:b0:168:e86f:c503 with SMTP id m10-20020a056358088a00b00168e86fc503mr11675156rwj.28.1698674373462; Mon, 30 Oct 2023 06:59:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698674373; cv=none; d=google.com; s=arc-20160816; b=m+HMPFlDC+VtfccWDQPNpqBOJKM43GSI4dUku+2+wfM8VuZNUJvSXwYGDJEAu42ZIG nFBOeJEWrgJ1hSDKWdnA2R86zPUskw2QH/HpW61jCDoLi3ZRpBB7G38A4p4x1naC3pvT rqXY6Bvos4yw1atEzEZxyUDon6+4y29ypW5hp/17V7NtdbaVWqGa6JUOT4UY79ttrGTt XMyUNB4QKsFOFKeBzU4+bZmnho6sH1eJC0OZeNR90BwRij+aknoF4Dp8uyDDyt5LqYxN Ru61CGb0sbEW8pZrOz/xwlwgUaLZ7/bLpAG2EC4zFSbwzPdmspM1bDRp71PjW3KtET1S AkPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=0NY4XozaawuFHk3VmxYZ7aw4aCtED7P43p1V/R2zags=; fh=8+UwUY4S77KDWkMKoQ3g1LbjLBRmHIGqQdlu5cKIx+c=; b=VgaYNVArxXU58LdDmYql9uXft2QMdbl5slP2cQeYl/QMbwnVHD/XVcQOe8wAcyLJPz d6BC2B/T9rQ7NyuJT1Hz6MjxFj04LC2fcCT0lFPmTa5rRc6DVt2M8fWJPOBgjlufSxMw eWsrDp4N/wDBuvQheePmC1Av5lSXgAkqyEJ0+TGBdpCkf5QS7EI3I0aGjT632YYq1hQJ tTA+2ACZqmpaw3BoPd3nn+1er34u3mDO3Ilew35U5K6/idjuSoXsbDx0lZjTtbEPh1SR 3MhZMHaD8JtLtFaPrnE8o7iPfzmKDWsDggEA2uGl+bNymS/79jBc8/lcI5jqrkOfTaPg rEwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id s186-20020a632cc3000000b005aad5164a45si4997557pgs.444.2023.10.30.06.59.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 06:59:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id D188980A1E37; Mon, 30 Oct 2023 06:59:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232853AbjJ3N7X (ORCPT + 99 others); Mon, 30 Oct 2023 09:59:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232118AbjJ3N7X (ORCPT ); Mon, 30 Oct 2023 09:59:23 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1900EC0 for ; Mon, 30 Oct 2023 06:59:21 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25ACFC433C8; Mon, 30 Oct 2023 13:59:20 +0000 (UTC) Date: Mon, 30 Oct 2023 09:59:18 -0400 From: Steven Rostedt To: "Masami Hiramatsu (Google)" Cc: LKML , Linux trace kernel , Andrii Nakryiko , Francis Laniel Subject: Re: [PATCH for-next] tracing/kprobes: Add symbol counting check when module loads Message-ID: <20231030095918.4ec74c88@gandalf.local.home> In-Reply-To: <169854904604.132316.12500381416261460174.stgit@devnote2> References: <169854904604.132316.12500381416261460174.stgit@devnote2> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 30 Oct 2023 06:59:31 -0700 (PDT) On Sun, 29 Oct 2023 12:10:46 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Check the number of probe target symbols in the target module when > the module is loaded. If the probe is not on the unique name symbols > in the module, it will be rejected at that point. > > Note that the symbol which has a unique name in the target module, > it will be accepted even if there are same-name symbols in the > kernel or other modules, > > Signed-off-by: Masami Hiramatsu (Google) > --- > kernel/trace/trace_kprobe.c | 112 ++++++++++++++++++++++++++----------------- > 1 file changed, 68 insertions(+), 44 deletions(-) Reviewed-by: Steven Rosted (Google) -- Steve