Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2765282rdh; Mon, 30 Oct 2023 07:09:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFs/RHoitcccLGo9aWW+81MkHKvD0i8vP/ufQ8In0RoQg7ZQe1UCd5U7udHUdOL+QOLSMdh X-Received: by 2002:a05:6358:e4a0:b0:169:6251:c4a5 with SMTP id by32-20020a056358e4a000b001696251c4a5mr2738920rwb.8.1698674974955; Mon, 30 Oct 2023 07:09:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698674974; cv=none; d=google.com; s=arc-20160816; b=tN89coOK8Bvq5EYDGjjPirNg7lxIqWcFbSXcLl13lK46Djid45/EeoEhvADyPUf8Cn CjI23M8tG8/jk29/1SiHzjyr+8QEqkaTxxuGnwsJJQwusC5QqnyGfGvC0A2/vIQ12Vmf bCOtJe9gSwjfZyJmGJBWZJnLEnvZqmh699oSRa5/G0pAE6Xq7J74SdcLVmmo8awvgRmE dIOgUiY45BYEHOBaxsVOK5qzbXJrWPH2MUBWSNbE2NDq426loHMefPopC1zOMmfOHlvD Wn1eiqyXujOf79c9D40y3kCQ7v5+2FkAwL1LVohfK+Vm/7y7L+BfzCUKFgXZ0nARiRD0 BoRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=pkfb3Xxqzg1KkQukN4M49g9xM/PhVnZv0q/e44iKKp8=; fh=essGK/QsfOBqlMtUT+EYJ8o30wjy4SltnIyFoJAWDNI=; b=hLlUK+0xgJqBSeJJrlgU2fZmnxFf9K7uFBA4y4v1BtZfTevEyf1EHTmLkUauwPig/Z ktRQb8hqeoXOvw0RUUizFD6HehRyzcbfuCgc0mgaU//736QWRPD/Bik0hvdQfp4cTnCh 7o1fUoimYtVcU3+VZ2Ml95A7xORolTuP1irQLKBQ9QmdFcuBmVQ8wSa47KSoXNvhP4Zu rvnPvI/hL8oofINu9YtB/TKugONzO3pMoz253SE3QXFe9k9BmPcQ1IPl7u2pwIYliEmo dmArq8wiP3mKFQts8koOuotiS+HAxgVicwYXJ4MiKShiQ9vqornGkR8wdm1mHm09OrLQ WWlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tesarici.cz header.s=mail header.b=1YGMmxiD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tesarici.cz Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id k6-20020a633d06000000b0058b8c72c5ddsi5048207pga.607.2023.10.30.07.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 07:09:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@tesarici.cz header.s=mail header.b=1YGMmxiD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tesarici.cz Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id ABD6380A235D; Mon, 30 Oct 2023 07:09:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229514AbjJ3OJT (ORCPT + 99 others); Mon, 30 Oct 2023 10:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbjJ3OJS (ORCPT ); Mon, 30 Oct 2023 10:09:18 -0400 Received: from bee.tesarici.cz (bee.tesarici.cz [77.93.223.253]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D900FB7 for ; Mon, 30 Oct 2023 07:09:14 -0700 (PDT) Received: from meshulam.tesarici.cz (dynamic-2a00-1028-83b8-1e7a-4427-cc85-6706-c595.ipv6.o2.cz [IPv6:2a00:1028:83b8:1e7a:4427:cc85:6706:c595]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bee.tesarici.cz (Postfix) with ESMTPSA id BA8DB185D54; Mon, 30 Oct 2023 15:09:10 +0100 (CET) Authentication-Results: mail.tesarici.cz; dmarc=fail (p=none dis=none) header.from=tesarici.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tesarici.cz; s=mail; t=1698674951; bh=X2KI7oEKLIqc0u8nmDx82mYo2XMFiDV/mao3JheM3SY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1YGMmxiDLcAGYfs98smopJCc7B5o2SKaXNDMuMj9l54IVm9vt7RaLQja8dGn3eR+5 JTsRBNvCG2kiTor2j9ZsGeKEkE2bN0YZA+lH0EWfzwSL90uxc3/KyiVXWTohTptx9i vZBN780yjyrpsOxWY/ryUPZsV4bgqTu19acXkCjsw+rkpFCKgvNDotN3qWa1H9ZFsF xkpd54Ojs8/+YRDFBgSo4T+UODHHtqP6T2dZuGRQLHedMddUCdzFeOK9G65j7V8k04 RhhGyxBAdprUFQuXGYHh/XsacV74f36it07jI/j6RUmdnUZ7AGj1bfarS0vE1+qs5x 6FtuIDQZfLDfw== Date: Mon, 30 Oct 2023 15:09:04 +0100 From: Petr =?UTF-8?B?VGVzYcWZw61r?= To: Christoph Hellwig Cc: Petr Tesarik , Marek Szyprowski , Robin Murphy , Greg Kroah-Hartman , Petr Tesarik , "open list:DMA MAPPING HELPERS" , open list , Wangkefeng , Roberto Sassu , Michael Kelley Subject: Re: [PATCH] swiotlb: check dynamically allocated TLB address before decrypting Message-ID: <20231030150904.07a32eaa@meshulam.tesarici.cz> In-Reply-To: <20231030133112.GA22143@lst.de> References: <20231026095123.222-1-petrtesarik@huaweicloud.com> <20231028192414.637bf4fd@meshulam.tesarici.cz> <20231030133112.GA22143@lst.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 30 Oct 2023 07:09:31 -0700 (PDT) Hi Christoph, On Mon, 30 Oct 2023 14:31:12 +0100 Christoph Hellwig wrote: > I'm trying to review it properly this week. It was defintively too big > to just rush it into 6.6 in the last few days. Thank you for the answer. This is OK. Let me give a bit of background. The bug was reported by Michael Kelley to me, while I temporarily lost access to my @huaweicloud.com mailbox. Then I was not able to add him in a Reported-by: header, because this was a private email, which could not be referred by a Closes: header. Anyway, Michael explained in that private email that the threat is more or less theoretical, because environments where set_memory_decrypted() actually does something are unlikely to have physical address constraints for the bounce buffer. But maybe we should add a CC: stable@vger.kernel.org nevertheless. Petr T