Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2791679rdh; Mon, 30 Oct 2023 07:52:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEF1GoXDlJRQZaXEQxbI79iIgkH2QP4L6wY9s7ymPevdcB6zbCSb96D2C0p1P2SUUj/P+iK X-Received: by 2002:a17:902:ecd0:b0:1cc:2c78:65d9 with SMTP id a16-20020a170902ecd000b001cc2c7865d9mr6258884plh.25.1698677551448; Mon, 30 Oct 2023 07:52:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698677551; cv=none; d=google.com; s=arc-20160816; b=0WOZvi8A7leZX7v/WLUQBl1WD0czlQu/UjdQ4rxNIHyk176Ls4QdSOFupsidbrJ184 +iCwGTl6DDzCZ4MJ/6S2aVN5I06OVLSSO136c0Dg8TWU9Cu2311hIEmYhHx1M/7gKZML RYOi9Vq1F/Z7h/XU0jFNcAGARWtw2C09pHSxOTo8udKtKl54bHfb25wTbY+G0qLqSVMB sqYXysHmd2kYkcMADIwIPtg2AIo9FIXKbEmfO3JPRE/yQsuJBarO9ujtE4s+GNHATixc QjDhFYRX3hB9JTP5ckNJRvfnxGfRt3D9tzWQqImd+71lOUpC+0bbT7DJqiYxjyOKI+ps Lf+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=GJq5bgXVmNmvKiogsB2Na6l2XOJypl7t213tMVsC5XY=; fh=UVxr9JucNPK6rwEv+bFfyNa6b2VB6lJc4s9I9OW8eyE=; b=QeJBwDO8cr1cP9SpQ03O/8PQr+cTwQwtLR63Y059b/c3meHKQBH01LYX+fdfjhQVPI JDYC5gltJ8h/VlYiu0G5DeUvr1jM81sFCoi9bga8y9SCc54lDW3Es5Djvl7yNZU/3sBq R7K1rMXWDbXvN7ZMn5GKJgqbAg4jxKVM5gkSp1lhCDb80lgU9TPljIdyESy213hHdmQ4 NE0BqiAl0vLEKv+F6gOLp983DEthuobNADCtcIR81MdtfnHnEJyyCDqHGxImECQPJCZC f2HYvtm9swTUi30YQbxaKW+RcSwTM6KSlzAisNbeFUPiMJvYuVUic/FhJjDXLso1XLqu tbyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id r12-20020a170902e3cc00b001cc5505fffdsi938491ple.644.2023.10.30.07.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 07:52:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0828E809502F; Mon, 30 Oct 2023 07:52:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233501AbjJ3Ow3 (ORCPT + 99 others); Mon, 30 Oct 2023 10:52:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232542AbjJ3Ow2 (ORCPT ); Mon, 30 Oct 2023 10:52:28 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D639CC; Mon, 30 Oct 2023 07:52:23 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 321FD6732A; Mon, 30 Oct 2023 15:52:20 +0100 (CET) Date: Mon, 30 Oct 2023 15:52:20 +0100 From: Christoph Hellwig To: Christophe JAILLET Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v2] nvme-tcp: Fix a memory leak Message-ID: <20231030145220.GA28484@lst.de> References: <7f132cc47e627d63ddb084f3d0fcad10956d1e35.1698677322.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f132cc47e627d63ddb084f3d0fcad10956d1e35.1698677322.git.christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 30 Oct 2023 07:52:30 -0700 (PDT) Looks good: Reviewed-by: Christoph Hellwig > Personally I prefer v1. Pick the one you prefer :) I think we should be consistent with one style or another in a given function. Otherwise I wouldn't even have mentioned it.