Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Mon, 30 Oct 2023 15:56:39 +0100
From:   Maxime Ripard <mripard@kernel.org>
To:     Sui Jingfeng <suijingfeng@loongson.cn>
Cc:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/8] drm/loongson: Introduce a drm bridge driver for
 it66121 HDMI transmitter
Message-ID: <yuh7hs5va54tjzxpcjg35t3mdxhdkufmoo3q3vxxvqkbcegmki@khuaxihfv2i5>
References: <20231029194607.379459-1-suijingfeng@loongson.cn>
 <20231029194607.379459-3-suijingfeng@loongson.cn>
 <CAA8EJprjQXcTgxnC1POaBjVBzyVBvKpmKyJcCR5ExRUhVxtYoQ@mail.gmail.com>
 <3ccb9600-6990-4ec7-81de-0d7b4e1294eb@loongson.cn>
 <CAA8EJpqCe2j3GyeutnwTB0bkGXGk0az9-w3sPHLFwMVgAS=e7g@mail.gmail.com>
 <df176548-0001-4df4-b556-6227b776cd18@loongson.cn>
 <e4ozgwe7g5s3bioywxqcetuqwxk6byvz2lr3swlgy7wutxcxkp@obvvszcgz2qw>
 <9926d2cf-5f92-4f4a-bc4d-423b07e38a3c@loongson.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3na4bddtqnsdu2tn"
Content-Disposition: inline
In-Reply-To: <9926d2cf-5f92-4f4a-bc4d-423b07e38a3c@loongson.cn>
Precedence: bulk


--3na4bddtqnsdu2tn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 30, 2023 at 10:39:32PM +0800, Sui Jingfeng wrote:
> Hi,
>=20
>=20
> On 2023/10/30 21:39, Maxime Ripard wrote:
> > On Mon, Oct 30, 2023 at 09:25:50PM +0800, Sui Jingfeng wrote:
> > > I think my approach provide a solution, while still keep the bridges =
drivers
> > > to a modular at the same time. Despite simple, it indeed solve the pr=
oblem.
> > > It simple because of explicit control of the loading order by myself,=
 not by
> > > rely on the framework or something else (say component)
> > >=20
> > > It is not totally duplicating, I have rewrite part of them. You can c=
ompare
> > > to see what I'm changed. It is just that it66162 was upstream-ed earl=
ier than
> > > our solution. But I also have write display drivers for lt8618 and lt=
8619
> > > completely by myself.
> > >=20
> > > Even though our local drm bridges driver will not be able to enjoy th=
e updates.
> > > We will accept such a results(or pain). I can maintain our local drm =
bridges
> > > drivers by myself. Sorry, on this technique point, we will not follow=
 your idea.
> > > I'm sure that my approach is toward to right direction for our device=
 at now.
> > > If someone invent a better solution to handle this problem, which mak=
e the
> > > various drm bridges drivers usable out of box, then I will follow and=
 cooperate
> > > to test.
> > As far as I'm concerned, the two options are either you reuse the
> > already existing driver or this series isn't merged.
>=20
> It's not that I don't want to use thealready existing display bridge driv=
er,
> It is just that it is not suitable for non DT-based system to use.

The code is there, you can modify it to make it suitable for non
DT-based systems.

> Our system using UEFI+ACPI, beside the I2C, there also have GPIO HPD
> interrupt hardware. ACPI-based system and DT-based system have
> different way to use(request) the hardware. Can you feel my words?

Not really, no. There's plenty of drivers supporting both ACPI and DT
based systems.

> If the variousdisplay bridge drivers are really ready to use

Nobody said they would be ready to use. You are expected to make them
work for you though.

> why I have to refuse?

I mean, you can totally refuse to do whatever we ask. Just like we can
also totally refuse to merge these patches.

Maxime

--3na4bddtqnsdu2tn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCZT/EJwAKCRDj7w1vZxhR
xc7XAP9IxCtEYb2zQLmicNGCaDXghhWwpXmiDNmbg0NxoJnpcwD8CvcunFd0uffN
+wKV4ZyoRME0xCPiOxPfdRozdwbSjAM=
=ckG7
-----END PGP SIGNATURE-----

--3na4bddtqnsdu2tn--