Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2799247rdh; Mon, 30 Oct 2023 08:03:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9xXVFtEmM7b6f8tWziOd2StO8To422RtipY7Ntetua4At/3JzMP0sma0iHEMDX0zKTRfH X-Received: by 2002:a05:6a20:840d:b0:180:7df:76ab with SMTP id c13-20020a056a20840d00b0018007df76abmr4177391pzd.44.1698678189569; Mon, 30 Oct 2023 08:03:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698678189; cv=none; d=google.com; s=arc-20160816; b=e4zl+S6yZjQvLLzoBZgRXmllaa2dn/GKGQdLf2aRnT50plpRFLkqljOWJ4RrVRpx2w CDEMMPPsDo4ixD54kkZ0xM9ZYznIsRbPBIwKEnCiSwwjAoOUynEvwvtLFhuSqs8z3kfX ZTbVMUPkCZok7jvUUMTXijSr/XTI0uUjDaZSmggmDTGihF2wWokr6M6OYCmQcSuatJXn eqjG0e6QG+4gaHFs30M9Yr1Fgg+o9RKdyrU6pcLnBOClvVNMo+pEso4LY84JRyvKmhlm wKLHr0XgTPMIB5X3gQGlatuNpfQTsYvZFMJoDGgDqBf6s/nrm9L/Ldy8aTV8nS2hzOKM NUrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JSWVnBF2dLcqQxv/l5drzVHSE9YKSk6saMu5opCior0=; fh=/0neielfsl6ZaLMzwBL/bkJ1WCpwxpbOe12Zb/vIa+Y=; b=It8100IDVNAR/tZTmu2hLnHDaRMod92OAJmLUch13WugGMuQFw2ycyPeGWA3mAX5Sq 9EtEBFu/gxPn+3eAU8wyH0AWKSCx/MjSql7WH/B2ESVnWcEBUW9xiERzc2qLgvQvOtUu NqXjeaGBNVpAP/D90Q6hGQamYk38bE1qYkmQuzFOdm9SK5gc46olE1X6GArRozf03yWO d2Z7GEMAIhW89j0QBa0InwbkpnYtPwW4ovNRzzYAAV9GtasL3zYWRodLRbUnATQO/PVl PuLYosZM02BGJwPV6A/hPv9jdt9IJXQgtycHE7QbRFsySe7eF41EP69a8UE64maimrmh 8ajA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="b90S/syr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id b22-20020a656696000000b005b92a7d88e6si4935820pgw.823.2023.10.30.08.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 08:03:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="b90S/syr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id E7832809B76F; Mon, 30 Oct 2023 08:03:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233600AbjJ3PC5 (ORCPT + 99 others); Mon, 30 Oct 2023 11:02:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233583AbjJ3PCv (ORCPT ); Mon, 30 Oct 2023 11:02:51 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3627E4 for ; Mon, 30 Oct 2023 08:02:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFC11C433C7; Mon, 30 Oct 2023 15:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698678168; bh=HZ3Ha4rMhluR/cnIvD4+pZKPzbOWuqqbVllRMsRZcNQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b90S/syrmiFfKANW1rMs6SDRfIVVQqjZZxL7UiiJksBYlm9MTD8zenrtE70wqr0BD LhZoBkxLKim2fybQa9nrVdd5MdYlV2aLs7RkJJ5dpNuwayc7Cl7taCAnM7jNRMqG65 FGYfgLunpPsD9xmP8jsRumpV5xXBP3Dw5SwwgHSdVzMqntVNXtvGjrq5ZaxqNiDDaf hAVeFtM+dTqqdhSSHHSkab/Aqzn5PIsqFxwZluHqGFLRsdboDRAiQTXmUmYK8oDzna O8rTWHvU521mPhLxfZwtqqrHiyIYw9+vsEtpHPB6v3OxJ3IHq8AgmRt0issMqOaNQS aUBksnbFS2nMw== Date: Mon, 30 Oct 2023 09:02:45 -0600 From: Keith Busch To: Christophe JAILLET Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v2] nvme-tcp: Fix a memory leak Message-ID: References: <7f132cc47e627d63ddb084f3d0fcad10956d1e35.1698677322.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f132cc47e627d63ddb084f3d0fcad10956d1e35.1698677322.git.christophe.jaillet@wanadoo.fr> X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 30 Oct 2023 08:03:07 -0700 (PDT) On Mon, Oct 30, 2023 at 03:49:28PM +0100, Christophe JAILLET wrote: > All error handling path end to the error handling path, except this one. > Go to the error handling branch as well here, otherwise 'icreq' and > 'icresp' will leak. > > Fixes: 2837966ab2a8 ("nvme-tcp: control message handling for recvmsg()") > Signed-off-by: Christophe JAILLET > Reviewed-by: Christoph Hellwig Thanks, applied to nvme-6.7.