Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <f5562bd4-b278-4070-af79-3dc4a2ef6fc9@intel.com>
Date:   Mon, 30 Oct 2023 08:58:21 -0700
User-Agent: Betterbird (Linux)
Subject: Re: [PATCH v1 1/2] dmaengine: idxd: Protect int_handle field in hw
 descriptor
To:     'Guanjun' <guanjun@linux.alibaba.com>, <dmaengine@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <vkoul@kernel.org>,
        <tony.luck@intel.com>, <fenghua.yu@intel.com>
CC:     <jing.lin@intel.com>, <ashok.raj@intel.com>,
        <sanjay.k.kumar@intel.com>, <megha.dey@intel.com>,
        <jacob.jun.pan@intel.com>, <yi.l.liu@intel.com>,
        <tglx@linutronix.de>
References: <20231029080049.1482701-1-guanjun@linux.alibaba.com>
 <20231029080049.1482701-2-guanjun@linux.alibaba.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20231029080049.1482701-2-guanjun@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkIyaEQ1eXdBYmVPWHpPbFhqbmc4dE1HNEhBaytYemsyMEpWNjJ2RnQ2NG9D?=
 =?utf-8?B?Z044cjhJMmZtcnl5Y1dyWVljV2FLT0F2Y2hJUVdsRThQV2ZMa1oyNHB5Zm5x?=
 =?utf-8?B?UHN1cUd1N1pzKzhzWVBqQkZnclRML0Vmc2VRb1htVzlkOWtzbUZlZlY1NVVr?=
 =?utf-8?B?azdvRjQyU1NZbWI2K2EzLzhyWkUvOW84SjNrTUswTTk5czR0WnZJeG9qY3FL?=
 =?utf-8?B?MU44ZDc3RjN0S3QzT2x5S0Zxc1RKT2tQU0Q1RXRqeXZxUElmZjUyUXY2R0p2?=
 =?utf-8?B?a0hSamtoWldQQm5LN1U1aWJQVFpFUHgwQnltcVlSOE1TRDlYYlB4bFRaZEYv?=
 =?utf-8?B?V0p5VDV5Z092SFJneVR1bkRpcHhxeFFzc0VSV2IvUXlEeWFsaVA2V1NUNmR4?=
 =?utf-8?B?S3ZBRWhLOWtyWXhDYWZQYUtHek9PelY0QTNwRWFzb1dHVzROaHZEekM2Vk52?=
 =?utf-8?B?U0lTZzAyTWNKWk94NlA4bHFYWURWZHlZNHVRMkxGcVZWOGZobXdsbmd6RmU4?=
 =?utf-8?B?Y0JycHlob1VzbGxKdEQwVU9JM1BGNi9sdERVbGw1S2VjYi9ZdmtIYlZYTE8x?=
 =?utf-8?B?K2FQSEtOTHRDWkVsOFdpWVF4R0hIaUk2Y0x2dHUzSTFNcVp5SUtNRXB4T2s2?=
 =?utf-8?B?NjZlZWVSL1RNdzVNaUVrSEIzcnJ4VDV4RTNrQTR5Y0tJMjRDZVFkWnlnZkdE?=
 =?utf-8?B?SnVXaTdwYW9RM09jcUR2amt3Sndkb0YvcWVzOVFEUHRKLzl1L2NqRjNXSHVR?=
 =?utf-8?B?YlFuTE82UTdEME80YTdvZWN5MmpEZGpURXduYzZlY2pxamJsR0ZBS3FRTVRh?=
 =?utf-8?B?UVBHdndvZTAxMTl4M1NhQVU0TlUrRmpmZHJPTzNLa1NxbTFPb1JjSmM2b1NI?=
 =?utf-8?B?QVE2blk3bDFEdmRKQm5QUmtySTRDU2NjeG1tUVpHWGpyWnZndnd0Nytnb0xO?=
 =?utf-8?B?cVZvOEQxUmlPVS9wYldkT0haSjk0NHR4TUZQRWdLK1ZUcEZtNWZBTUJjbURp?=
 =?utf-8?B?ejlMbE9CeXFPODF6c1BRRUNLc3R1RWZoTVM2VHhram5jUFYxT3ozSzBiTWww?=
 =?utf-8?B?eDU4M3JHY1lianMwZWhNN2pad21RTDFENG8weFJGcnhndTdlZmZaSzNSQWZL?=
 =?utf-8?B?NzYvRFJIT1YxNVJLT21jNzlYb2JQaDNla0liRTRpTDNUZlhZV1ZpWXVTYUpy?=
 =?utf-8?B?b1FsWDA5am9qRk42NG1YTEZCamQ1czZkS3NCeHB1K1QyQjN4LzhPOTVvZVN2?=
 =?utf-8?B?WEhtck1yVUxBZ0ZvUXRQWVVEUUJOR1ViOG5oV3NYK1FHdzhlSGpPTkUzdXJJ?=
 =?utf-8?B?RGJJSEF6ZGJQT2ttWFJNeFhBQjlpY0FXTVRpQkpMLzJ6VVIwWG9IMmRnSTk4?=
 =?utf-8?B?dzhTZ201WTlTNXZxbllsTzVGTU05NUJBaXNLWG5KWk9SMUg5S0llQ2VKRURW?=
 =?utf-8?B?V1RlalZiZ1pOZmVPN0V0K3lWcERPcktUdkcxQ0UyVFl5cG1DZlhsU3FJVmlI?=
 =?utf-8?B?NnBxbFc2cnJMVWNsMFZiRSs1VFhxeGQ0WjFLcmZaK1JXYU81ZExNZVdjQVJC?=
 =?utf-8?B?MTdPY05EVzY5cHBlNm1ybXdkamg3OU9QRnlPZ1RLcDZkZFM3TWpUR2lCZkRr?=
 =?utf-8?B?MU54ZVZHZ056enJqMVphN1ZON1QrQWtaR0wzSURPbVFHcGc0R2QzR2djWEdm?=
 =?utf-8?B?VHFkeDFodUd0RTh0MTlHSzJYTFZqL2gvUHVGTk5yRXUwUnJZMlBsMTJybFky?=
 =?utf-8?B?bkd4ZUk0QVM1TkJQSFJjb09WcHBOZkZTVUVsV3lacGtEQXcyb1dwanJTekVL?=
 =?utf-8?B?S0Y4VTRHSllEd0NJemhkY2VaNUtQL2luOFhHdjl6UXYrRDRKeEFSRkd6S2hK?=
 =?utf-8?B?TzVIb1pyOGJlSTZqamlqYzdlT3J4Sy9ZaHdNVmVQeU9MM2piRUk1MDBTdlU4?=
 =?utf-8?B?MVJLdmVEUzNRdm1vV05ORm1QTkRRemdyZDU3b0ZXNDcxS1llUkt3dU5VazZu?=
 =?utf-8?B?dDJQM1R3dFh5WThpbFI5M0gvdVp6VzZ0L04wSUpDbC9iaG5lVmxMRGp0UmZO?=
 =?utf-8?B?TzVPd2dYbCt4dE5NclNiVVlFUjJXaFFaZFQzUnh5dzlMZzhuSHRvSmVMNk1F?=
 =?utf-8?Q?oJ1Eitusium36tMsbRR+LpdDo?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a144196-d1f9-4363-6163-08dbd9610d60
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 15:58:26.6176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DW7R76e0d3tm5oFVIdIuEzrbGskmL7RF+RXGO8WfXpOKPcsEnj+u0OTGGXQIhl3+08Iim9fGjco8i0igW44OWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6938
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 30 Oct 2023 08:58:41 -0700 (PDT)


On 10/29/23 01:00, 'Guanjun' wrote:
> From: Guanjun <guanjun@linux.alibaba.com>
> 
> The int_handle field in hw descriptor should also be protected
> by wmb() before possibly triggering a DMA read.
> 
> Signed-off-by: Guanjun <guanjun@linux.alibaba.com>

Can you please provide a Fix tag? Otherwise
Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>  drivers/dma/idxd/submit.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/dma/idxd/submit.c b/drivers/dma/idxd/submit.c
> index c01db23e3333..3f922518e3a5 100644
> --- a/drivers/dma/idxd/submit.c
> +++ b/drivers/dma/idxd/submit.c
> @@ -182,13 +182,6 @@ int idxd_submit_desc(struct idxd_wq *wq, struct idxd_desc *desc)
>  
>  	portal = idxd_wq_portal_addr(wq);
>  
> -	/*
> -	 * The wmb() flushes writes to coherent DMA data before
> -	 * possibly triggering a DMA read. The wmb() is necessary
> -	 * even on UP because the recipient is a device.
> -	 */
> -	wmb();
> -
>  	/*
>  	 * Pending the descriptor to the lockless list for the irq_entry
>  	 * that we designated the descriptor to.
> @@ -199,6 +192,13 @@ int idxd_submit_desc(struct idxd_wq *wq, struct idxd_desc *desc)
>  		llist_add(&desc->llnode, &ie->pending_llist);
>  	}
>  
> +	/*
> +	 * The wmb() flushes writes to coherent DMA data before
> +	 * possibly triggering a DMA read. The wmb() is necessary
> +	 * even on UP because the recipient is a device.
> +	 */
> +	wmb();
> +
>  	if (wq_dedicated(wq)) {
>  		iosubmit_cmds512(portal, desc->hw, 1);
>  	} else {