Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <6b352a15-5b5e-4773-a32b-8dcefadc1297@intel.com>
Date:   Mon, 30 Oct 2023 09:00:04 -0700
User-Agent: Betterbird (Linux)
Subject: Re: [PATCH v1 2/2] dmaengine: idxd: Fix the incorrect descriptions
To:     'Guanjun' <guanjun@linux.alibaba.com>, <dmaengine@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <vkoul@kernel.org>,
        <tony.luck@intel.com>, <fenghua.yu@intel.com>
CC:     <jing.lin@intel.com>, <ashok.raj@intel.com>,
        <sanjay.k.kumar@intel.com>, <megha.dey@intel.com>,
        <jacob.jun.pan@intel.com>, <yi.l.liu@intel.com>,
        <tglx@linutronix.de>
References: <20231029080049.1482701-1-guanjun@linux.alibaba.com>
 <20231029080049.1482701-3-guanjun@linux.alibaba.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20231029080049.1482701-3-guanjun@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUVvUjcxS05VTGRSekhCT3o4L2g0MFMySXE3SDlMY2NMU21zd1M0SFlaNDgw?=
 =?utf-8?B?Y3JyNUYxRE9VNmZHZ0xLMTQyN24rS1BrVjVFOHdxTDd6M2R3dExlOWdRSWJO?=
 =?utf-8?B?anNBQWhmbCtXMC9NSWZqVTYwUkMzdDFvQjlDaFd0U1lZRGlMUCtUTXNBQnZR?=
 =?utf-8?B?eXcwbmJZa1I3bWtJNGhYcVRzZG1GY2VsUjE0dTJsdndNc0tvMDlzelJEMHdV?=
 =?utf-8?B?TkNGVVJPTkVBbWpTcjJqSVlmZDhucmxIMU4rMGkxV2QvZ2FKTm1JNmNLaGVZ?=
 =?utf-8?B?ZTlmTWtNbngwUzFOa2k5UzBiMVVQSVRaL0tJOWM2empOMWVLdDVyY3JCYTJi?=
 =?utf-8?B?NS9JdkpETHV2alhSSHVBSDZzKzY1cW9GTS81dDZBaHFiaWJ1S3dtZTYxWU5q?=
 =?utf-8?B?N3RDbTFGRnVXZGFTMDMwQ0dDcGRuNFBhaUgrYittK0ZMVDViUFJLRzdhbnRx?=
 =?utf-8?B?THpTenBUU1lVMlVnenBjaHkzVXNrSVNzWE94bVVJTUxZdGhsU0lDcks0aFFM?=
 =?utf-8?B?UVZkS2krelZuNG1lS1hiNjMxcWVjOEo1SXRkNGRZU0owNHc2MHd3SU8vR3dP?=
 =?utf-8?B?MzM2S2d0VE1PZ1dZOHpyZ3NPZjYyUElNd3l6V2NOLzRiRkl2NzJDU2h0NXJS?=
 =?utf-8?B?bERLa2ZLd0tSdkxjN1F2MnVpUXVpQnB5R2hFQnhSa1FRMkpYWmhHeFZMa3RL?=
 =?utf-8?B?VXJsbS9vcXVYcXJuMW5USmtRV3BvSHZLOHU5eFYvSWlhck9PN2tpbnk5RWxE?=
 =?utf-8?B?TjJiZjhsc1Q1SS8xZUR2VEdOS0N1R0UxNEF1WEJtdHRrdnF1cCtqQlB0WEhl?=
 =?utf-8?B?c09FRWxyck1veWJvWWpLbytBQnlHQ285UEgrdCtreGY0ektpb3FmSE9pSGlk?=
 =?utf-8?B?d0FoN3EvL0p2Tm5GMUlBc2FBMUZKWDRvU3AxV2EydTZaU3Q3YkRUOFV6eDFn?=
 =?utf-8?B?VGsybHpkTWVpeDRNY3JUb1VCZnNVMHJCUCtFWnFhMXM5UFdYUkJ5ZHF6SFhs?=
 =?utf-8?B?MXhWeHVrRkxjR0gyNGt3TGZZdFZpMEw4eUliZ05SN01JZUZWNm04NUdmc2Fh?=
 =?utf-8?B?NnhqSHZ1T3FpYjl3OEVzTHM5VHo5OGlQdXorUzhPVXVWY2pqcmxZYXpOeW41?=
 =?utf-8?B?TzU1Yk5EY0w0VHNDcnRMSlBDTjZsS0tQVU0rbk5ONzFsUVhoazRZRzlYUWRL?=
 =?utf-8?B?OUJ6S2hjWS9hdDJSRFJtYkkzbnI2WnZ3cTVGNWxIL0ZsMm5pUTQ4QlhJSEQ4?=
 =?utf-8?B?aGNCV1h2Z0h0OG0yMFc2U0h6RjdmZUVNRldEWkNUUWdmSlRRdkVQMENhYmhQ?=
 =?utf-8?B?cG15SnJzME9hWTg4YmdoaEJuTVpvdXRxbjdjWWpycStSV01oSVZDR015dWRG?=
 =?utf-8?B?N3B5cGI2ZE9QUU8wVzJhME9KZlllZndTV0tZTzU2UFV5OERoazJSUWNPbVlw?=
 =?utf-8?B?SktMRHVqZ1N2dFVnUERCdWRqRi81TFZLdGJDL1NJUVdiMWhUZ3d1L1BDb2Fy?=
 =?utf-8?B?OGM3K1hKTlpaUWpXUmpBTVc2VnVCaE55ZFBCWVlRWDRvM2V6T3B3YnJDZE1n?=
 =?utf-8?B?ckprdXhsaXFpRGNQNFE1clIxZ2FYQ21UYlRBcUJpb1ZYaTlrOENCOTBHcngz?=
 =?utf-8?B?THVnWlhoR0h6Uk80Z1lEU1p3VzAzRDc5dEExUWlVb1dUdW9pNVVlRUxhZGha?=
 =?utf-8?B?VnlpbXZ2VVpDOCtQYTY3R2pPSzNjcUk0MWkwa0o3dDRRN3h3MkQ1WGR2OUZt?=
 =?utf-8?B?WXRwenBrL2Z2TWYvbXR0Q0pXbWNQQXVuRXlja296SU9uUyt6MnVBalJVanBV?=
 =?utf-8?B?aGFEL2E4SlZ3UDU4c0RlOWhRRnZhUzhoMncyNXhyV1VNa0JJeW16d0RkQnh4?=
 =?utf-8?B?Y1JzMEQ2MTMvWE0rVVVwZVoveFl3TG1sWElkSm1tVEQ2TkdtY0hTMloxVTl2?=
 =?utf-8?B?MWNMZUJ0aisyeHlBQjNBV3BqeGQrUFgrVzEzS21KSElJc0hFWkV0dno0NElm?=
 =?utf-8?B?d0JvSythQnAzS29QUGpuaWlEL054SmlnRjZ4eU0valNXQVBHVDRpQ21qNzcr?=
 =?utf-8?B?b25oZGRkT3A1NnpWOVhidWJwRGszRXZGUzJoYkFDZnpzcGxYdVdJamtoZXVH?=
 =?utf-8?Q?/XidFsUploRVQRB4EythKGENe?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cb7f7428-69a8-4c35-1828-08dbd961491f
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 16:00:06.8306
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VyPOYmuE28EcKHTdLRM2n2vqSKXf20zW3dc3dMO+g5bS3gYsPZw/PobDZC7FpiRymmgnXTtkHrNITCWvZ68c8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5115
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 30 Oct 2023 09:00:18 -0700 (PDT)


On 10/29/23 01:00, 'Guanjun' wrote:
> From: Guanjun <guanjun@linux.alibaba.com>
> 
> Fix the incorrect descriptions for the GRPCFG register.
> No functional changes
> 
> Signed-off-by: Guanjun <guanjun@linux.alibaba.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

Thanks!

> ---
>  drivers/dma/idxd/registers.h | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/dma/idxd/registers.h b/drivers/dma/idxd/registers.h
> index 7b54a3939ea1..385a162a55f2 100644
> --- a/drivers/dma/idxd/registers.h
> +++ b/drivers/dma/idxd/registers.h
> @@ -440,12 +440,15 @@ union wqcfg {
>  /*
>   * This macro calculates the offset into the GRPCFG register
>   * idxd - struct idxd *
> - * n - wq id
> - * ofs - the index of the 32b dword for the config register
> + * n - group id
> + * ofs - the index of the 64b qword for the config register
>   *
> - * The WQCFG register block is divided into groups per each wq. The n index
> - * allows us to move to the register group that's for that particular wq.
> - * Each register is 32bits. The ofs gives us the number of register to access.
> + * The GRPCFG register block is divided into three different types, that
> + * includes GRPWQCFG, GRPENGCFG and GRPFLGCFG. The n index in each group
> + * allows us to move to the register group that's for that particular wq,
> + * engine or group flag.
> + * Each register is 64bits. And the ofs in GRPWQCFG gives us the number
> + * of register to access.
>   */
>  #define GRPWQCFG_OFFSET(idxd_dev, n, ofs) ((idxd_dev)->grpcfg_offset +\
>  					   (n) * GRPCFG_SIZE + sizeof(u64) * (ofs))