Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2836388rdh; Mon, 30 Oct 2023 09:02:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDOwILyUNLgSPj/TMCw0FFEiJINvNMYOProxgjXxaFcbLDS+n18Hio0uDaEPXSQEelS7tm X-Received: by 2002:a17:90a:7:b0:27d:7666:d8e9 with SMTP id 7-20020a17090a000700b0027d7666d8e9mr7265652pja.38.1698681731417; Mon, 30 Oct 2023 09:02:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698681731; cv=none; d=google.com; s=arc-20160816; b=kUrBHbzzwa7J2K0u1JCLspQA4ru1ouBxiMQvbMZFN2m7IkJ2lwoLLg1wgmeGF5KitP 3U92yX09YjGMABB5llR6Doy2t4KuVrEyRPpz57r0dva6gXfa5ZSlLLrRuSX+f6l3y96u lYgeuqFIuwctE9eK5qKkns8QUb/1D9f0xajqf6uN1EKPv32CRJxxF/v1c4XbVfp/S23S QPCTQjASmbbdxKn+afsULa/omhbBm2KLN5fDoK4hv4H72dsYFN1yA0zDzWqjHeeOvvUm 15GWLpmA0MRtuwPwpRNCnvLf9B+CN6ZglvRr8radbboj1vkQaYQnhxENMhftWgWdYDLw toSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nStPa6E/oxnnznRXL2kR/Pf4ZBo7bSW5IxW5Esgt9Po=; fh=NnhJav8m0ogAvG6hAId+5RYj12VDvLtLFoqEjL7A7Jg=; b=ZRJng2tM3H2910KllWPt49NcparkXyuKZdGpUk1NIqV37jr4MkH+OC3BD9kZ8433QL goRp14XPknomACg8wiMkYiCZv1biQDqlXWomZoMG++MDqCuaIj+LwwI3dLGV1DgzM0xy teGbk5F5Ck4M/FnT4FH6yCZLao8bvt9HbiiOa8nOwMYU/7gQJlTvC0DmdIJD8x5sB9u/ MABAx0kSA4Ed+YdnANgxnsnX3yhPaWIWuNzLXW7BVpqLjls0N4jdwFIMR6XbUeI2JlV/ LRZrFz31v7c3y2iLQY15jlb3+bdA8ko01iOmyix+z0jlW0A9ZzM5z0nDNxlUSKiGX77K ezVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lIDyueU+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id om18-20020a17090b3a9200b00280708b2eaasi1252628pjb.158.2023.10.30.09.02.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 09:02:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lIDyueU+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7B4AF8077987; Mon, 30 Oct 2023 09:02:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233803AbjJ3QCG (ORCPT + 99 others); Mon, 30 Oct 2023 12:02:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233754AbjJ3QCC (ORCPT ); Mon, 30 Oct 2023 12:02:02 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10D5BF1; Mon, 30 Oct 2023 09:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698681718; x=1730217718; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JWSWeGFuQ2uKtzVehSq0/MF2kVkMz/a2iCsUEOeG8Ac=; b=lIDyueU+MQmDtvlycXtTjHX5LyA0Gtb956qJsZz5EiWtqeqGbthrjuAT 8vEUn6S11jp1ViGc1/c7fhGZig2jcfRH+CYchaBuYPw7S5iQtdwf75T3h BTzNgiugNnxDje18IBR9/wImILoujR+TMiGa2XmxXLzIymbeFpAcCerip ODRb/PoJMe0hk5WWoNyRhFt4iP08XW2/cRpJedYipia0vLERNqk/06Ll+ yKnlCNHHSIilKoX8nHEZxnbGvzsIugPluRryWk6FEDXV6Js2EaEjaZsqy pou6FqLrAGnj8PAIjfNqHFDS/u3Km2nTRtBox7ofYroq6tK/ZsrdYMUZP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="419216698" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="419216698" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 08:59:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="933810503" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="933810503" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 30 Oct 2023 08:59:09 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id E38032AA; Mon, 30 Oct 2023 17:59:07 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Mika Westerberg , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Linus Walleij Subject: [PATCH v1 1/1] pinctrl: intel: Refactor intel_pinctrl_get_soc_data() Date: Mon, 30 Oct 2023 17:59:06 +0200 Message-Id: <20231030155906.3492801-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 30 Oct 2023 09:02:10 -0700 (PDT) Refactor intel_pinctrl_get_soc_data() to drop initial assignment of the data variable. It's only used in ACPI case and instead we may always assign it there as the ACPI ID table has the terminator entry that has driver data set to NULL. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/intel/pinctrl-intel.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index 9b78e112fe60..3e8010607d32 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1660,7 +1660,7 @@ EXPORT_SYMBOL_NS_GPL(intel_pinctrl_probe_by_uid, PINCTRL_INTEL); const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(struct platform_device *pdev) { const struct intel_pinctrl_soc_data * const *table; - const struct intel_pinctrl_soc_data *data = NULL; + const struct intel_pinctrl_soc_data *data; struct device *dev = &pdev->dev; table = device_get_match_data(dev); @@ -1669,11 +1669,10 @@ const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(struct platform_ unsigned int i; for (i = 0; table[i]; i++) { - if (acpi_dev_uid_match(adev, table[i]->uid)) { - data = table[i]; + if (acpi_dev_uid_match(adev, table[i]->uid)) break; - } } + data = table[i]; } else { const struct platform_device_id *id; -- 2.40.0.1.gaa8946217a0b