Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 30 Oct 2023 09:12:53 -0700
In-Reply-To: <20231029093928.138570-1-jose.pekkarinen@foxhound.fi>
Mime-Version: 1.0
References: <20231029093928.138570-1-jose.pekkarinen@foxhound.fi>
Message-ID: <ZT_WBanoip8zhxis@google.com>
Subject: Re: [PATCH] KVM: x86: replace do_div with div64_ul
From:   Sean Christopherson <seanjc@google.com>
To:     "=?utf-8?B?Sm9zw6k=?= Pekkarinen" <jose.pekkarinen@foxhound.fi>
Cc:     pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com,
        skhan@linuxfoundation.org, x86@kernel.org, hpa@zytor.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 29, 2023, Jos=C3=A9 Pekkarinen wrote:
> Reported by coccinelle, there is a do_div call that does
> 64-by-32 divisions even in 64bit platforms, this patch will
> move it to div64_ul macro that will decide the correct
> division function for the platform underneath. The output
> the warning follows:
>=20
> arch/x86/kvm/lapic.c:1948:1-7: WARNING: do_div() does a 64-by-32 division=
, please consider using div64_ul instead.
>=20
> Signed-off-by: Jos=C3=A9 Pekkarinen <jose.pekkarinen@foxhound.fi>
> ---
>  arch/x86/kvm/lapic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index 3e977dbbf993..0b90c6ad5091 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -1945,7 +1945,7 @@ static void start_sw_tscdeadline(struct kvm_lapic *=
apic)
>  	guest_tsc =3D kvm_read_l1_tsc(vcpu, rdtsc());
> =20
>  	ns =3D (tscdeadline - guest_tsc) * 1000000ULL;
> -	do_div(ns, this_tsc_khz);
> +	div64_ul(ns, this_tsc_khz);

Well this is silly, virtual_tsc_khz is a u32.

	unsigned long this_tsc_khz =3D vcpu->arch.virtual_tsc_khz;

struct kvm_vcpu_arch {=20

	...

	u32 virtual_tsc_khz;

}

I assume this will make coccinelle happy?

diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 245b20973cae..31e9c84b8791 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -1932,7 +1932,7 @@ static void start_sw_tscdeadline(struct kvm_lapic *ap=
ic)
        u64 ns =3D 0;
        ktime_t expire;
        struct kvm_vcpu *vcpu =3D apic->vcpu;
-       unsigned long this_tsc_khz =3D vcpu->arch.virtual_tsc_khz;
+       u32 this_tsc_khz =3D vcpu->arch.virtual_tsc_khz;
        unsigned long flags;
        ktime_t now;
=20