Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <bd018335-3b2c-4233-aae3-407e239fd393@amd.com>
Date:   Mon, 30 Oct 2023 11:17:52 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1] platform/x86/amd/pmc: Get smu version before reading
 dram size
To:     Mark Hasemeyer <markhas@chromium.org>,
        =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        LKML <linux-kernel@vger.kernel.org>, stable@vger.kernel.org,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Sanket Goswami <Sanket.Goswami@amd.com>,
        platform-driver-x86@vger.kernel.org
References: <20231027212916.1035991-1-markhas@chromium.org>
 <2b8335a7-4b9b-825-c1b8-84158aaf2c42@linux.intel.com>
 <CANg-bXCcNPjmQC9vgd1JJcV4QoruhhbeEg8o=S9K-22kb746kQ@mail.gmail.com>
Content-Language: en-US
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <CANg-bXCcNPjmQC9vgd1JJcV4QoruhhbeEg8o=S9K-22kb746kQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R25teGc4SzJHNVhNZDdxbXByckJNbVdMd2RoQUExUnp4NGZzdlFCb2FMWWVm?=
 =?utf-8?B?UG8vU3VnbkFkNkJycGtEektFOGhmZVNXQllGQ0NFcXNhVE0wSTZKWFB4RW5C?=
 =?utf-8?B?eDdnT3pCZzJ3Vk5GbmtjQkx4bWlUNXE5c3pRYm16TW9yb3VXSFNWaTN1SUgw?=
 =?utf-8?B?aWYrTzNtdjNhd2Uwc25jY1Z5TEVjc1NRR2RPTnBmNE56a2dwZmxuTGltaDNP?=
 =?utf-8?B?YS9URWVocFZ6L0pVSTJYRlIzREVlODBXYmdyY3lrODdkVkdPQzdRNENBeHl5?=
 =?utf-8?B?elJ4bk5OU3JqVEtrUTNGT0JwMFJGWU00Sm5ZdER5YWZDNGw2TGg3WDdIR0RQ?=
 =?utf-8?B?V0FMdmxQbkhxaGhmMU82N2V5ZGtpeVNOODlOOVQ5UHpKeS9CS3V6N0pvL29C?=
 =?utf-8?B?S24xa2IyM0llQ2ZhTWFGQWVONHNobnNYWjIzdXk0dk9lSzlUN1pUQUtOSnUv?=
 =?utf-8?B?a0ZGQXYwUDRjRWhyT0pJK00rMmR0c0IrUUtwbDVUb1cyT3NIRWhDWlQyeXlQ?=
 =?utf-8?B?bGdnMWlKYThrdUY4OVl1R1FaOG9Tcy9HYzBkL3pCbjZJQzFZVEFRL1pOZG5P?=
 =?utf-8?B?c3lCd1E5SDdRYVRiRFhFVFM2QytGOVcyUFE5RzRJc2FZSkdOS3p4TG1mazIx?=
 =?utf-8?B?TytYVSs4LzdoeFFFeDZnYVdUUzAvdU82TEhpUWRybUJYYkFZMHhZWXlwSzRF?=
 =?utf-8?B?bVQwUTVFMTJjKzNTSDJZNmY0RmVBSGMvc0RjTUxEU3MzSU41QzdDMTNjK2NP?=
 =?utf-8?B?YURNK3NBelpqNmh1MUl1TklvOFRqU293L04rTHR0eTJGVnQ4WW0xL3lndWkv?=
 =?utf-8?B?ZzhVUzhSdlpySU50Sm15TDZYbnJIS094Z0JPWjlJZDUxYkZ4clpFbEFNUFZ6?=
 =?utf-8?B?SXQrQ1BRdHNpa2hRUm1kREFkeE5jU2pYZTFhNnRyYVZJdlJpQXhRajZGblBL?=
 =?utf-8?B?bUhqblVReDVicVdBWkRIakxidVZxRUZxZTZ3aGZPUFpzYWVJaXdnSUY4bitH?=
 =?utf-8?B?ZmYxa29iT0lTRDNVbm9UMCtoQjlNK2tjVGZuWDRpSlAxYVFIU3pLQlk3eGpV?=
 =?utf-8?B?M0xORDlMT3QwdTRFTzBGR3lBVkUxajd0d2h3QW5KL01nbURwaFJUOXFhTzhp?=
 =?utf-8?B?clBtN0JDRXYvakZLQzRvdWlJSkgwb3NiL1JVa2grMExrNzluZDJyMytrT1JW?=
 =?utf-8?B?N1BodEd5Sk5KbElHNWxLdTRwQ1RRTzNIUWRaMzJvVkdaRG4wYlBqT3JRSFRF?=
 =?utf-8?B?NzI3amxNTzkzbEVmOS96YkcrdTV0cXVoa1BSNjlmYVZpeXFLMjdXOFlxTFp6?=
 =?utf-8?B?c0pRTHNWb1puY1BCY2tvOGFENXRkWW5NWXlGdW5tQTBRbndKUjhyTXo3VXhR?=
 =?utf-8?B?M3VnejlwUzk4bldBS0IxNTd2VnpmcUxRWkdIdEptendIWDNrTERvT2dZUUtF?=
 =?utf-8?B?ajZ0NU1sd21YMGdYM0NLdEZ0c0ZURGtrYnlyWUpyY21FaGYzZkpJUWY2Snly?=
 =?utf-8?B?MnVHWlo4UE1FNnhUR2JzbHVRL3YrWXg5SEtlMVYvTklFVTJFWmpEMFNJdXN5?=
 =?utf-8?B?eW8wZC9yU2QwNW9MSkZqZGRMbCtTTml5QTlwMi9hUmhwQ2FwbzAxc2l4eC9u?=
 =?utf-8?B?NnJHdXoyTDFDM1RSWkNBT2poZkIzYlc2ZURVTkxKZzhXNURtRkZHQUg3YVJo?=
 =?utf-8?B?YkZhb2xLOGh1RlBTRURwVWxkNGsrdmxqT3grSnZ0VE1sZVhLVU1BNEloYnAv?=
 =?utf-8?B?L1N2YlJWRm9UaUY1MElkUXAwL0dzRzJhZk5jcGlLZUtFckd5L2hYMjUvM3ph?=
 =?utf-8?B?RFdhVTVXOEkvL0tadnp5Ukl4YXFtTmlZSkhDZzlNUy9jWmFzNlp2Z1k5N3pq?=
 =?utf-8?B?cVYzR09wMHl6blRzWlVJbVdFTXVSRGsxK1pPUHlXbCtlYUZDTUtNUzhVUk9h?=
 =?utf-8?B?TFlvUnk4YWpZM21mdFkybk5pNTZiRTNvd010WEYvQlVIaFdTZmhsNEZPM1ZL?=
 =?utf-8?B?VWtMeXg2NmNVMDBLekdQckpMdHdZd2ZhdTZyUVBRSkt6eXhOZE1RTkZ5NVhE?=
 =?utf-8?B?emMzZTlxRkM3R3YrUnQ1S1pIYzM2Si9NdkRLbFhRMGt1ajdtVnJPbkdCenNk?=
 =?utf-8?Q?CB7lA5WRSb3Bq+htqOHtm9qv2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f1b027a-abae-48a3-0dd4-08dbd963c609
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 16:17:55.2388
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: frH6f6cCwGpdciPRrasLCHP4lH2laBSdYUWfId6SW5UL5bOpoVaXZwIfEWTX+jkIUKtgjYK0IRmn5dYKEgtIsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4908
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 30 Oct 2023 09:18:03 -0700 (PDT)

On 10/30/2023 11:09, Mark Hasemeyer wrote:
>> Hi,
>>
>> Thank you for your patch. This has already come up but no acceptable patch
>> has emerged since. Please see this thread for what needs to be done if you
>> want to provide one (or maybe Shyam already has one which has just not
>> been sent out yet):
>>
>> https://lore.kernel.org/platform-driver-x86/3b224c62-a1d8-41bd-aced-5825f5f20e66@amd.com/
>>
>> (Since this dram size is on an init path that always needs SMU version,
>> the SMU version can just be called by the init unconditonally rather than
>> adding more of this lazy initialization everywhere).
> 
> Thanks for pointing me to that thread. I think Shyam/AMD can come up
> with a better long term solution, but it may be worth pushing this
> patch through for a couple reasons:
> 1. Probing of the driver currently fails on STB enabled systems with a
> Mendocino SoC. A slower boot time is better than the driver failing to
> load IMO.
> 2. This patch only affects Mendocino SoCs, and was a suggested
> solution from Mario in the thread you mentioned.
> 
> That said, I can also just disable STB for now...

It's debugfs.  The vast majority of people won't need to access it even 
if STB is turned on by default.  It should only really be needed in 
error cases.

So how about if the STB init is pushed into the lazy init path as well? 
You can make the files at probe, and then check in their first access if 
init was done.