Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
Date:   Mon, 30 Oct 2023 18:26:34 +0200
From:   =?UTF-8?Q?Jos=C3=A9_Pekkarinen?= <jose.pekkarinen@foxhound.fi>
To:     Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc:     harry.wentland@amd.com, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, skhan@linuxfoundation.org,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        dillon.varone@amd.com, Jun.Lei@amd.com, george.shen@amd.com,
        samson.tam@amd.com, SyedSaaem.Rizvi@amd.com,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] drm/amd/display: remove redundant check
In-Reply-To: <ce1b69e1-fa38-2e12-1ad5-375ac244af42@amd.com>
References: <20231029124404.16159-1-jose.pekkarinen@foxhound.fi>
 <ce1b69e1-fa38-2e12-1ad5-375ac244af42@amd.com>
User-Agent: Roundcube Webmail/1.4.15
Message-ID: <3c228e4f69c01dddd4743bdb68845566@foxhound.fi>
Organization: Foxhound Ltd.
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2023-10-30 15:52, Aurabindo Pillai wrote:
> On 10/29/2023 8:44 AM, José Pekkarinen wrote:
>> This patch addresses the following warning spotted by
>> using coccinelle where the case checked does the same
>> than the else case.
>> 
>> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: 
>> WARNING: possible condition with no effect (if == else)
>> 
>> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
>> ---
>>   .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c   | 4 
>> ----
>>   1 file changed, 4 deletions(-)
>> 
>> diff --git 
>> a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c 
>> b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>> index ecea008f19d3..d940dfa5ae43 100644
>> --- 
>> a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>> +++ 
>> b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>> @@ -4661,10 +4661,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
>>   	} else if (AllowForPStateChangeOrStutterInVBlankFinal == 
>> dm_prefetch_support_uclk_fclk_and_stutter) {
>>   		*MinPrefetchMode = 0;
>>   		*MaxPrefetchMode = 0;
>> -	} else if (AllowForPStateChangeOrStutterInVBlankFinal ==
>> -			dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
>> -		*MinPrefetchMode = 0;
>> -		*MaxPrefetchMode = 3;
>>   	} else {
>>   		*MinPrefetchMode = 0;
>>   		*MaxPrefetchMode = 3;
> 
> What tree did you use to generate the patch? On amd-staging-drm-next,
> MaxPrefetchMode is 0 for the second last branch, which is the correct
> one, so this patch isnt needed.

     I'm using the stable tree, sorry, if it is out of
date just ignore it then.

     Thanks!

     José.