Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp2867523rdh; Mon, 30 Oct 2023 09:52:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEka3+/VGeR72319V5zuHtA3lsE998V0nscZZbD0UQ8DKxbCo2Hosf9Vhob27zAleIi5rsz X-Received: by 2002:a17:90a:9284:b0:280:2406:7021 with SMTP id n4-20020a17090a928400b0028024067021mr5555662pjo.35.1698684777533; Mon, 30 Oct 2023 09:52:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698684777; cv=none; d=google.com; s=arc-20160816; b=cU1bMaT27jDRzRmrrIgKziLjemzEtuSNkFP1+GqeWrFlvp9cd9Yz79Qlfm/VM8RKkQ otdmgyhh7nEQOP+Z/BS7RfCUXqsLeIE2sv71XJUiMCu1ENkjMmAzJJCPEtQBbf1ue4S6 S1SPwr+be+mcp+EeJBuZHLmoGA7nHMVbGnuezy9zOdBF7taGb8/AgXBhjSgVZrxOJyHp Dm/VDrLugO//9+uF37EFfFTKtbc8hQC+86sZR3zd18G7p1c4nc+YMP95k4kBTHh987S+ E8sf16g4DJ8r4JVsyvRG04PN+7HLRi+zgpisFLkzurIy9pNvUzTlOKiZno5CscNzuQYw v2Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=6/BSsNWLspfthFQHwJtcXo2ADTyt8+cC4m6Msvhwdq4=; fh=zHLcHIfUUsQQR0eyCecaHtiUaFVy6dmFGWChOEgfS7E=; b=WUsg7a4oMRWrmugtFjwqcaIzvyRohUPiBtUHgEPUc7hrI3WWE/qpiEVOn0JRikTGpl /WG2mvPSdyM/mqRcTzL4/jv7gdDkRsrgwoz7MlgzhtOwYzNSD0ZR/Hl3ag0YyaEWJDLi S7syNIbIFNTkf9KjezqcK8XKWjFjL8ui/bo/SstR/J83r5HbtMIsfeDXZBbNPlMTCkFl qH1jUsy4+tv8huvY6mqBo+OAgik5wyDS/Lz6vsH0MBcL0Wt670sueWEEDVL36NL+ilES LkoGFPsNPe0Gj1Dzk9pvJ57m+huVGWIa0mc8qJRzwn9PQh4Xvc5zzdKxBxskFuhEpNVM RUvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=RmKSY1ex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id lx16-20020a17090b4b1000b0028074aabfecsi1220989pjb.128.2023.10.30.09.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 09:52:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=RmKSY1ex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3039F80A5661; Mon, 30 Oct 2023 09:52:55 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231395AbjJ3Qwl (ORCPT + 99 others); Mon, 30 Oct 2023 12:52:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjJ3Qwl (ORCPT ); Mon, 30 Oct 2023 12:52:41 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4414B3 for ; Mon, 30 Oct 2023 09:52:38 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-51e24210395so489a12.0 for ; Mon, 30 Oct 2023 09:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698684757; x=1699289557; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6/BSsNWLspfthFQHwJtcXo2ADTyt8+cC4m6Msvhwdq4=; b=RmKSY1ex/z57HODjZlgWtUPt/mxKQbwD1EL/6r4UfBsrrT/QPdqYXOa8Ejw/uvPx/8 LkjYdaWaP85xaCHnWmBWEfs+zGitrFdX4faCefuzYWYwkuluY7R7Pce8VcFbN3GhZ8eb LIv/n0DtluzSoDbg+9E1dlUuokdpbQrYIorPJ91qFnywciAJGUL+Px1Q2XZ0aLCUYmBR ZhBKncA9AWNUeqL2viiwDCttI3ZyIxv2FxzBU6saYExW69XaTeEGsOslPJzLdAPJa3YH MjzCOFr4HUhe2Lvl7ixs1un8F2MYAxJ7oIcIjbTZiqLbHRajmrK41vIqCFdlIWx2w/k8 6fNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698684757; x=1699289557; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6/BSsNWLspfthFQHwJtcXo2ADTyt8+cC4m6Msvhwdq4=; b=iVXv6iW+m/5MyPmbYzoSk12weZxjm5Ji40O5V+/KGUuAM1pE1n8/ZsSEG5IgaseD3T a5n772pJ7bbBQEw4Jq5r1sbhhJuWao8Az4SsjATHdIDnzEvl5fvQYUibCJlExVflftzI JOoOJ+XbdpT5Th1UCiCOCRhBW0g7MGle+Ib4Rtas8g2ehH0R5MYlfoAONKy0cMbS0hqU rnslZNHM9XGb+TKyfJsex7L4zjx4MVIxKYMkpcVsZ/ApAIz1Ufe9E2SiRJ1196Hx4JRp o00kYKfwuW+shJ2Gg6ALp8BJI6bhKqfxh8WMrVqiDI8z5+u1nhYt3CXyJi4MTKldJpNx PNaw== X-Gm-Message-State: AOJu0YxFP2kVxX8fR3CROc+Evctr8r5VkUdf6Gumu/Jqr/ZP6yLD1pla Pd073NBhIX7Y+hAAThEoiWmhd/C3hL//5yX7SH0tpQ== X-Received: by 2002:a05:6402:1a56:b0:543:5119:2853 with SMTP id bf22-20020a0564021a5600b0054351192853mr61455edb.6.1698684756998; Mon, 30 Oct 2023 09:52:36 -0700 (PDT) MIME-Version: 1.0 References: <20231027213059.3550747-1-ptf@google.com> <415e0355-7d71-4b82-b4fc-37dad22486a9@gmail.com> In-Reply-To: <415e0355-7d71-4b82-b4fc-37dad22486a9@gmail.com> From: Patrick Thompson Date: Mon, 30 Oct 2023 12:52:24 -0400 Message-ID: Subject: Re: [PATCH v2] net: r8169: Disable multicast filter for RTL_GIGA_MAC_VER_46 To: Heiner Kallweit Cc: netdev@vger.kernel.org, Chun-Hao Lin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, nic_swsd@realtek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 30 Oct 2023 09:52:55 -0700 (PDT) I wouldn't trust the mc filter, the eap packet being filtered is not a multicast packet so I wonder what else could be erroneously filtered. I do agree that it would be nice to be able to override it for testing purposes. Would you like me to add MAC_VER_48 to the patch? I would not be able to test and confirm that it affects it in the same way I have for VER_46. It is unfortunate that the naming doesn't quite line up. On Sat, Oct 28, 2023 at 4:38=E2=80=AFAM Heiner Kallweit wrote: > > On 27.10.2023 23:30, Patrick Thompson wrote: > > MAC_VER_46 ethernet adapters fail to detect eapol packets unless > > allmulti is enabled. Add exception for VER_46 in the same way VER_35 > > has an exception. > > > MAC_VER_48 (RTL8107E) has the same MAC, just a different PHY. > So I would expect that the same quirk is needed for MAC_VER_48. > > MAC_VER_xx is a little misleading, actually it should be NIC_VER_xx > > > Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E") > > Signed-off-by: Patrick Thompson > > --- > > > > Changes in v2: > > - add Fixes tag > > - add net annotation > > - update description > > > > drivers/net/ethernet/realtek/r8169_main.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/et= hernet/realtek/r8169_main.c > > index 361b90007148b..a775090650e3a 100644 > > --- a/drivers/net/ethernet/realtek/r8169_main.c > > +++ b/drivers/net/ethernet/realtek/r8169_main.c > > @@ -2584,7 +2584,8 @@ static void rtl_set_rx_mode(struct net_device *de= v) > > rx_mode |=3D AcceptAllPhys; > > } else if (netdev_mc_count(dev) > MC_FILTER_LIMIT || > > dev->flags & IFF_ALLMULTI || > > - tp->mac_version =3D=3D RTL_GIGA_MAC_VER_35) { > > + tp->mac_version =3D=3D RTL_GIGA_MAC_VER_35 || > > + tp->mac_version =3D=3D RTL_GIGA_MAC_VER_46) { > > /* accept all multicasts */ > > } else if (netdev_mc_empty(dev)) { > > rx_mode &=3D ~AcceptMulticast; >