Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <02c203a2-7f71-efb9-5fbe-bc753de21ff5@intel.com>
Date:   Mon, 30 Oct 2023 11:56:09 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v1 1/2] dmaengine: idxd: Protect int_handle field in hw
 descriptor
Content-Language: en-US
To:     'Guanjun' <guanjun@linux.alibaba.com>, <dave.jiang@intel.com>,
        <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <vkoul@kernel.org>, <tony.luck@intel.com>
CC:     <jing.lin@intel.com>, <ashok.raj@intel.com>,
        <sanjay.k.kumar@intel.com>, <megha.dey@intel.com>,
        <jacob.jun.pan@intel.com>, <yi.l.liu@intel.com>,
        <tglx@linutronix.de>
References: <20231029080049.1482701-1-guanjun@linux.alibaba.com>
 <20231029080049.1482701-2-guanjun@linux.alibaba.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20231029080049.1482701-2-guanjun@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3grZDczWEQzbzJMRmpDU2pNRzg4Mk1hd2RpQXBPR3IxOVVzK3FTVHdpdWg1?=
 =?utf-8?B?UHdPYjdvQkJnK3NtajhVNmVGZUpENjJ1MGp3aitiYU1iSlNkOVRQRTlEYTAv?=
 =?utf-8?B?UVF5Ulk0MDlEbUVrTGZWLysvZ284aEVJZy90TTRwWnk5V3BXcS8yaEZDdnIv?=
 =?utf-8?B?NWdzUUlPQWZXM0ZGS0hLdVFPQjRPZkdQSGRFVytCT1R0UVVqZTlUTFB6ZzNs?=
 =?utf-8?B?MERxQTFxL2ZKUHBOeFh6eTNPQVVCVzV3RUQrMnNrTktDQXlEdlZDSU1acmlw?=
 =?utf-8?B?amNBTTB1cmt5UkVwODM5WDJlYTh4UzVnYy95KytJeVFqcnJZaGxVTWUrb1FW?=
 =?utf-8?B?OG5CeDczT01yNGlvNGo4cnF5Q3JubkFsR04ralhYNjZoSHBGMytyMk5UWnlP?=
 =?utf-8?B?eC8vQ2RqTWw2eHJzTHNZdk1Gdm1UeWN5ZVU1bXpEeFRSNVhVRnJQKzI0bGRV?=
 =?utf-8?B?bG05YktUWmg2ci9kS0ZUb1pkYzgrM0JYYVhpdTNUWEt2SE9YQ1NVQ0M3QWpV?=
 =?utf-8?B?eHg4UzQxN2NJcXFVcmxUbXlnbG1OejNrMDFPNlJXaU9BeTgyOUVCSGgxRzY1?=
 =?utf-8?B?NHdxUzlDZzA1YlhBQUVXSWQxeW1yN1hySXk5RUJDWjlZWDNLSHl4UDQxNkhj?=
 =?utf-8?B?emlQRTdXcUtBNXRXdzE3MEdrcUVhMjFodlUyNEMvV0dwYmpUeW9vVU5TZjA5?=
 =?utf-8?B?VWZZaHdyWEhpcmsrZytJWnA0dXRaQk1jNVZNZ3ByT2U1REtyWnVGTU9ZZnRI?=
 =?utf-8?B?RXhXQ1RNV3l2QVNCdXhWREFpejlVMEVuVEg2ZEZWcjhLUW9IQ2NSZnQ3YmhV?=
 =?utf-8?B?NFJBVEdrZXFFVnZjQnVPSlU4Z3A0THZqM1hISVRsY1N6ZGxIVGVZZ1hwdE5E?=
 =?utf-8?B?MUorYnZ4eGY4aU45eHFnTDlBdHB3WFdhOWY0SGNEaW9Pd3ZTT24wYXlWWGJq?=
 =?utf-8?B?VG90SWN4YjBEMEp1Y2JGVDRoYWJyZjVxeDd1djZtVU02S0ZPeExYVnBLWTlh?=
 =?utf-8?B?OTlQVzc0MGNxalovWUhjcHJvTGtEanB5NXpBNnUzZExtc3RVNmExUmhKT3Nk?=
 =?utf-8?B?ZVV0T2gzeVIvclpyOGVhM3llNUFYbmZxUHF5dmROVGZtZTNEZ2NrTm4zTFFi?=
 =?utf-8?B?djFOUEN2aWV5UnNhb2JrV2RMSzJIa1RLcXpYUTYrQUlteFpPcm5uT1IvdnVU?=
 =?utf-8?B?b2ZxVDhQOHVVak9TRG1MVGFSWHV6bnlqWW44OEhiZ3RoSERQR1JWUlJ5RS8z?=
 =?utf-8?B?cTl4Y0hiQ040VWEwNG9OVUsrMkYrY3d0R25Xbm4rcEhCUEJCVUZ6QVBxUDJC?=
 =?utf-8?B?MCtuaUYrNWZ4L0g5aFhIcEJhcWtEMms1S3NCV2tBYzFYTk5kTm5IK2F2M2Rp?=
 =?utf-8?B?OENVOUVod1ltNnR0MVMyYjFmUzU1cExjV0ZKKzgzNnJqNk0vVU00QWpHVjdw?=
 =?utf-8?B?cml0d1I2cXVSZittOWxtaElDNk1sa0E5NjBtdTdoc3BOQkZlZFdPYTNwQVVr?=
 =?utf-8?B?QnhsUVU1L1djWEg4NU5RelZJaE1oaFJONmFnaUNiRUxNWE10ekhRM29PdnF4?=
 =?utf-8?B?WEpVVUNkZkZWS0J0amdldnhCNHFIMmw1OFlYTDdWVmZ2ajFnUHA0OHFsaHR3?=
 =?utf-8?B?SWZJcWxNQzhkcWYxTkJFcDZkUU8rTlRwbWtSMDJGdWwzelgxdmpxZzlSN0ZZ?=
 =?utf-8?B?eTRRenh4cmFDN2wrSVNyWEFTbEI4SUxlZU1lVW5NaFJ1RUhRck5FWnpxNVdn?=
 =?utf-8?B?eTNpbWxMeSt1LzU5QUd5cC90VzZvV3Ryam9mL2Zja0hZcFhYZERWR1hqQ2N4?=
 =?utf-8?B?M1hwYTgzK0h5MGl0cFdrMGhFTEtnVkxZK2dsbVFkR01QZE51T0hXRkVkY2hV?=
 =?utf-8?B?SDR6SFpRbWpXRFgwWWFqMDE5UFB2U2VWTktVVUFPV3Nid1pHdHB4TUhLem43?=
 =?utf-8?B?UHpjdkcwMWRDS1NLNlRUZVRveU1KcEpUT1ZHY05Bd0hYdVdZUW5NNStjMHRD?=
 =?utf-8?B?a0o0ZWxZMFVPbEN0T1htREZLQnBzZ3pCMkdha2padzJKbjhCdzFvTzhWS1U0?=
 =?utf-8?B?eExkOHdUOVgzL2FRT2R3OEhuclo5Mjc1aTdCWDNDRm9MQVAybm0zYWI0TEJO?=
 =?utf-8?Q?PRcAR8t4zF2Ub36nhS4ZvaZSJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 349b8b87-7bcb-41f2-5d40-08dbd979e29c
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 18:56:12.2010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W9RFOp9HCIHeCUJSH1Y6h1ZXPgm1jJdMl1Jsi1G+LmElN0YGUanRlwLx1QXxYieyws+aZIUiqW9DcShERmVsxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8377
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 30 Oct 2023 11:56:28 -0700 (PDT)


On 10/29/23 01:00, 'Guanjun' wrote:
> From: Guanjun <guanjun@linux.alibaba.com>
> 
> The int_handle field in hw descriptor should also be protected
> by wmb() before possibly triggering a DMA read.
> 
> Signed-off-by: Guanjun <guanjun@linux.alibaba.com>

As Dave said, need to add fixes tag.

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

Thanks.

-Fenghua Yu