Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <658133e5-922a-b05c-3cbd-cd967f406427@intel.com>
Date:   Mon, 30 Oct 2023 12:20:24 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v1 2/2] dmaengine: idxd: Fix the incorrect descriptions
Content-Language: en-US
To:     'Guanjun' <guanjun@linux.alibaba.com>, <dave.jiang@intel.com>,
        <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <vkoul@kernel.org>, <tony.luck@intel.com>
CC:     <jing.lin@intel.com>, <ashok.raj@intel.com>,
        <sanjay.k.kumar@intel.com>, <megha.dey@intel.com>,
        <jacob.jun.pan@intel.com>, <yi.l.liu@intel.com>,
        <tglx@linutronix.de>
References: <20231029080049.1482701-1-guanjun@linux.alibaba.com>
 <20231029080049.1482701-3-guanjun@linux.alibaba.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20231029080049.1482701-3-guanjun@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWlJRUxIZlpqekgvek4wWjBiTmpFc0hEN2NGbnNiZmhub2R4bzNhV2VZM3Na?=
 =?utf-8?B?a2dLOG1saFEvVVhGeHFjaWdyRDcrOEZLRjVXYzBSaWsvTWdCOXRqQUc5Rjg0?=
 =?utf-8?B?WnducC9mcWFZb1VxRERGeVpMd1VnM2hwMjFiakk3SWV3K0hmSXFDbWpwMXB2?=
 =?utf-8?B?ZlNxUEZ4RHpHWjJlQmFEV29IUEZuWTI4a0l6NUN2Rk12RmgxOFVjcTVMZVRk?=
 =?utf-8?B?MUFWZmtIVm1TeTJLT3FFY2xlUlphSkhLeHRmQUZzdmJGZ0xRZkRMM0tKS0h6?=
 =?utf-8?B?bnJ3SGFWQ1AxeU9uNDkySmJNWWNsRVFHNXg3NVpqclFwSi8zWUNGaFBPVEJU?=
 =?utf-8?B?b2xqR2hDcWgzVjJXSWdReTZyNWxHdlBXNlJ0aHd5QXFMYlRUa2crUCs1N0t2?=
 =?utf-8?B?ZEw3c0VBRWhjVlhLYlg1VlI5ZTFLcng4dGE3WnJWT3UwMnZKTkN4U0duVU5P?=
 =?utf-8?B?U2RsMHJhK2JMNGs3Rkp2UkJNVUZidExYOTVJQ2lxd0g5MjlrdkY0ZWhjQTVw?=
 =?utf-8?B?Vm5uN3dPdTVFbkJvSFVtOXQ2dDdLVC9OSWYxSEtWUnpnTm1RT2VKd2xxenFC?=
 =?utf-8?B?UWFHY21tZjJEVkVsZGd2L3M1TUpkSjVWSTk0NjFkL2w1RnJIcGc1bjE0a2RC?=
 =?utf-8?B?N2tRVGMraHZOK2M0MTNxQXJHM1hJb3N1Nk1COWRVNWJ2NVdMeXlNMzZWYVVP?=
 =?utf-8?B?OThMZy8rNDNUTDZRLzNucG1YWnVydlVlL21CZUZPempjbDRXSmQxeDl6K3kz?=
 =?utf-8?B?bFIzNFpHM0c1YVJxZVVSUm5sRHVzZXg3ZGEzT2h5WXBZQjhhTlVoVnFkUTNt?=
 =?utf-8?B?N2lpbFpBWXlvQWpFdnJ5K1ZKRHFkSis5QjJjWCtqNCtKczVocjFjNG1DVEVz?=
 =?utf-8?B?MHRkc3dLYUJ1L0oxZ1BxR05ObUdNdXYyMlBGOURKNE9ZWWE1aGEyT2RPUzM2?=
 =?utf-8?B?RUtDZllZRTVYaHgxTktRSlFRZG91ajIxUXVSamUxRlY1elp4cFFDaUo0d3dN?=
 =?utf-8?B?QTNISGlrYTJOYjZwcUdNSS9aOEN2UnJDeElXeGdhUnB1bEk1SXdzejFiMW80?=
 =?utf-8?B?S1lDQ01yQzkyZkJUdWQydlc5ZmwrTFZWc0ViMGdFbGNpNGtMcGRtUUJKZ0Nl?=
 =?utf-8?B?cHo2QWV2STgrVERUY1dBTW42VnptOHJ2M0s2OTI2WlFFakVQbUxPWlNrTk1k?=
 =?utf-8?B?QzEzRDZtZDMwTlRGTUdPNVhDRXpsMEFZVFJxQnV4MWtuM3BadGVnOVR3dHor?=
 =?utf-8?B?U2VrNUNmMDNpdlJZdmdVL0FzS05jT0dMY1laUWtXaThpeEVoK1hTWWNMU3Bi?=
 =?utf-8?B?dEl0T01nTGMxNGtPazk0SDVvRHpMT1hDdUFMdkUvWHFrSmN3MFBnVkk4aks3?=
 =?utf-8?B?dDRGNklWZVg1ektNaTA0b3ppOWExRnQydHh2cm4razR5NzY3RDFKdnc1Q1Y5?=
 =?utf-8?B?eW55L3BvZ3NGa2FtVlNLbk43MEpaUkFMLzBjRk5iTWhQV0RlOUZkRnNQb0dW?=
 =?utf-8?B?c3hCN2Voa0tsVzV6TGxhSjRLNjN6Mk1yQ0p3ZFBoME1JZWJiQWV0WEwvV3hy?=
 =?utf-8?B?Rk8xU1I2WWVPM055cFNFN1NFZzhGeUFORU9DOEZhV0o3UFJpM1Y2L3o4eVox?=
 =?utf-8?B?akplbnJldnMzMHN1d0Y2c09uM0laSXVKU3kzTExrT1VkK3RsemE1WjZISGJM?=
 =?utf-8?B?RTZ5WUtqUmNVZWRHOG9WZUNQOSt2M1o4Q1dTZHBIRjlpMGJzUzA4R1JvNlpo?=
 =?utf-8?B?Sk03OWJaQ1d3eHpJWE5EL3p4RzhLQ1VKNGIwRW0wZXM2ZEczeVBIVGZDTEhF?=
 =?utf-8?B?WkxPeVNHZCtzSzRaMjhnejFzOWFSc1VRMXM2UDFHWkczU2E4UU1hWWtFTnpy?=
 =?utf-8?B?cVdZUGc4eTlhY2NDeStBR0svb01yQSt4aWpGNTI3ankvbmxNaVFkMHU3OWtC?=
 =?utf-8?B?Zkwxekx3MDJYalpMQzI3UGN2ODh2Ymd3aklFRDl6MzlheS80SG5Sam0yYWZV?=
 =?utf-8?B?bXIrdHk2VVRVZ3RiV0hwZmorc24waTk5LzhmOHFOeXVCN0NZTVNvRGQvcnpO?=
 =?utf-8?B?T1d4Tk56WEFjZnlmRTNBVXV2enFFbUt0ZGQ1WHNnOUFaOXNRZnh6enRrSEVa?=
 =?utf-8?Q?zFZD5q+rA8TOn9CXaqYy9oXMT?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5393c70f-1ca9-4f09-4d9f-08dbd97d45d9
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 19:20:27.0741
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f+9n4bau99EcDhiw/YdbnQrXAgstOkZKOqlUEr15KT/bwqsKZALNgyklJzrBXACak0fcoFK4bjRQW5fkcmyiCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7963
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 30 Oct 2023 12:20:58 -0700 (PDT)

Hi, Guanjun,

On 10/29/23 01:00, 'Guanjun' wrote:
> From: Guanjun <guanjun@linux.alibaba.com>
> 

The subject may be changed to:
dmaengine: idxd: Fix incorrect descriptions for GRPWQCFG_OFFSET

> Fix the incorrect descriptions for the GRPCFG register.
> No functional changes
> 
> Signed-off-by: Guanjun <guanjun@linux.alibaba.com>
> ---
>   drivers/dma/idxd/registers.h | 13 ++++++++-----
>   1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/dma/idxd/registers.h b/drivers/dma/idxd/registers.h
> index 7b54a3939ea1..385a162a55f2 100644
> --- a/drivers/dma/idxd/registers.h
> +++ b/drivers/dma/idxd/registers.h
> @@ -440,12 +440,15 @@ union wqcfg {
>   /*
>    * This macro calculates the offset into the GRPCFG register
>    * idxd - struct idxd *
> - * n - wq id
> - * ofs - the index of the 32b dword for the config register
> + * n - group id
> + * ofs - the index of the 64b qword for the config register
>    *
> - * The WQCFG register block is divided into groups per each wq. The n index
> - * allows us to move to the register group that's for that particular wq.
> - * Each register is 32bits. The ofs gives us the number of register to access.
> + * The GRPCFG register block is divided into three different types, that

s/different types/sub-registers/

> + * includes GRPWQCFG, GRPENGCFG and GRPFLGCFG. The n index in each group

s/that includes/which are/

> + * allows us to move to the register group that's for that particular wq,
> + * engine or group flag.

s/that particular wq, engine or group flag./that contains the three 
sub-registers/

> + * Each register is 64bits. And the ofs in GRPWQCFG gives us the number
> + * of register to access.

s/the number of register to access/the offset within the GRPCFG register 
to access/

>    */
>   #define GRPWQCFG_OFFSET(idxd_dev, n, ofs) ((idxd_dev)->grpcfg_offset +\
>   					   (n) * GRPCFG_SIZE + sizeof(u64) * (ofs))

Thanks.

-Fenghua