Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <754f3c29-cfac-243c-d280-0cc84ed36ccb@intel.com>
Date:   Mon, 30 Oct 2023 20:23:44 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v2] ALSA: hda: intel-dsp-cfg: Use AVS driver on
 SKL/KBL/APL Chromebooks
Content-Language: en-US
To:     Brady Norander <bradynorander@gmail.com>,
        Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
        <alsa-devel@alsa-project.org>
CC:     <linux-kernel@vger.kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
References: <2f5ffc3b-01be-413d-843e-8654d953f56f@gmail.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <2f5ffc3b-01be-413d-843e-8654d953f56f@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGhGWFZzV1JvOFdSaUJXNDY1QXVVeURoSXhjR3FVajcrQkpacXBXTmNTVDVR?=
 =?utf-8?B?dUFSblN0N1B1RDM4S0NyOEpvYTl0NGlUMnFJNzBVTnpnN29wdVpyNkZvY1Ji?=
 =?utf-8?B?ZVpacDBwbmhNK2ErTWxrMC9KRTQ2TTNNUHZBWXpiblFTKzJCY3gvdVc0eHJn?=
 =?utf-8?B?YXNXRDJtcVZKVi9uTldGNG41Qk1rVnhSWmk4UVJZbDg4aDVYNitqS2NrSkhl?=
 =?utf-8?B?S0FHSndjWjBSVnJPaHdEc3FXSDJ0c29DSDhUMXRTby8wNDZ2ZDFRb2VsTlVO?=
 =?utf-8?B?VUpjV004QzF5OENaeWc1SjBidGEzSC9IWE5nV1NtaGYxUmg4UndxbmtIS29Z?=
 =?utf-8?B?MWJhU3Z2THpJSmoyL1dqRlZ0QXlON1ozUisva0loeU1yUkFEKzFmcktGb2ZS?=
 =?utf-8?B?L01EZ3hmWjVRSHhJenljYVFRU0ZDaW1CZGU1UW5paC9wYjdrNGJzQi9uUGxX?=
 =?utf-8?B?bDhRalc1MjNpdnlXNS9MS0tUR0F6SEc2bTNHR0sxc2lQNFBzelFWbnR0SnNK?=
 =?utf-8?B?Z3NzWUYxd1prdmtPYXN5Mmh2VjV5MmxOM2tqeHgxNXJiV1hqOHNuenlob05G?=
 =?utf-8?B?VldLS3lkVUErdWcxZWNuRE5xRmp4ZmVGWmlhRGhyTEsvZ2c4R0xXa3RFZTdu?=
 =?utf-8?B?b3o1M1VPcldyNzdvQjJWVTdyT2FPbDdzN0U5Qk9PSXB1OG9nSUFmMitRa25k?=
 =?utf-8?B?TytadUJZaDREcjJqaERFOWxJTmU3blZkRTdyNU9tdjVMVHQrc29kazNRbFJn?=
 =?utf-8?B?QzJFNFhYOE5tcFBPRXp5ZTVVQnlXOEdHekNMTVdlckZFYlI5ME5jc3FydzJL?=
 =?utf-8?B?a3Z3eHZ5OC96dkdKZTVGWWw5VVN6Tk9Rcnl6a1A5bGFJNG0zMnM1bDBlWDVT?=
 =?utf-8?B?L1IwekU5VzhxdVJZNUtmV0ZUMWxWU2M3R2hWYmMxME9ETmRqUTZGcmQ1MTAx?=
 =?utf-8?B?eVAranduTWhJV0d2bFV6a1VueWtXTFBCdnhTWjI4OVAyRU0xbUNrYnhUNGpD?=
 =?utf-8?B?MlljeVlJWmhkVEd2bXVMaDMraVF5b0Q4M0E3ajVzUnJqYTlzRERVdVpGemZp?=
 =?utf-8?B?OWhER05EdWJrMlBidHpQdjJGSlY5blVQUitHQkdGR2NCd1BJR0JpcEhIYUNU?=
 =?utf-8?B?N1FvSFN3ZmoraVBidHkxQ3MxSXNZSlFiT1E0TzdwY1JTb2Y5cjViQUVJR3Yx?=
 =?utf-8?B?c3h4TFA4WEZvRWYyMmJLRWdaeVMwVzVmTDZqbXNWc1h6VFoxRHNSd0RpcXlh?=
 =?utf-8?B?Nm9kVjlmU3FhZmhScDlVOFRqb1JkRnZsZXlqbkhBU0k1TnJQTklSbFR6bkV3?=
 =?utf-8?B?Tm1zdmtHd2cvOVB3Qi8wTTByeHU0ZldCNDJpeUZYZkdGa1pUY0JmNkRhTDlt?=
 =?utf-8?B?MUcwVmhYd0hnNDhWSnVVclFuUVNGdHJRVjB1Vi9WdHJ3NjBiRmVHV1NjM3A0?=
 =?utf-8?B?blZBUGRFNitrZ1V3TmMvbThLWkJkdDZKK1lJdTFHYzNxaytJZ3B5YytHeHhm?=
 =?utf-8?B?a0tkSFYvR3hMK2pCWHF0SW5VMFdXVFZ1TlkzUmtmNWRaUGlXMk5PSE0xNVVP?=
 =?utf-8?B?bmpJZE9jSTNLL3pLMEJxRGN3Y1d4Um02S212ZXJFaVhWbGZtR3JRbTBjNmVo?=
 =?utf-8?B?ZVhvK1VDeEdUZU1hc2lNWk55T0tUY3Ird1Frenlrc1kwYkN6c2drSFM0d09t?=
 =?utf-8?B?eFVwNTUxS0J2QnN1czA3elUwNVNBbkVtTHRJY3ptN0xPOGhUNDlkblY1WXZs?=
 =?utf-8?B?S2lTZVFLaElrYnRURFpYZWYzVVd4d2JYK1Q1QmdDeVc4ZTVBUDgyTHhueUF0?=
 =?utf-8?B?VEZTQUlJOFdPWGVqbElGVWJwYzVQZDBiaWZuOHl6TmZscHpQeGQvM0l0YlB5?=
 =?utf-8?B?OFgraVRBWCtOMXgrL2ltakFXRWhVRTBMTzdmOTBRem1oQTJ2U3M4RWNVNEhp?=
 =?utf-8?B?dDhOaDZTYjBmV0poL1hXZitrcDB6Lzk0MU93OXZPeklxUHFmd1VXa09pVk9D?=
 =?utf-8?B?VGVZLzBwbW1LZWhCZ1FsRGpGMlVMREp2b3NFeHBOeGp2RlhwV1BCeGtsREJ0?=
 =?utf-8?B?Tkg3a3d1TDY0OWw3cUduQ1FKZVFSS2FxTGVldHZUTmlnSTg1QXNRaTkvQnJJ?=
 =?utf-8?B?UkxwcDBTeVBBR0IxbDdTdUsvOW4wUlVOdUQxcmxWNE5Ya2MyaVcvYmZZQUEz?=
 =?utf-8?B?eXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ee7c5dee-0f11-4498-5469-08dbd97dc034
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 19:23:52.4663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: djQUWsCA2xBKAWEVT6MTVVe/d4BivfR3r93ubXB+fBU4h84PzbS/AjxXEc32u1U1oYq/mGLoZkQWMK9+DZxte7uya7x5Pb9sjbeA5f/gDQ8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6497
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 30 Oct 2023 12:24:07 -0700 (PDT)

On 2023-10-30 7:58 PM, Brady Norander wrote:
> The legacy SKL driver no longer works properly on these Chromebook
> platforms. Use the new AVS driver by default instead.

Hello,

Thank you for the patch. The code looks fine but it will cause backward 
compatibility problems on driver <-> topology line which I'd like to avoid.

There's an ongoing discussion regarding 24/32 format support for HDAudio 
drivers which is currently incorrect for all Intel AudioDSP drivers. 
Until the discussion is finished I'd like to avoid switching. While the 
avs-driver deprecates the skylake-driver since v5.4, the topology file 
package is not yet part of any official distro release.

I've high hopes to finish the process by the end of November. That 
means: driver code gets updated to properly represent 24/32 format AND 
the avs-topology-xml repo [1] receives equivalent update making it a 
candidate for distro integration. I'll bump this patch once the process 
concludes.

[1]: https://github.com/thesofproject/avs-topology-xml

Czarek