Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Mon, 30 Oct 2023 12:25:19 -0700 (PDT)
From:   Christoph Lameter <cl@linux.com>
To:     Chengming Zhou <chengming.zhou@linux.dev>
cc:     penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
        akpm@linux-foundation.org, vbabka@suse.cz,
        roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [RFC PATCH v3 0/7] slub: Delay freezing of CPU partial slabs
In-Reply-To: <1199315b-63ce-4be4-8cde-b8b2fd29f91a@linux.dev>
Message-ID: <7f70d130-c05a-3cb7-9509-41c21c3014fb@linux.com>
References: <20231024093345.3676493-1-chengming.zhou@linux.dev> <d5e40e42-ad02-e53d-c38f-09a4fdf1be88@linux.com> <1199315b-63ce-4be4-8cde-b8b2fd29f91a@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Precedence: bulk

On Sat, 28 Oct 2023, Chengming Zhou wrote:

> 2. But for full slab (slab->freelist == NULL), PG_workingset is not much useful, we don't
>   safely know whether it's used as the cpu slab or not just from this flag. So __slab_free()
>   still rely on the "frozen" bit to know it.
>
> 3. And the maintaining of "frozen" has no extra cost now, since it's changed together with "freelist"
>   and other counter using cmpxchg, we already have the cmpxchg when start to use a slab as the cpu slab.
>
> Maybe I missed something, I don't know how to drop the frozen flag.


Maybe frozen is now = PG_Workingset | cmpxchg-frozen?