Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20231024134637.3120277-1-surenb@google.com> <20231024134637.3120277-2-surenb@google.com>
 <ZTfUCiFP3hVJ+EXh@smile.fi.intel.com> <20231024194653.c24qbnk6bx3hep6y@moria.home.lan>
 <ZTpl1ELUMEmne21U@smile.fi.intel.com> <20231026184456.q6ocnmpq6jhqi7zi@moria.home.lan>
In-Reply-To: <20231026184456.q6ocnmpq6jhqi7zi@moria.home.lan>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 30 Oct 2023 22:07:43 +0200
Message-ID: <CAHp75Vch5U=F00i0yB82XRU2504pUUEUu1YvBPbiU=FRbJ9FJw@mail.gmail.com>
Subject: Re: [PATCH v2 01/39] lib/string_helpers: Add flags param to string_get_size()
To:     Kent Overstreet <kent.overstreet@linux.dev>
Cc:     Andy Shevchenko <andy@kernel.org>,
        Suren Baghdasaryan <surenb@google.com>,
        akpm@linux-foundation.org, keescook@chromium.org,
        rostedt@goodmis.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Oct 26, 2023 at 9:45=E2=80=AFPM Kent Overstreet
<kent.overstreet@linux.dev> wrote:
> On Thu, Oct 26, 2023 at 04:12:52PM +0300, Andy Shevchenko wrote:
> > On Tue, Oct 24, 2023 at 03:46:53PM -0400, Kent Overstreet wrote:
> > > On Tue, Oct 24, 2023 at 05:26:18PM +0300, Andy Shevchenko wrote:
> > > > On Tue, Oct 24, 2023 at 06:45:58AM -0700, Suren Baghdasaryan wrote:

...

> Andy: to be blunt, you've been pretty hostile and hysterical ("breaking
> the kernel!" over debug statements? really?)

Where did I say that?

And instead of judging me, look from the reviewer's and maintainer's
point of view. The patch is unreviewable and has not good
maintainability in this form as it does a few things at once.

Also the commit message is poorly written as it has no mention about use ca=
ses.

>  and the bikeshedding is
> getting to be too much - I'm just going to drop this patch from the
> series and we'll post process the output as needed.

I don't think I bikeshed here too much. This is the regular asking the
reviewers and/or maintainers usually do, so is it too hard to split?

--=20
With Best Regards,
Andy Shevchenko