Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <cfc9f863-dc07-7c23-7621-d2dc115651bd@amd.com>
Date:   Mon, 30 Oct 2023 16:00:03 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v5 12/14] x86/kvmclock: Skip kvmclock when Secure TSC is
 available
Content-Language: en-US
To:     Nikunj A Dadhania <nikunj@amd.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org, kvm@vger.kernel.org
Cc:     bp@alien8.de, mingo@redhat.com, tglx@linutronix.de,
        dave.hansen@linux.intel.com, dionnaglaze@google.com,
        pgonda@google.com, seanjc@google.com, pbonzini@redhat.com
References: <20231030063652.68675-1-nikunj@amd.com>
 <20231030063652.68675-13-nikunj@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20231030063652.68675-13-nikunj@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlNIb1UxeEsreUwzRGkvWlUvQmlNbk5LNDhZNjlGenptV3B6SjlsTm5HZXBJ?=
 =?utf-8?B?NVIxRzdkR3U4Q3lRQ1liYXI5Qi9Ya0F4QTkxSzlCc0NoRXAxdTR5QUF4NjdS?=
 =?utf-8?B?dHR5U3FFZ3FCSW9VWGVodUFIQ1M3ZDZDckFRS0pxUWFLdytVVnFVUjNueDJw?=
 =?utf-8?B?QmRCRS84bG5kV3VjOUdYRDVXQXlSRXlyVXl3M3NuaVU4Q2wrMWkzRE9NNGt5?=
 =?utf-8?B?NUdUOUhnbC9Kd0p1dTRZK0VZMXMxM05HUlhkbEhPVEE3RzUxSGh4UDBpOWZs?=
 =?utf-8?B?dGhldUVZQTlhM0pGRlBqMk84NUtQNVk0WkRhemJjVzg1d2tMeDZzRTA3Ujdz?=
 =?utf-8?B?U1ZLZDN6SXU3NThNb25LcGMrSVZXdWZRVkpGK0V6NzExYXVEUEtocElERWZw?=
 =?utf-8?B?ZURZUnA3cEF6RVNRcWFLWU5MU0NEUDNBb2JiWU1PWWFUL0tINkZwdkNOWHZx?=
 =?utf-8?B?VElNenJ4N3o3ZGJ3THg2OCt6dWxSZUM4NjB6T3NxS0tlcUJJcXNNajR2Yzht?=
 =?utf-8?B?L25zZHgwR1JtbHllQ0ovNjZObmRzSk9iRDBhZm1hSkZKY2ZLWWlSUjVWNnVF?=
 =?utf-8?B?NEJSRG1ONXFXZnJMRDJ6SmF6NEJDK1kvdHhXbHFuSUx1a3hVMlM5RTVhTVZ6?=
 =?utf-8?B?NmRIeEZGeHdvcXQrS2o3VXNxckhVZzNsQnNlZnJ2US9STCtoZ00vQjJJUkhm?=
 =?utf-8?B?Q3d6cTdhS0habTdsY2xOdmZSUVNkbzJ4b2J2VE9HS3ZtMVpONmt0ejMwM1lY?=
 =?utf-8?B?bjRoL2VnbnVmSzVrVzI0SnBOOCtXWmt2TlNQTWJSYVFpQWVWY2lMVjhFZkRv?=
 =?utf-8?B?QXpPUTZZMW9XSDBvaW1vdlQ2Wjl1ZTMwY1hxKzJnMUtHeTdvRkhzNXFQM2FY?=
 =?utf-8?B?RFdYbnVRdUhBT2JlYXA1b1hwYkFEUmZkVzdMSzZhbFBnczB3RDZLMUhFSGVn?=
 =?utf-8?B?eXpHSHUvTlBlTXBZK3R6MHYzemUzZVBsM2FQUHM1WUVhdXErVVVUVStDT21W?=
 =?utf-8?B?Z3ByYnZIT3Q2ZEFwaWEvZktjUFJvR2trbWs5c0x6NlRVNTVMWU8xdVI2d1M3?=
 =?utf-8?B?NmFQUnVrQnVtWExYaEtjcmhnT0tRRW5xNXVhcnprOTFGT21uUkFiR3JJRk15?=
 =?utf-8?B?R3ZEdXl6dHZnLzQyRncxMFYrQTJZT1Frb1ZnSjArWEJ1Vm9meURpQ0F6OXRN?=
 =?utf-8?B?THlSYytRU2dTb1plTmtWY0N2SDUxclRDN1labVduMnVtK0dOU2FiNmY2dlY5?=
 =?utf-8?B?c2xkb1Rxd0Q2YVBQb08wUlBCNDg5RG5KTDBzVjBDSEs4a2YxYjRmRWhnajd5?=
 =?utf-8?B?MmIzZWtiQXlJUmIzQzlla29UZ0JuV1MydHFMdkFLSjVCNzgvZEpIQzk4SThE?=
 =?utf-8?B?UXNFcDRkbjBicitpSWhzVmtTamMzNWxKSEJyMEcrcVZuK1BDd3AwQ1ZuWE5C?=
 =?utf-8?B?YzlhR2FiYzZVY0txZmpzbzJheUpPKytLbyt4WXJ5RGFqbzFIVGJBdGxBWHlk?=
 =?utf-8?B?R2Yzb3dTQzN6VFY1elEzQUhCY3Nkbm1qVlREajlnRnVIQlRDdGNrVTY3RU5u?=
 =?utf-8?B?S29VY3labE5DVHd6Ty9ZUkFNSW55N1JWcHlZTkpiZmhlbkFKeURVcDh4NzhL?=
 =?utf-8?B?MU1tR3pDMkFieDcvbnJEVW5qTC9mR2wvMm90WEw1WHhMZHNpVFRCT3NDVVlJ?=
 =?utf-8?B?b2tJdUxZNWtGMVFPenZ4OE9VdHVYN3V4NEVBYTY5NnJCU3NmcnJwM0JSOGZ2?=
 =?utf-8?B?WWJ5bFg4S3g5WStHaUpZQU8zdDExcFErQ05TLzZ4TEQ3dmRQMDl0L09SYUps?=
 =?utf-8?B?aUU1TG4vaG1xMDRYcXdNVjdjYzgvZWxSNlQ3NzhycUVvMm9NQ1UzWUREbEc5?=
 =?utf-8?B?b2w1RnlSMGU5RzNmcWNsWUJaMTYvcHFEM1gveDJEVW5US2VBMTFlTWQyeWc5?=
 =?utf-8?B?L2J2RFVuQSs5bzZUd2dPdTJjbDliUEl6K0FhZ2VjdXRraHVCT21DaWpUZkVx?=
 =?utf-8?B?N3JlRm5lZ0hnTk9Sem43T05GRko5WHN5YldVakhHZ2QydWRsL21veXB0TFp2?=
 =?utf-8?B?T2JnMnBtODBvRHlXcnl1Ym8rVTlRdnNJV3V2ZFpiQjEzWEpvb0tPVnhuU2dP?=
 =?utf-8?Q?hpLdZAMCdXPHS75G1+/HMxK0T?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 35a7f016-64c0-4208-bcbc-08dbd98b31fe
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 21:00:06.7058
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XoD310rKuNfLigbj0yJEyyyBM9jlY6uF1R8HGc7bDEvLu56JGxxGPlmM84HbRreMyRyerGGBYh+P67ylJIUZKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8162
X-Spam-Status: No, score=-5.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 30 Oct 2023 14:00:36 -0700 (PDT)

On 10/30/23 01:36, Nikunj A Dadhania wrote:
> For AMD SNP guests having Secure TSC enabled, skip using the kvmclock.
> The guest kernel will fallback and use Secure TSC based clocksource.
> 
> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
> ---
>   arch/x86/kernel/kvmclock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index fb8f52149be9..779e7311fa6f 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -288,7 +288,7 @@ void __init kvmclock_init(void)
>   {
>   	u8 flags;
>   
> -	if (!kvm_para_available() || !kvmclock)
> +	if (!kvm_para_available() || !kvmclock || cc_platform_has(CC_ATTR_GUEST_SECURE_TSC))

And is setting X86_FEATURE_TSC_RELIABLE, as Dave Hansen suggests, enough
to prevent usage of kvmclock?

There was a discussion here:
  https://lore.kernel.org/lkml/20230808162320.27297-1-kirill.shutemov@linux.intel.com/

Thanks,
Tom

>   		return;
>   
>   	if (kvm_para_has_feature(KVM_FEATURE_CLOCKSOURCE2)) {