Received: by 2002:a05:7412:85a1:b0:e2:908c:2ebd with SMTP id n33csp70495rdh; Mon, 30 Oct 2023 14:14:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfkXke3iliYdQ89cpEpIsctFNUcMhpjz7PCLeshxqyvRYR4/nM/6bqGmeZR3K2qCWaSQdO X-Received: by 2002:a05:6a20:e119:b0:16b:8498:7d29 with SMTP id kr25-20020a056a20e11900b0016b84987d29mr11384662pzb.27.1698700471610; Mon, 30 Oct 2023 14:14:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698700471; cv=none; d=google.com; s=arc-20160816; b=o3mTMZgfXhDoiKcJD27buddpEsw5LJhTmkoTS8B5qRRyU8eTwa3q7G1Ysvjy/BqHQI ZXFdz+YLpqg1TBK9cQE/bOsq5vAtwyy6smW06PSZqIuaDyPv0/Kwt4vksUNwbIoQiJcy c0z1hr64TDt0VlR2XO/eTh6gFAZ15S11bNM4Es20ZHnb2xUgtA0sSQIGdlMybyNcnXnT ZPYlK+FpQ9bMe3OzSImwhs5PWBHW9BRgTWg2wZPC4WIr3aTVuxv99Aq1R6zrdSsf0oit RKifgilDKdqjvPbR2FgipYRHfARxDaJH2DVHb6M5w+sxhsTOmR9Z7P1embTCAU/24Wxk rY+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FHDjm5OgiKx3EgZqFfEjFepEWVhsEVZS/sP/rm1i8dA=; fh=0R9xswzX9EgNxq5y/WJhFwn8AAPNo5MoZPmJX375DmM=; b=pqiBSgRvCdm40j835KtqHgA23Q3Zs4xOfTvEHwJgqvVaq595UHKBJFbUlkHgmAliej 5lu6YSXX7Krwsrsy8o9VCzBDTY75BUO1JUgAEaVHcbclz1TpJUlRsFQPvUmcnhBhB9Ui Vv4UeJ+uAPFBOBeE4le0bZvwI8WRanqVuCZo7x7Na/+JxIRcMiRRM6xepXMpJbA2J26g zb/uVvjV/kX+dKuaVdqt0pTHtMZcD5WQl1TPZL7W6RiigllA2+b+WoFPlN6y7d8GioZz ic2nxkdjdLC2w/mCK+kajyjMF/Ofc+TFYwOmYE1ZrpsUF4kJ+U21zKLSgxQgbptU+l7i PuVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PQJF7tAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id j13-20020a63cf0d000000b0059f0cebd04csi3894094pgg.722.2023.10.30.14.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 14:14:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PQJF7tAd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 5AD4B80B06D2; Mon, 30 Oct 2023 14:14:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231927AbjJ3VOU (ORCPT + 99 others); Mon, 30 Oct 2023 17:14:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbjJ3VOT (ORCPT ); Mon, 30 Oct 2023 17:14:19 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30D97E1; Mon, 30 Oct 2023 14:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698700457; x=1730236457; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FHDjm5OgiKx3EgZqFfEjFepEWVhsEVZS/sP/rm1i8dA=; b=PQJF7tAd6IZmvhtvGoSgBk5uxDVuk5+wE+yIIKqa9DtDypAfvhjbWWjK xjclgpjB91b1+v78sFIHb3fGQqAv9bTJxUAyqbf6FZ/F5rgtc5nbatbkz 9Oq65H5C3yXtgiA2TsxOXjaclpBcESOjJwkPrvPAXHf4D5m9rchLb09ki EOrrM73PnYIoxEb2ujGxNrzzXgirKfl8VMGy6r895CGPIZPc94xxWQ1Q7 AmH/61H/KtRFLbmgFYOiUoq9J9hQ8ZoXPPn11megAQiCHW2OaudN37Pm3 FDbbUTj1zP9uwHlolb8RRZRHz5uwR+OME4Wzd/aJWIPBRiLasUtmLLYkX g==; X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="454630970" X-IronPort-AV: E=Sophos;i="6.03,264,1694761200"; d="scan'208";a="454630970" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 14:14:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="933900736" X-IronPort-AV: E=Sophos;i="6.03,264,1694761200"; d="scan'208";a="933900736" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 14:14:14 -0700 Date: Mon, 30 Oct 2023 23:14:11 +0200 From: Raag Jadav To: Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Andy Shevchenko , Linus Walleij Subject: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case Message-ID: References: <20231030155340.3468528-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231030155340.3468528-1-andriy.shevchenko@linux.intel.com> X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 30 Oct 2023 14:14:29 -0700 (PDT) On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote: > iWhen ->pin_config_set() is called from the GPIO library (assumed > GpioIo() ACPI resource), the argument can be 1, when, for example, > PullDefault is provided. In such case we supply sane default in > the driver. Move that default assingment to a switch-case, so > it will be consolidated in one place. Looks good. iWhen -> When Raag