Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <5f7fa4e8-4bce-4bf4-a557-6993ae5f2e4c@intel.com>
Date:   Mon, 30 Oct 2023 14:18:31 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 1/8] x86/resctrl: Prepare for new domain scope
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        "Peter Newman" <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "Shuah Khan" <skhan@linuxfoundation.org>, <x86@kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20231003213043.13565-1-tony.luck@intel.com>
 <20231020213100.123598-1-tony.luck@intel.com>
 <20231020213100.123598-2-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231020213100.123598-2-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUVCekR5ckFXRmdML1B0cjZuZ3dTYUNYNzZCUngyb0ZDeTQ5SzhKK3I0dkxM?=
 =?utf-8?B?QzdSclJEb1pWOGZiZlovVHJTV3Y4SVg0aEhwaXI5ajdBNUtiaWp4VTV5WXpN?=
 =?utf-8?B?N2pMUU5nK3BXM1NkWlVPMTJyR0grSlloaktyNmIreEJZUzVwSEVLZ0cwdVFU?=
 =?utf-8?B?ZlplUUtiT2hCVUZ6V1NxcmhkaDl3QWd2c3Nsdk1uWndjT0I4MUQ0dW9yMWhE?=
 =?utf-8?B?azBVNThiQm5hQXh1aWlZeUZSUW50NzhQbFpyaE5TOGNhVTFUYlFla0xrbUtB?=
 =?utf-8?B?NVdNNEJLWUp3TktPUjZhelp2eXJQcFNJNitHTjJLSU5ualh4cDVqdlpwVXlZ?=
 =?utf-8?B?bjl0bGFoWk1VMERxRjF3aDF3WjBZSXN6OTF2OFBCVzQySUcyOUlBUUFST2xI?=
 =?utf-8?B?MXB2NkF1cVk4SGJDT05teWd1eFNkdm1qRU5zcE0xeE81U0RoUEVQRHFlaW9t?=
 =?utf-8?B?MkMrSXBjblc0a2dlVGNNZDdUNVd0MDJtUytQR3IwWWlzY1FXTVo4RzVWRmE3?=
 =?utf-8?B?QlhVS0VSQmNiVFhQZm81MVVvbjFxUERTM21peTBZSC95SGZ5OUhOVmVMNzhx?=
 =?utf-8?B?cEhybnd5OWVDMzAwMzFTVnZqZzdDeWtjYlpyUzkwUG1ka2FPRmFWZTZUTEpO?=
 =?utf-8?B?UDY1MGJEQy9DblZFVEJreExJa2Z2Q2xhMzJZVGR0VEhhWmNzSWhjN1JNYnRx?=
 =?utf-8?B?VkV0elo4cEpKWFdBSklVRjBIbi9ZaEdNdy9qYkNVYXR6QklDK2Fqckk1S0dF?=
 =?utf-8?B?N0szMHFnS0xlSFA1eW5EcEovbGpudjlXQ0Z3Uml3YzZibys5M0JCb21xTmdX?=
 =?utf-8?B?YUJRMFh6alh6K1Y0QmV2YmZEQmE2ZWs1KzdxK0labTdKTlQyUDIxclRoUDND?=
 =?utf-8?B?NWx2a0lpYmVpelM0YkgwQjVVZy9yK1dlQndKYjkyYUE3ejVkWVJuOVJWMHlz?=
 =?utf-8?B?RkQvT1AvWnc2VXdIT0NXNGNzem5RZHJ3ZTRrUDBoSitFMkMxbHdBYnJlQWo4?=
 =?utf-8?B?ZjYzTjZRQll1dWJSRzkrNU1QZG5kcTFudHh4Z0YyZDlrYVJlL013TmovWkhj?=
 =?utf-8?B?V0ZTczQwZ0tpTHh2YTA3R2hEckR6dFkzVTVnK2xoNE04ZmRlY1ZwcUg0Mkdm?=
 =?utf-8?B?NmNZNENyUTRISjB6SnRYMmxUWE4vU1VBek4ySGtoVkNVZ2FtcDFvTEh3a3JC?=
 =?utf-8?B?WS9GN0VkNTNES211Z1JHV1dKWVNxS1ptQUJKZGlKOTN3cVg1MlVVaEpIMU5r?=
 =?utf-8?B?a1ZvREJEcmJmMDcyVGFmakVhWXEvRGVRU05aSVBla1EvMUdGTlBRK1FXY3Rm?=
 =?utf-8?B?M2FKQkw1amN0MTB1dnlwaElieUxGZ2lDWDFKUUdGRkppQXN3YzhTNlJUZFJy?=
 =?utf-8?B?SlpaZVlhZlVRNUdDeGp1VFpIU0ViQ3hWZUtVR2pJWmkrVkVEZGtLai9zaHgw?=
 =?utf-8?B?cHRhWi9rdFF4WU9IZ3F6UmlMbjNReTVMNm1kNGtnb21maUZpVUtja0piTHpM?=
 =?utf-8?B?dE9Mc1EwdkZEd3NyVndXWHZNZEZLQWg2dURUTGEzdXpDcVhlTEVPa2tpYWtJ?=
 =?utf-8?B?VzBCTGJsV2ZHS3NZZWY1MjM0Sk9aQzJjZTNmdGF3ekRCcDBKVW1vRDZUMk5n?=
 =?utf-8?B?TXY5S3hDZDFDbzJ6OG1nVHhvOHJYYlNJbGwvOTdrRmNLU0dacUVpTDZUOEt0?=
 =?utf-8?B?bnpUSEtYOEs0dWVwN2hGMXpjTHBya3Zna1lXSUY0RFNhV200Z0VaY2gzSldP?=
 =?utf-8?B?OTgyS3dqa3lRV0NoR3RmZjI5NGJ1dGFjRCtBM1VMSEc0b0FrSGU3VTRIczlh?=
 =?utf-8?B?SkJWRm5yQVBCT2NjV2tsOU9JQXoxWERITFg1Wk4zMTRFMjRoT01MaXFFR3M5?=
 =?utf-8?B?NlhpdS8yeDZvWlVlTVhjcVlQTzNqa2JZVUZrWDRmeDduOUQveGR0WitGeWtS?=
 =?utf-8?B?OVhub29tTWh1TnNEUWMrY2ZldC80eWZ5MUxHYUtMQnhLb0JBNTB6eFhkdlM4?=
 =?utf-8?B?Vm1sSjkvSmZDMUVpVTFSTkc2Zy9XV0ZpTnQxTm13TmZ2SGRtdkhMWXNrNDdo?=
 =?utf-8?B?Qzd6WlVNK2srblRsdWQrOE9nZXNWWEZSUlRkMXhtVFo1UzBxRVdtMjl1RnFR?=
 =?utf-8?B?TDNFOVo3RElhUjNybGlsQktUMWNZZlJVMmRMam5wUVROaUtSWW5qWms2WFlI?=
 =?utf-8?B?RlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3db11dd6-8382-4a33-9c22-08dbd98dc646
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 21:18:34.5515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UeOntD3WZ1ZehT1WxWXwdKkTxgL3sXSJ6RqQc/Kx+OMmxpREsvdwXY5W+SgxlpDXDAFn1PPlxIJCrR6LlyK/+wRFNJcswQ/jAf9Q8YDZQMY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7070
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 30 Oct 2023 14:18:50 -0700 (PDT)

Hi Tony,

On 10/20/2023 2:30 PM, Tony Luck wrote:

...

> @@ -506,12 +519,17 @@ static int arch_domain_mbm_alloc(u32 num_rmid, struct rdt_hw_domain *hw_dom)
>   */
>  static void domain_add_cpu(int cpu, struct rdt_resource *r)
>  {
> -	int id = get_cpu_cacheinfo_id(cpu, r->cache_level);
> +	int id = get_domain_id_from_scope(cpu, r->scope);
>  	struct list_head *add_pos = NULL;
>  	struct rdt_hw_domain *hw_dom;
>  	struct rdt_domain *d;
>  	int err;
>  
> +	if (id < 0) {
> +		pr_warn_once("Can't find domain id for CPU:%d scope:%d for resource %s\n",
> +			     cpu, r->scope, r->name);
> +		return;
> +	}
>  	d = rdt_find_domain(r, id, &add_pos);
>  	if (IS_ERR(d)) {
>  		pr_warn("Couldn't find cache id for CPU %d\n", cpu);

From what I can tell the original implementation relied on implementation of
rdt_find_domain() to do error checking of the id value, printing the above pr_warn()
if id was found to be invalid. In your change the error checking on id is moved
earlier yet this original behavior is maintained. How could rdt_find_domain()
possibly fail for this reason at this point?

> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> index 8f559eeae08e..8c5f932bc00b 100644
> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> @@ -292,10 +292,14 @@ static void pseudo_lock_region_clear(struct pseudo_lock_region *plr)
>   */
>  static int pseudo_lock_region_init(struct pseudo_lock_region *plr)
>  {
> +	int scope = plr->s->res->scope;

enum resctrl_scope ? 

>  	struct cpu_cacheinfo *ci;
>  	int ret;
>  	int i;


Reinette