Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <b4053448-8ea7-47e5-be6a-d206f7d7a268@intel.com>
Date:   Mon, 30 Oct 2023 14:19:11 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v9 2/8] x86/resctrl: Prepare to split rdt_domain structure
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        "Peter Newman" <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>, <x86@kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20231003213043.13565-1-tony.luck@intel.com>
 <20231020213100.123598-1-tony.luck@intel.com>
 <20231020213100.123598-3-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231020213100.123598-3-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlZlNFVVU0dOKzBBMnNpc3dSenhWWi9EdGZHdHFyUkxRVzB1MGwrZFFIdXd0?=
 =?utf-8?B?RnYyUGlPZ2Myenc1SDRQV21SLzIwZkxpSGxzS2QxbFh5V0J0TUtEVmtGQmx5?=
 =?utf-8?B?VWtvOTh1aVg2N3RYR2VJSGd6RXVnUFhocy9IUTduS3dQVGV3QWpnMXl2cVNk?=
 =?utf-8?B?YTFtOGVBeUhMSG9xWC9JcDFwSHpxd3V6SVpxc2hHVVR5QmpPNVpNRUdqQTdj?=
 =?utf-8?B?ell5Mnd4OVREQ0k2VHh2UlNPQm4xSVdIUkp5MlFTYjFQcHVPc09VMmJqSXBm?=
 =?utf-8?B?c3lmU2JlZmpjY2hSMzdGN05vaHB0c29nVjhsM3dGc0VRTUNZZVExd0Zac0RB?=
 =?utf-8?B?SjQyTkc3Mi9GNUJDSDRLY0RPTlhudlFKZUtNUk9DRy9VbDl2dCtLYnlBTk4v?=
 =?utf-8?B?VmxVWVRod2llU2cyN3l4dkE0U3JWM1hVV0kyalE3RmRwYTJsQzJxTHAyUS91?=
 =?utf-8?B?OUM0V2lraW9HNHQwSXVpTjFwdXNlQkpremw2M0RMN3VqTTlIL0UyclZuZ0Vi?=
 =?utf-8?B?NHBPWnRiWHlIUFZBVDJqYjF5K2F1MzVnQUlmUm94YjVZZGJYU05hMmJYd2RH?=
 =?utf-8?B?ZVQxcDl3eWlTQzFlcm80enF0SE5vZ0ZuTW5aMFIydlIwRFVGZlNzTDFNVjFv?=
 =?utf-8?B?c3ZNSzJRRDF2aXMva25ERXFqRC9teUFEM20rM2k1eHh0ZnRmWG1TZHVTbUhD?=
 =?utf-8?B?cml4QjR5dDE4RUtneTJiQitEUHRPNEN1SW16UUJnN05LMWovbDViM1FiWCti?=
 =?utf-8?B?MWE0Ulo4YWd1VzV5NENLbGtaZGt4U3dzUlpISHJCOSt3bU80M1JjaG1QTTA5?=
 =?utf-8?B?eEU5ajdxN2ZGSW9EK2FaWFVEejdqREw1aVN1Q2ZtVEhTZG83Q2VSQUd0Vm5V?=
 =?utf-8?B?Y2FlMXA1UFVSVUpabGk3eEdtVENLOFd1RXV6cmFYeTFmVTlhK2JtbFpDZGR1?=
 =?utf-8?B?TE5aU0hVWThWaWhyYW9vY1IvUDNzZHN5Yy9NamVmOVovVnhhd2dQTWRHcFJZ?=
 =?utf-8?B?bi94Q2dIKzlCdkV5L2orYktxNm01RnJIYU5qUTlMSkxOblIvSkc4KytUNHBQ?=
 =?utf-8?B?Sng2Ykd4ZFJFQUxyNC8vY2FYenRHYzQ0VFhvQm8vMC9yUEFnd2pyOEs0RCtB?=
 =?utf-8?B?VmZEZnl5azFocHRtTWFtSDgvSVBTWjRPVm1Ndk5Wdy8wYUlnc01EK3M0c094?=
 =?utf-8?B?SktOOFNkT0lka29PMDJGUEEyQ3crbmhCNU80eTVESnVsYU03NlI4YTJKT1Zn?=
 =?utf-8?B?MnZIdXdLa0tmY3NOS21OV0laa2NIV3V0M05oQUJQaTZjQ3RxSmVhcWxxaWxh?=
 =?utf-8?B?ajVMbkc4ZkdOczlyWmlWZUN4cjh0M0NtRHhXQjFDaDFLZGxXcEptQjJJMjVz?=
 =?utf-8?B?blYrY2lZUFlndU43Rmh1V1BSajRZUGpJOVk4M1NkSFFBempwSHlxOW00UVly?=
 =?utf-8?B?cVRxWlVMMkZYbWNOVEp4azdiSjFCZ2xsT012K3BCdVQ5QVFwSHB5cnhtaUdO?=
 =?utf-8?B?SjJhZHlHUFNuL3l0L2c3M1pzU3dnRlRXRnUwNVVJQldQUG5oT05nWUNyTzdI?=
 =?utf-8?B?eVJBMHgwUmI3czkwT1JydzhJdjZjT21mdUNIVlU4NVphS2tsaFVZZmc2L3Jp?=
 =?utf-8?B?cDNVQnlIcFNzMkVJM3NvcGIwNUVSTHpXVERFSVNQYngzdXZMUktzOWw5b2hN?=
 =?utf-8?B?amJ5OC8vaVY2dU52N09yUUpscFFTREpmVXZsTVVuTWkxU2VxRUJFVjVGNFht?=
 =?utf-8?B?VXdJMGVhVSt5WGZxN0tqUlp2TnRMdVQzRU9HVUhFL003WXF6eHV3WnN2VDZG?=
 =?utf-8?B?M3ZiRXVUblNjWXJVWG5hUDJLWFZ3cE5nY3lJMDAxdStuNVdtSjRpbjhiRmNT?=
 =?utf-8?B?RnZFdFovSDBnNzl1N0g2S2NrcTllTzgwUWVWUEYrUGJ5Q3cyUXJpMXFJM2wy?=
 =?utf-8?B?SGIwTFFPNTJFMVFXdkppWStCTzBidkJ3SGJqOXhLaUpYa2E5Wms1Z3FkUmxy?=
 =?utf-8?B?TUUrS1hkS1NacSs0a2xTQVVuVFU1cXI1amtKVHJGK01hYU5WZDdHK1NWd2x1?=
 =?utf-8?B?QmFLS3c0Y01TR1BMTjhNcTg2WEJBVmNZSDZncjdoZkNWVDZZQm10ZGYxdXVV?=
 =?utf-8?B?RWpEQTZMTk9mOWR2L2hLWC9LSDJZRnYrV2VPOWZzNGZhOHFMb2ZRNFRjSVpo?=
 =?utf-8?B?a3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 067da550-91c5-411e-c853-08dbd98ddcb3
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 21:19:12.0986
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PW80HOhnMFnEKjdn2Vqa2SmHBdvzeOMCPEWKldJq1wlXVCYs2gsS6rVeSu/H1ntbPIgvtOjE4folFo+h9AAfHCPb8wRJtAg77CuIo/vJPl0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7070
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 30 Oct 2023 14:19:27 -0700 (PDT)

Hi Tony,

On 10/20/2023 2:30 PM, Tony Luck wrote:
> The rdt_domain structure is used for both control and monitor features.
> It is about to be split into separate structures for these two usages
> because the scope for control and monitoring features for a resource
> will be different for future resources.
> 
> To allow for common code that scans a list of domains looking for a
> specific domain id, move the "list" and "id" fields into their own
> structure within the rdt_domain structure.

The motivation for this split is not clear to me. Here the motivation
is to support the code that needs to traverse both lists. Later (patch #4)
the motivation is that what remains should be "just the fields required for
control and monitoring respectively". The comment "common header for different
domain types" also makes me think this new structure should contain all
common members?
The reason why the motivation needs to be clear in this regard is because
there is a common field, cpu_mask, that did not make it into the header.
Should it?

> Add a "type" field to the header to be used later so that callers looking
> up a domain can be assured that they found one of the expected type.

Please move this addition to when it is used.

Reinette