Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <72d0fdeb-b08b-45f2-8a24-d20db69c4a02@intel.com>
Date:   Mon, 30 Oct 2023 14:44:39 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] net: r8169: Disable multicast filter for RTL8168H and
 RTL8107E
Content-Language: en-US
To:     Patrick Thompson <ptf@google.com>, <netdev@vger.kernel.org>
CC:     Chun-Hao Lin <hau@realtek.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <linux-kernel@vger.kernel.org>, <nic_swsd@realtek.com>
References: <20231030205031.177855-1-ptf@google.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231030205031.177855-1-ptf@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0dyY0RBclp1bnk0RjZNOUJVMkRGOEx6WVFQWG1hVk9nVWh6RnUyR0ZDbzdL?=
 =?utf-8?B?dmIwVndqK0xMa2gyT1BtU1FoS0UrczYzWmdQT2RneWVEcGZpdGVsY0hMajFO?=
 =?utf-8?B?SXBpL05wVWpGSVh3YzMyV0JqbGhMRHV6ZHIrcnh4cGFnK0tFOU5QM0MvZ2N2?=
 =?utf-8?B?aGh0U3pLWW1sOTdzK1lNZzVUZ3l5clRsUnM1Q2FRL2dIM3g1N1V0djZpTTZI?=
 =?utf-8?B?SnFKTXdNd3pIaytWaEJYS092cGdnNDRxZnZJd1cwR2lnTHdrNmxFQjNFc2Np?=
 =?utf-8?B?Z21BYVVueWsrQkZ5RDhlSEh6NktDZFlISE8yRzNUMlFwbnUyd2dPY3Nwb0N4?=
 =?utf-8?B?TzdjN1djZlI2WHlFRVNLRXRmKzg1Z2FNdllQejlid3JVUTVSbEpaeVVhek5z?=
 =?utf-8?B?QjZsb2ZyRnZNTjVoU1BLNkRQd1h5V0JwQVF6RkNKVmVPK3kwekdHcEE2OG5I?=
 =?utf-8?B?VHdON2lyZ09ZYWE1ZTJsSHJqZ3hOQkU3TUdIMks3bUZncUt6MXYydEVPZDY5?=
 =?utf-8?B?dVlId1BTY2VucWFRZmNwbDZHOHVwKzRWbTQvbFh1ekFmeHpUZXFiUWNJMFNm?=
 =?utf-8?B?Nm80Z0ZKT1V0Y3hJRk43encwaU1HSlUyMjl6U0tUMlpPQytYVHBsaTdBUXNU?=
 =?utf-8?B?ZThNQ0VCcEJybnJBZzZPUTlkRUlrbnBTazVKQWgxS1NVRHdiaDdiQnBVaTY3?=
 =?utf-8?B?REM1OGJGRXpvQlVkaWE5N2J0OFYwcmM4OUdxVmJnVVlwWHpnb1hkdFNMRk9x?=
 =?utf-8?B?cXFHTmNSK0hHOUkxQXBkOXo2c0hyV3cwWCs1Rkw1alBocVRZRFNMc3ViMU5E?=
 =?utf-8?B?WjQ4eG9rdTRPRkcrbUMzbHljdDE5L2FUQllucHFEWTBBWmNSbVYybEthclpM?=
 =?utf-8?B?REl0Sithb25xOEo3UmtJVVJjbHdQT1UwOE1qU1Z6ckNrQ0MrOUhoOGZYcXFF?=
 =?utf-8?B?dWJ4blJzYjZwZHJYcU9zYkxmV1NsMG5VNVdjR0dGczl6UGVFbTU3cW4xN25z?=
 =?utf-8?B?MzdUalNSaUVOSThaWE5WcEhHNVNDSVZrQ0pSU2tPUnJaeWRSM3pSNmhSMU9M?=
 =?utf-8?B?MThzNStyb1E2aTVtS2ZvRVcxY0NqVmVGM002ekJYdmtCaUFGWUNzUSs4TEJz?=
 =?utf-8?B?U25jOXh5U3pCc0tic1I5TjU3YVJjNTcra3JKUzFWazUwRVhkcEIxV2luRUFs?=
 =?utf-8?B?bDk2WklTSFpjN1p1ZHJzVEdFdVFWUlY4akVGaEFTVUxKbWh3dmRmM2Z0N004?=
 =?utf-8?B?SFR0di9ZalRNMjhEZFI1b2I0NzlVWFF0L0ZFQTk5dmt0SXk2VngxU3JZWG4v?=
 =?utf-8?B?S2VYR3dJQm9UNDkzeWJhUTl1WlFrTmV5SVVUcWpUeGREWmhZRGNGMGl2Vmlz?=
 =?utf-8?B?b3A1YWpVTXM0UzRvNVN4bXhKSDA0dmxrVnozYjhUSEUxc2Y4eUFDanZHZTVD?=
 =?utf-8?B?Z1B5aytLUjd2N3pGaDlyVThjNmtLNTdET2JmSWxzZ1ZGdUhMWXl2SThpSDBB?=
 =?utf-8?B?Q2FJalZJRGp5cUN1NElQaURVdWVKamhncDAzanIxbWJ4WExUc0doNWhOeHF1?=
 =?utf-8?B?d2hJY2N0NC93RTdpbS9idzJnVkVKZ2NlSEU1ZzZqeTloZFJObHZtc2hQc0h3?=
 =?utf-8?B?QnRESXNiaUZyazNPWnQrRlV6WU10Y2c0cldlZVFmcXg2dDVCNis1eUovQW81?=
 =?utf-8?B?eHFMWmdkM0xlRnFoUUlBTk84aUlEVXFiZDVrS2I0SnR5SHhrZ0ZJWWl3U1gx?=
 =?utf-8?B?SDFhaGYrbmUrdUhLV2RXSk1aRVJtdDdZUmk5cnZLZUMvVDBQbTJjUkdISk9x?=
 =?utf-8?B?WTAxUTRMYm54QnAzT3dPcU15b3F1UGtXMkt5eVZ6WFpFRFpqdGVkcjFTaEFG?=
 =?utf-8?B?S2RlekVJbm1uNjFjR2JYSGVIREcyVnhMTXpmc1pURGh4bDJvUWxrTGgzMXA0?=
 =?utf-8?B?SE1MYTNQc1BkZUdqRW92SFRaUXdJbkhka1EyUHQrZkUxTlkvMHNYUW5jN1Qx?=
 =?utf-8?B?QTZIZTF0dFpEV2JLYjdUOXRSaXJSUGc3dmptYzJpbmJ0WDNmb2lTNU4xZUNm?=
 =?utf-8?B?NkZzUmU0aTJFSDd6MGVXbXRKaXczYjRFUVkra1pEZkRaaEMxTUlmbWMvQ3FT?=
 =?utf-8?B?UkREYlp0a1VKVlFpYW5pMndFZ0ZyQmcwRmh4eXBjQ1lPbFB6TWp1Nzg5SzdI?=
 =?utf-8?B?U3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 664b33df-eb68-414c-3fd9-08dbd9916eaf
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 21:44:45.5438
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Eg5NJqiwdRRznAjdxDrxp/kqdJGcIiV1veTZMUmTvubTXlgpZndI4wVh9oxLvLF57BhHgDzczyLi+mKJunVUpxi4xQ7Dz+npsJjPt1nYVzA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6728
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 30 Oct 2023 14:45:19 -0700 (PDT)


On 10/30/2023 1:50 PM, Patrick Thompson wrote:
> RTL8168H and RTL8107E ethernet adapters erroneously filter unicast
> eapol packets unless allmulti is enabled. These devices correspond to
> RTL_GIGA_MAC_VER_46 and VER_48. Add an exception for VER_46 and VER_48
> in the same way that VER_35 has an exception.
> 
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: Patrick Thompson <ptf@google.com>
> ---
> 
> Changes in v3:
> - disable mc filter for VER_48
> - update description
> 
> Changes in v2:
> - add Fixes tag
> - add net annotation
> - update description
> 

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>