Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <ef101904-a615-4527-8d8f-1f43b3d997f6@intel.com>
Date:   Mon, 30 Oct 2023 14:53:06 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 3/5] r8169: Coalesce mac ocp write and modify for 8168H
 start to reduce spinlocks
Content-Language: en-US
To:     Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>,
        Jason Gunthorpe <jgg@ziepe.ca>, Joerg Roedel <jroedel@suse.de>,
        Lu Baolu <baolu.lu@linux.intel.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
CC:     Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        "Robin Murphy" <robin.murphy@arm.com>,
        Heiner Kallweit <hkallweit1@gmail.com>, <nic_swsd@realtek.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Marco Elver <elver@google.com>
References: <20231029110442.347448-1-mirsad.todorovac@alu.unizg.hr>
 <20231029110442.347448-3-mirsad.todorovac@alu.unizg.hr>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231029110442.347448-3-mirsad.todorovac@alu.unizg.hr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SG5tNGozOTJBTHFGSno3ZnRYN2RrRWRPM21teHRTKzB6ZGN1WWNkV01vem94?=
 =?utf-8?B?V3hJQ2E4cnArUzVXZWh4U2k4Ky9VWWVZM1QvZWJRcWRxZGJaVHI2MC9ucEhj?=
 =?utf-8?B?UXAyek1KUmt4Z3VGcC9GVHhmYkNYekt4WjdYZWFtSzBEZEpHVVlaSi9BY215?=
 =?utf-8?B?cFVGZ05iS3UxVVJ1UG5BaDIrMXQxclNJUGVoaTJQcVBBOC9lSk9lME5vRTBY?=
 =?utf-8?B?Y2dUcitBaHNoTUFsd0dXRWVZR29KekJkUW1IdXk0NHVkU1RJeUpXSXVEbSta?=
 =?utf-8?B?Zlc0b1BVZ3BNL1dSTHBMWTVkNlRJOU5ZcGoyTUQ2eUdtVGVoelNyNGVNcXFa?=
 =?utf-8?B?K25nRWdMa05ybHhiTHlmaDVnV29sdjhzOVJzanRUTjdVbmtTYXhBN3dhN3hZ?=
 =?utf-8?B?dkQ1SFZoTE5KTkNRQkk0V2FHRXJlWm11dW9WVkNhQ1I1L25rYWI2d1hnbG96?=
 =?utf-8?B?YTd6THY5bXcwbnBUZ29jWDZuTnlraHZFRGVGaTQ3amJacDJ5Tk4zZUdDdVFj?=
 =?utf-8?B?cGhISHlZMDhUMUtaLzdmQndyYWdzSCttVFpiZVpFbkF5SVE3bFVsYXI5TWtF?=
 =?utf-8?B?SXR4ZnMxSGpsK3hxSzZYbXQvMGtxZ2NtaktybG4vSVdzVVhtWFF4RjlLTVNM?=
 =?utf-8?B?M3ViRXh2bUQrRW1CVWdudVhzUnhqV1BVLzVJUGRuNTdENC91T0JXaXJkOTA0?=
 =?utf-8?B?R1FDN3VhQlNBRzZjKzBBRmFsOVlPMitXVnNSWWthTU9oTVV1ZVJLTndaWm9z?=
 =?utf-8?B?M2tKamN2RUtFcGtEWTVqVStrS0pqT0hDMy9aUlIxY0tBc3E2cW42NVRZVUZU?=
 =?utf-8?B?NkJSUllQRVBRNFkzRFA2S2VaQmJCZ0UvNGxQSnFQQmtrbkkzZkNpQ0lyTDZE?=
 =?utf-8?B?a3JOOHhOcWVJbmN6enJXTHFXMHlFeWR6QlhBd0J6ZG5DeVljd1RoR2g4RDlo?=
 =?utf-8?B?TVJQZTZqT1lRRU9VV2V4eENjdEdpSEdjQ0FETmRsdytPOWdXc1ZVNUNZMllH?=
 =?utf-8?B?VGtqUU9JRzZSOTREUE9keXRaUEQzaXJFV3NPdGVRVGVRSnlUb3NPd3M5TTd1?=
 =?utf-8?B?Nmt1aE13eldoVWdFaU16dkZxTGpQNGpoMU9HbTVESkRDNTdPdkp0b1RueEFq?=
 =?utf-8?B?ODhnSU9tRVg4a2ZyRDdVUXN3Uk9iTkQ0dks5dHl5VmM3MlBhb285YW9MMHpU?=
 =?utf-8?B?MHJUeGdMWHVtNlhEYjBVZDZOWmhoUmNvY1FFVllDQkIrNTRTRlR1Yy9Bend0?=
 =?utf-8?B?R1N6c0ovRG9JeGFjSEp3NEM5dFg0TndaTm9PSGEyWkxXdjIzNm1hei9nNGxt?=
 =?utf-8?B?RHROMzlhbWdobFI4SWhlbWJIZ1FNcUVTMjBqaDdqNEZ6cVhnS3hleVZub1Zh?=
 =?utf-8?B?M2dvN1RkU29lV3ZSekhnZklBVjZNckM4bm9PL2hIRXhSdVdWUVpEajhWczhk?=
 =?utf-8?B?OGFKTVZVb3Y4OHgrZ1QxVEdDRytQOTZaM1UrdTVDQ3RtNmh4U2NQRlpmQUVl?=
 =?utf-8?B?ODBDYzJMRU1rYkRjVEdMQ0xmVWxsYWt3RlJTYi9Gb3FCQ1BEMGt3MXdWSHc4?=
 =?utf-8?B?MCtBcS9hanBISDVZN3RLa2pVQ1lwaXA0SlY4RkZVUm1DelNBM1k4WkdqY2dz?=
 =?utf-8?B?YTU0NTdUS29wZlhGMjVsMjdyZVUvcHZHUmdTZFczUFdmYmpWNmFNcVRuQ2VX?=
 =?utf-8?B?ZXEzMmRzOVc4eE1BMnNjNkJtMjFIaXg2VjU5V0gvZmFBTUdZTWJiOGtPZnoy?=
 =?utf-8?B?QU5GR3FhUGRDOVBMZjl1S0c4Q2ZybCtKdUdtaXNOV3Foa3UvbG9kWEYyaFp6?=
 =?utf-8?B?aWNhWGVjUHhrYmRmaFhaZ1Y2eDVDTXQwK3YyV1NNcFhtOGdEYjFhcUJ3endF?=
 =?utf-8?B?L25nbnhkdWhjRWZnYnUweUhRQXRHOUdJRGJZUFNHOERlRHpEM2ZocVl5MERh?=
 =?utf-8?B?VkkyUlcxSFU0L3FoRVFVR21xa2RVZ1puZFJzaWZ4TzRJV0tDV3RFa29OT2JC?=
 =?utf-8?B?amg1WUlSSXRwQm42MDNKUEtmOHdWL1pJOEJIbTE3ZE1vRjFRbHA1dmlNODJW?=
 =?utf-8?B?WSt6TkpURU9ZdUpldTVoSlJnYVFaMllDUWdoME84UU5aUmRCL094dU9SSGg2?=
 =?utf-8?B?QzZZQmRJamVCVGptWGd2a0VJSmVTa2g0WlJVK0loT0N2VTZXcUVhVFU0NXpy?=
 =?utf-8?B?S2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dca96bcf-cb13-46e1-b716-08dbd9929ace
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 21:53:09.0119
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RVLwORCb9GD1zlEvW/TEV+YJqNSRzcIbSYTchqYI7bkfc2+1NZXMYGwrrNzXSjpwTT/W79/3CPPsx2SCYnizvgJB1IT45KqZ4hCmDfRc7lQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5549
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 30 Oct 2023 14:53:28 -0700 (PDT)


On 10/29/2023 4:04 AM, Mirsad Goran Todorovac wrote:
> Repeated calls to r8168_mac_ocp_write() and r8168_mac_ocp_modify() in
> the startup of 8168H involve implicit spin_lock_irqsave() and spin_unlock_irqrestore()
> on each invocation.
> 
> Coalesced with the corresponding helpers, r8168_mac_ocp_write_seq() and
> r8168_mac_ocp_modify_seq() with a sinqle lock/unlock, these calls reduce overall
> lock contention.
> 
> Fixes: ef712ede3541d ("r8169: add helper r8168_mac_ocp_modify")
> Fixes: 6e1d0b8988188 ("r8169:add support for RTL8168H and RTL8107E")
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
> Cc: Marco Elver <elver@google.com>
> Cc: nic_swsd@realtek.com
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Link: https://lore.kernel.org/lkml/20231028005153.2180411-1-mirsad.todorovac@alu.unizg.hr/
> Link: https://lore.kernel.org/lkml/20231028110459.2644926-1-mirsad.todorovac@alu.unizg.hr/
> Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>